From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 25 05:50:15 2022 Received: (at 50663) by debbugs.gnu.org; 25 Jan 2022 10:50:15 +0000 Received: from localhost ([127.0.0.1]:47013 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nCJOw-00044E-Rh for submit@debbugs.gnu.org; Tue, 25 Jan 2022 05:50:15 -0500 Received: from flashner.co.il ([178.62.234.194]:45856) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nCJOu-00043t-ID for 50663@debbugs.gnu.org; Tue, 25 Jan 2022 05:50:13 -0500 Received: from localhost (unknown [31.210.177.79]) by flashner.co.il (Postfix) with ESMTPSA id 2B0AB40455; Tue, 25 Jan 2022 10:50:06 +0000 (UTC) Date: Tue, 25 Jan 2022 12:49:33 +0200 From: Efraim Flashner To: Nicolas Goaziou Subject: Re: [bug#50663] Add Mycroft - Voice Assistant Message-ID: Mail-Followup-To: Efraim Flashner , Nicolas Goaziou , 50663@debbugs.gnu.org, phodina@protonmail.com References: <87r18wbvnq.fsf@nicolasgoaziou.fr> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="5HWrADjjFQI9tDPU" Content-Disposition: inline In-Reply-To: <87r18wbvnq.fsf@nicolasgoaziou.fr> X-PGP-Key-ID: 0x41AAE7DCCA3D8351 X-PGP-Key: https://flashner.co.il/~efraim/efraim_flashner.asc X-PGP-Fingerprint: A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 50663 Cc: 50663@debbugs.gnu.org, phodina@protonmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --5HWrADjjFQI9tDPU Content-Type: multipart/mixed; boundary="v9H/NyOPkxDPuEzt" Content-Disposition: inline --v9H/NyOPkxDPuEzt Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jan 24, 2022 at 11:45:13PM +0100, Nicolas Goaziou wrote: > Hello, >=20 > phodina via Guix-patches via writes: >=20 > > The aim of this patch set is to bring in the MyCroft - private and > > open Voice Assistant. >=20 > Thank you. >=20 > I fixed some descriptions, removed labels from inputs, fixed compilation > with GCC 10 (for Mimic). Then I tried to apply the patch set. Alas > Mycroft core fails to build. You may want to have a look at it. >=20 > I'm sending back the updated patches to you, if that helps. >=20 > Regards, > --=20 > Nicolas Goaziou I made some changes to python-mycroft-core but I couldn't get it to pass the sanity-check or the test suite. I've attached my changes. Also make sure you sort the inputs alphabetically, I found at least a duplicate python-pyxdg. Also some of the patches include a line or two of unrelated indentation changes in other packages. --=20 Efraim Flashner =D7=A8=D7=A0=D7=A9=D7=9C=D7=A4 = =D7=9D=D7=99=D7=A8=D7=A4=D7=90 GPG key =3D A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 Confidentiality cannot be guaranteed on emails sent or received unencrypted --v9H/NyOPkxDPuEzt Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename=python-mycroft-core-changes diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm index 1834152c3c..b9c4529cd5 100644 --- a/gnu/packages/python-xyz.scm +++ b/gnu/packages/python-xyz.scm @@ -21986,63 +21986,61 @@ (define-public python-mycroft-core "02r0vxw0hsihnvviwn4fyspwky3kwq42f9z455q1s70k0snzhb28")))) (build-system python-build-system) (arguments - `(#:phases + `(#:tests? #f ; TODO + #:phases (modify-phases %standard-phases (add-after 'unpack 'patch-requirements (lambda* (#:key inputs #:allow-other-keys) - ;; Use newer version of pkg + ;; Use newer version of packages. + (setenv "MYCROFT_LOOSE_REQUIREMENTS" "1") (substitute* "requirements/requirements.txt" - (("mycroft-messagebus-client==") "mycroft-messagebus-client>=") - (("tornado==") "tornado>=") - (("pyserial==") "pyserial>=") - (("psutil==") "psutil>=") - (("padaos==") "padaos>=") - (("precise-runner==") "precise-runner>=") - (("pocketsphinx==") "pocketsphinx>=") - (("python-dateutil==") "python-dateutil>=") - (("fasteners==") "fasteners>=") - (("requests-futures==") "requests-futures>=") - (("pillow==") "pillow>=") - (("PyYAML==5.4") "PyYAML>=5.3.1") - (("pyxdg==") "pyxdg>=") (("requests>=2.20.0,<2.26.0") "requests>=2.20.0")))) + (replace 'sanity-check + (lambda args + ;(setenv "PYTHONPATH" + ; (string-append "./build/lib:" + ; (or (getenv "PYTHONPATH") + ; ""))) + (apply (assoc-ref %standard-phases 'sanity-check) args))) (replace 'check - (lambda* (#:key tests? #:allow-other-keys) + (lambda* (#:key tests? #:allow-other-keys #:rest args) (when tests? (setenv "PYTHONPATH" (string-append "./build/lib:" (or (getenv "PYTHONPATH") - ""))))))))) + ""))) + (apply (assoc-ref %standard-phases 'check) args))))))) (inputs (list mycroft-mimic pocketsphinx)) (propagated-inputs - (list python-fasteners + (list python-adapt-parser + python-dateutil + python-fann2 + python-fasteners + python-gtts python-inflection - python-pyxdg + python-lingua-franca + python-msk + python-msm python-mycroft-messagebus-client - python-psutil - python-tornado-6 - python-petact - python-precise-runner python-padaos - python-speech-recognition python-padatious - python-msk + python-petact python-pillow - python-gtts - python-requests-futures - python-pyserial python-pocketsphinx - python-adapt-parser - python-lingua-franca - python-pyyaml - python-fasteners + python-psutil + python-pyaudio python-pyee - python-psutil - python-fann2 python-pyxdg - python-websocket-client + python-pyyaml + python-pyserial + python-precise-runner python-requests - python-requests-futures)) + python-requests-futures + python-speech-recognition + python-tornado-6 + python-websocket-client)) + (native-inputs + (list python-pytest)) (home-page "https://github.com/HelloChatterbox/HolmesIV") (synopsis "Mycroft Core, the Mycroft Artificial Intelligence platform") (description "This module provides a hackable open source voice assistant - Mycroft") --v9H/NyOPkxDPuEzt-- --5HWrADjjFQI9tDPU Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEoov0DD5VE3JmLRT3Qarn3Mo9g1EFAmHv1boACgkQQarn3Mo9 g1GvCRAAuXAf/pkBB7Z11VKrewBDfJkpm6yp+UUoyHtCHtwuBe3IhmBw4kyLDB2m 20NRBB/5UtkgpwLP0SZ7u7dzbf90wEQRZbqBYCe8Fq8fx0CCQM4G1aDp9GX16Ii6 UE+9RGBvqgi5uC0viokxIP6n4KTBs77e/kac942Vkwb7q2a1ryf7+gjvj2CU88gs X99kg41Nr/9yF/Eh6jONOPoB8us+P64kuL4cuxFEkpnzKig0vjKxvG0GN0BTre/l nlKQhnerZ56LSE0frlcOOYTwCD+OpBWIplCJRlEl8DYhbFuM7eCEVB3HM5xrRbu8 bzie+oDRZGnkdJ5UcU8fSEJSgWLgg9UPrlxrPRvUbCY+/bNGqNM5ho3Q3foa/l6W I5KhTJpnpBcegE9Tt3V4Szriz3OvwbNXjtYL0b7PZAIt+iqygNsHS2hWOz75aGQ4 mhzHE6DPXYIQKtbTMa5TE76nC5P+ebQHF5Xc4Z7rrvXNZUBneWaekzQg9Vh0y/JH pGcXCVhJA+5YA7g9nB+M/0IhT32s9vrhUUZIJtKKEbDm4k8bTFkdHNMX405N1Jzr GpYNXveMZN2v1CHw/GLZGiaPM0xFgiqNbf3QpBHpKquXrIlN8yyMXtdkwuZHfZYo Jy/eBzc0Rr/DTwPhBsDPOvsLOmEBhXwArjOUN/vtB8oSfm1DLfM= =VlMw -----END PGP SIGNATURE----- --5HWrADjjFQI9tDPU--