From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 28 12:02:04 2021 Received: (at 50620) by debbugs.gnu.org; 28 Sep 2021 16:02:04 +0000 Received: from localhost ([127.0.0.1]:46760 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mVFYS-0004we-7y for submit@debbugs.gnu.org; Tue, 28 Sep 2021 12:02:04 -0400 Received: from mail-wr1-f66.google.com ([209.85.221.66]:36440) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mVFYM-0004w6-L0 for 50620@debbugs.gnu.org; Tue, 28 Sep 2021 12:02:02 -0400 Received: by mail-wr1-f66.google.com with SMTP id g16so58936326wrb.3 for <50620@debbugs.gnu.org>; Tue, 28 Sep 2021 09:01:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:subject:from:to:cc:date:in-reply-to:references :user-agent:mime-version; bh=IxM5UgeJGpQnUDmMsd6rP22VIUDbJ4knH5+UMAdA/p0=; b=IWmAS3pHGBqBpelbw14TFVilnAl/IhZp0YtYzTFApzg90U+vYtlSd9wBufKTfFDdDu knjxq6O4A2ruNHFPe6UriQSeENwT+JIlYu07Aoo2F4TaYv9qBYcctO2eJB94IJb8XFGM glpckUsf+fd++y/ZNnDLF+VER7nmMZ91LINkEtX5TKUc24KajE5dPHmnnSUb/yERe5kj 7GXZ6I4VGAwcPiCKreieisa2rjlg9kM8wMJUSINgqMRtQ9Xkqpsi96G+t1zsB9/8NgZI r44kqtYOUxQySDJEDIa0mTF6LnCYErk9OgKhZsuXOXRwizSmZ3WhWrCB9TQQWmjOxPIe BdFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:user-agent:mime-version; bh=IxM5UgeJGpQnUDmMsd6rP22VIUDbJ4knH5+UMAdA/p0=; b=NuX1b9OF1PUWrOfeDUZSn1iTaZ5YghbAb9l53sw1wSyu1DX3swtGnwiMosO6J79mhy Wy88XDf0Vc1yimahu7uxj4jmd8hcI0o+LbPYsj6AfYvbrewtUZqLNSLMpIIQwVl0T2zZ CXVpsDLQadgR96xWSVFTxPOnQcL1Opw+KGZXVWrcw6YNPFhKjUzyk0ljkHdFXHI1vDQC EYR1vi5owpVECjiVTbQWog1Zv79CTniVQ1Uk+3BEvJY42bTBvRWnZNqUjSTXCY4jd72u C4d4LBjDyC2wfxTeVUH5jamGJl6w20tS2wfs1sj+mNdY7VO0L3wdB3IzqcICW350W+3h NTIw== X-Gm-Message-State: AOAM5317GxkF/0f/D66TJAW5cBxaXQvDijd9kHMdguoZfGIn7nDqYx3l cbee1ZiYMmUodANIUYriw7I= X-Google-Smtp-Source: ABdhPJzSFDhvGUrTiIHCrfn5E9XFc4k2ksFLOyZ5s76NgnLYOHgjYecj0riOPd64AX3NlYsiVwn8Kg== X-Received: by 2002:a5d:4608:: with SMTP id t8mr1056448wrq.136.1632844912795; Tue, 28 Sep 2021 09:01:52 -0700 (PDT) Received: from nijino.fritz.box (85-127-52-93.dsl.dynamic.surfer.at. [85.127.52.93]) by smtp.gmail.com with ESMTPSA id e21sm3130424wme.42.2021.09.28.09.01.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Sep 2021 09:01:52 -0700 (PDT) Message-ID: Subject: Re: [PATCH 1/2] guix: packages: Document 'computed-origin-method'. From: Liliana Marie Prikler To: Mark H Weaver , zimoun Date: Tue, 28 Sep 2021 18:01:51 +0200 In-Reply-To: <87pmstghx0.fsf@netris.org> References: <20210916114734.2686426-1-zimon.toutoune@gmail.com> <9b6ee27ff10e1042a5d61d0f93d957cf760e9ecb.camel@gmail.com> <87v930ay5y.fsf@netris.org> <87pmstghx0.fsf@netris.org> Content-Type: multipart/mixed; boundary="=-qrcXMPYMoD8D+wjRq+BR" User-Agent: Evolution 3.34.2 MIME-Version: 1.0 X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 50620 Cc: 50620@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-qrcXMPYMoD8D+wjRq+BR Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Hi everyone, Am Dienstag, den 28.09.2021, 05:36 -0400 schrieb Mark H Weaver: > Hi Simon, > > zimoun writes: > > On Fri, 17 Sept 2021 at 01:40, Mark H Weaver > > wrote: > > > Liliana Marie Prikler wrote: > [...] > > > > If done this way, there'd be the benefit that modules with > > > > packages > > > > using this thing would have to explicitly request the presence > > > > of the > > > > symbol through their use-modules clauses. > > > > > > Actually, for better or worse, Guile's '@@' form does not require > > > the named module to be imported using 'use-modules', so I don't > > > think this benefit strictly exists as stated above. However, I > > > agree that it's good practice to list all imported modules in > > > the '#:use-module' clauses at the top of the file wherever > > > possible [*], and that there may be somebenefit in declaring the > > > use of 'computed-origins' at the top of each file. > > > > I am not deeply familiar with Guile module. > > > > I chose to put this in (guix packages) instead of its own module > > because the module would contain only one function and nothing > > exported. The aim for now, as discussed, is to not make this > > 'method' part of the public API. If so, one could argue that (gnu packages) is a better location to hide it, but my main issue is that we still need to hide it! This will cause other channels to refer to it using @@ or roll their own implementations. > > Then if the function is not exported by the module, the '#:use- > > module' does not have an effect, right? > > It's true that it would have no effect on the set of available > bindings, and that's an excellent point. Perhaps Liliana could > clarify what she had in mind, or better yet, propose a patch. I would argue that something like computed-origin-method *does* deserve to be an exported binding, but ought not to be grouped together into (guix packages). The latter only provides record types, not methods (which are typically implemented elsewhere), and I'd like to keep it that way. I've attached a patch to illustrate my point, but please don't apply it as is. I have not put in the necessary git blame research to find out who would need to be copyrighted here. Regards, Liliana --=-qrcXMPYMoD8D+wjRq+BR Content-Disposition: attachment; filename="0001-guix-Add-computed-origins.patch" Content-Type: text/x-patch; name="0001-guix-Add-computed-origins.patch"; charset="UTF-8" Content-Transfer-Encoding: base64 RnJvbSBlYTEzOGZkYjE0NTIyNGEwNGEyYmFkMjdlMjE0ZGY3ZTI4M2NjZWU3IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBMaWxpYW5hIE1hcmllIFByaWtsZXIgPGxpbGlhbmEucHJpa2xl ckBnbWFpbC5jb20+CkRhdGU6IFR1ZSwgMjggU2VwIDIwMjEgMTc6NTQ6MjMgKzAyMDAKU3ViamVj dDogW1BBVENIXSBndWl4OiBBZGQgY29tcHV0ZWQtb3JpZ2lucy4KTUlNRS1WZXJzaW9uOiAxLjAK Q29udGVudC1UeXBlOiB0ZXh0L3BsYWluOyBjaGFyc2V0PVVURi04CkNvbnRlbnQtVHJhbnNmZXIt RW5jb2Rpbmc6IDhiaXQKClRoaXMgYWRkcyB0aGUg4oCYY29tcHV0ZWQtb3JpZ2luLW1ldGhvZOKA mSB1c2VkIGJ5IGxpbnV4LWxpYnJlIG9yIGljZWNhdCB1bmRlcgp0aGUgbmV3IG5hbWUg4oCYY29t cHV0ZS1vcmlnaW7igJkgYXMgcHVibGljIEd1aXggQVBJLgoKKiBndWl4L2NvbXB1dGVkLW9yaWdp bnM6IE5ldyBmaWxlLgotLS0KIE1ha2VmaWxlLmFtICAgICAgICAgICAgICAgfCAgMSArCiBndWl4 L2NvbXB1dGVkLW9yaWdpbnMuc2NtIHwgMzcgKysrKysrKysrKysrKysrKysrKysrKysrKysrKysr KysrKysrKwogMiBmaWxlcyBjaGFuZ2VkLCAzOCBpbnNlcnRpb25zKCspCiBjcmVhdGUgbW9kZSAx MDA2NDQgZ3VpeC9jb21wdXRlZC1vcmlnaW5zLnNjbQoKZGlmZiAtLWdpdCBhL01ha2VmaWxlLmFt IGIvTWFrZWZpbGUuYW0KaW5kZXggYjY2Nzg5ZmEwYi4uZThmMGM2M2UyYiAxMDA2NDQKLS0tIGEv TWFrZWZpbGUuYW0KKysrIGIvTWFrZWZpbGUuYW0KQEAgLTk4LDYgKzk4LDcgQEAgTU9EVUxFUyA9 CQkJCQlcCiAgIGd1aXgvYnpyLWRvd25sb2FkLnNjbSAgICAgICAgICAgIAkJXAogICBndWl4L2dp dC1kb3dubG9hZC5zY20JCQkJXAogICBndWl4L2hnLWRvd25sb2FkLnNjbQkJCQlcCisgIGd1aXgv Y29tcHV0ZWQtb3JpZ2lucy5zY20JCQkJXAogICBndWl4L3N3aC5zY20JCQkJCVwKICAgZ3VpeC9t b25hZHMuc2NtCQkJCVwKICAgZ3VpeC9tb25hZC1yZXBsLnNjbQkJCQlcCmRpZmYgLS1naXQgYS9n dWl4L2NvbXB1dGVkLW9yaWdpbnMuc2NtIGIvZ3VpeC9jb21wdXRlZC1vcmlnaW5zLnNjbQpuZXcg ZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwLi5mN2M4M2RmMGJmCi0tLSAvZGV2L251 bGwKKysrIGIvZ3VpeC9jb21wdXRlZC1vcmlnaW5zLnNjbQpAQCAtMCwwICsxLDM3IEBACis7Ozsg R05VIEd1aXggLS0tIEZ1bmN0aW9uYWwgcGFja2FnZSBtYW5hZ2VtZW50IGZvciBHTlUKKzs7OyBD b3B5cmlnaHQgwqkgMTMxMiBNYXggTcO8bGxlciA8bWF4QG3DvGxsZXIuZ21iaD4KKzs7OworOzs7 IFRoaXMgZmlsZSBpcyBwYXJ0IG9mIEdOVSBHdWl4LgorOzs7Cis7OzsgR05VIEd1aXggaXMgZnJl ZSBzb2Z0d2FyZTsgeW91IGNhbiByZWRpc3RyaWJ1dGUgaXQgYW5kL29yIG1vZGlmeSBpdAorOzs7 IHVuZGVyIHRoZSB0ZXJtcyBvZiB0aGUgR05VIEdlbmVyYWwgUHVibGljIExpY2Vuc2UgYXMgcHVi bGlzaGVkIGJ5Cis7OzsgdGhlIEZyZWUgU29mdHdhcmUgRm91bmRhdGlvbjsgZWl0aGVyIHZlcnNp b24gMyBvZiB0aGUgTGljZW5zZSwgb3IgKGF0Cis7OzsgeW91ciBvcHRpb24pIGFueSBsYXRlciB2 ZXJzaW9uLgorOzs7Cis7OzsgR05VIEd1aXggaXMgZGlzdHJpYnV0ZWQgaW4gdGhlIGhvcGUgdGhh dCBpdCB3aWxsIGJlIHVzZWZ1bCwgYnV0Cis7OzsgV0lUSE9VVCBBTlkgV0FSUkFOVFk7IHdpdGhv dXQgZXZlbiB0aGUgaW1wbGllZCB3YXJyYW50eSBvZgorOzs7IE1FUkNIQU5UQUJJTElUWSBvciBG SVRORVNTIEZPUiBBIFBBUlRJQ1VMQVIgUFVSUE9TRS4gIFNlZSB0aGUKKzs7OyBHTlUgR2VuZXJh bCBQdWJsaWMgTGljZW5zZSBmb3IgbW9yZSBkZXRhaWxzLgorOzs7Cis7OzsgWW91IHNob3VsZCBo YXZlIHJlY2VpdmVkIGEgY29weSBvZiB0aGUgR05VIEdlbmVyYWwgUHVibGljIExpY2Vuc2UKKzs7 OyBhbG9uZyB3aXRoIEdOVSBHdWl4LiAgSWYgbm90LCBzZWUgPGh0dHA6Ly93d3cuZ251Lm9yZy9s aWNlbnNlcy8+LgorCisoZGVmaW5lLW1vZHVsZSAoZ3VpeCBjb21wdXRlZC1vcmlnaW5zKQorICAj OnVzZS1tb2R1bGUgKGd1aXggbW9uYWRzKQorICAjOnVzZS1tb2R1bGUgKGd1aXggc3RvcmUpCisg ICM6dXNlLW1vZHVsZSAoZ3VpeCBwYWNrYWdlcykKKyAgIzp1c2UtbW9kdWxlIChndWl4IGdleHAp CisgICM6ZXhwb3J0IChjb21wdXRlLW9yaWdpbikpCisKKyhkZWZpbmUqIChjb21wdXRlLW9yaWdp biBnZXhwLXByb21pc2UgaGFzaC1hbGdvIGhhc2gKKyAgICAgICAgICAgICAgICAgICAgICAgICAj Om9wdGlvbmFsIChuYW1lICJzb3VyY2UiKQorICAgICAgICAgICAgICAgICAgICAgICAgICM6a2V5 IChzeXN0ZW0gKCVjdXJyZW50LXN5c3RlbSkpCisgICAgICAgICAgICAgICAgICAgICAgICAgKGd1 aWxlIChkZWZhdWx0LWd1aWxlKSkpCisgICJSZXR1cm4gYSBkZXJpdmF0aW9uIHRoYXQgZXhlY3V0 ZXMgdGhlIEctZXhwcmVzc2lvbiB0aGF0IHJlc3VsdHMKK2Zyb20gZm9yY2luZyBHRVhQLVBST01J U0UuIgorICAobWxldCAlc3RvcmUtbW9uYWQgKChndWlsZSAocGFja2FnZS0+ZGVyaXZhdGlvbiBn dWlsZSBzeXN0ZW0pKSkKKyAgICAoZ2V4cC0+ZGVyaXZhdGlvbiAob3IgbmFtZSAiY29tcHV0ZWQt b3JpZ2luIikKKyAgICAgICAgICAgICAgICAgICAgICAoZm9yY2UgZ2V4cC1wcm9taXNlKQorICAg ICAgICAgICAgICAgICAgICAgICM6Z3JhZnQ/ICNmICAgICAgIDtub3RoaW5nIHRvIGdyYWZ0Cisg ICAgICAgICAgICAgICAgICAgICAgIzpzeXN0ZW0gc3lzdGVtCisgICAgICAgICAgICAgICAgICAg ICAgIzpndWlsZS1mb3ItYnVpbGQgZ3VpbGUpKSkKLS0gCjIuMzMuMAoK --=-qrcXMPYMoD8D+wjRq+BR--