From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 17 15:15:11 2021 Received: (at 50614) by debbugs.gnu.org; 17 Sep 2021 19:15:11 +0000 Received: from localhost ([127.0.0.1]:33032 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mRJKJ-0002LV-HL for submit@debbugs.gnu.org; Fri, 17 Sep 2021 15:15:11 -0400 Received: from out0.migadu.com ([94.23.1.103]:59209) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mRJKH-0002LI-17 for 50614@debbugs.gnu.org; Fri, 17 Sep 2021 15:15:10 -0400 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mgsn.dev; s=key1; t=1631906107; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hZQu4pcLw4VdLE+L45LAh9Z6tqshfkFGjyjfLPDlhvU=; b=d9PKEZjzPAjHKxCzCwvrP1HQMbtMBGdmk7BDOgee76LzK+btV2b3T4t6ChUjzxwv3322pg aza61QToGE8jyH123mz2Ah5yEvvno3+jpVS5TE2iCFNMn3euK1SOChRca4gTioYDf8VIuI Xbw2POeacrB1XU7ykaTJ3x7Q2lpjlqE= From: Sarah Morgensen To: Liliana Marie Prikler Subject: Re: [bug#50614] [PATCH] build: utils: Add =?utf-8?B?4oCYbGlzdC13?= =?utf-8?B?aGVu4oCZ?= macro. References: <08db559a4e24a409d332b3552d6a176de6353166.1631867018.git.public@yoctocell.xyz> Date: Fri, 17 Sep 2021 12:15:03 -0700 In-Reply-To: (Liliana Marie Prikler's message of "Fri, 17 Sep 2021 19:55:52 +0200 (1 hour, 17 minutes, 50 seconds ago)") Message-ID: <86v92zggjs.fsf@mgsn.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Migadu-Flow: FLOW_OUT X-Migadu-Auth-User: iskarian@mgsn.dev X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 50614 Cc: 50614@debbugs.gnu.org, Xinglu Chen X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hi, Liliana Marie Prikler writes: > Am Freitag, den 17.09.2021, 10:26 +0200 schrieb Xinglu Chen: >> * guix/build/utils.scm (list-when): New syntax >> * tests/build-utils.scm ("list-when: expr1 is non-#f", list-when: >> expr1 is #f"): >> Test it. >> * guix.texi (Build Utilities): Document it. >> --- >> Changes since v1: >>=20 >> * Rename =E2=80=98optional=E2=80=99 to =E2=80=98list-when=E2=80=99. >>=20 >> * Make >>=20 >> (list-when test consequent ...) >>=20 >> equivalent to >>=20 >> (if tests >> (list consequent ...) >> '()) > LGTM, but let's wait on more opinions. IIRC, changing (guix build) > causes a world rebuild, no? So this patch might go to core-updates > first. Do we actually use this idiom anywhere build-side? (If not, does it belong in (guix utils)? Or should we stick it in (guix build utils) just to be safe?) -- Sarah