From debbugs-submit-bounces@debbugs.gnu.org Mon Sep 20 07:03:49 2021 Received: (at 50614) by debbugs.gnu.org; 20 Sep 2021 11:03:49 +0000 Received: from localhost ([127.0.0.1]:41080 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mSH5Q-00005Q-OU for submit@debbugs.gnu.org; Mon, 20 Sep 2021 07:03:48 -0400 Received: from mail-wr1-f53.google.com ([209.85.221.53]:35334) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mSH5O-000057-SP for 50614@debbugs.gnu.org; Mon, 20 Sep 2021 07:03:47 -0400 Received: by mail-wr1-f53.google.com with SMTP id i23so28475645wrb.2 for <50614@debbugs.gnu.org>; Mon, 20 Sep 2021 04:03:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=7uRSzjZMCKZgPt8eRhFSqPicnbu5ffuJ1b64uvH8o4A=; b=g5CM9/uspvfxJbI66RTA9RY9b8BWKL2MZts8zs+OMwmAdGpbE0mrURfexa724dYc9z IrOg+TTGDev4Xlf9DwUezCdseYnWZThVweYFO3KoLP+kZIub0rg+O11g7O2Y6dcLjt1Z Zkbumy6ZAo7PjIiI0mhAww4kh2D2kNMvcvLXEpafQP2qGcSuVPawRmrUIr1g/ZyLHQwK qn+UZqxB0rvfI7gYiqXkvPTUdAMr8XRDO3nX6TRQR9l6ieHoZzG208iffN9MuU43eljA co1BACys1iiSRlP09lRMlOg5dYhQtc5IpJ+kYecRxCGWcNhSKS+ocmRXtkzds2KFYO51 adoQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=7uRSzjZMCKZgPt8eRhFSqPicnbu5ffuJ1b64uvH8o4A=; b=Z4EfWrCUlPHeMvzpxMe6RtlSt+cfrcTmdY0tulqbzjjEqaRqBevHYLHEHzyomuE6NF hQvYAveoNHBkXhxqfqn9sS8R3mAeaNA91fVciTZCBf9R5XW418ZgM2dqXAdw1cqSJznW HdLN3Ddi1LqEPngfxPeVR7IZklkA9jwU3WNeXEZ+FmMXH3PzDiPr7VS4SRXMVSTFmX1D v0Aa1ojmu0kbshaonByIv5pvyGLcJF5L5WrU8AyJPVCNni/IaToHsttViT03o+fw194x 8/EdLDyS65mwweiGYZb6BI5Zyt4Kh1c2dbehjZT7LyoTtkhd5bAYJDCdZkXgbzPnKeh6 +aog== X-Gm-Message-State: AOAM530EMLKygHoMkE4yer7qEVgtUDaIZNKP8x7VjiTeDmKToE6IyJXc riStbnWN84DH5EuyF4N2sYM= X-Google-Smtp-Source: ABdhPJwx/XdktauQujuJd6HTl7EZf0GQk1ThRcOCc+gVmfeA+guY8/EYu7k9h4pgY/20HFaMhfV6bg== X-Received: by 2002:a05:6000:c7:: with SMTP id q7mr16139324wrx.257.1632135820801; Mon, 20 Sep 2021 04:03:40 -0700 (PDT) Received: from pfiuh02 ([193.48.40.241]) by smtp.gmail.com with ESMTPSA id p6sm15084470wrq.47.2021.09.20.04.03.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Sep 2021 04:03:40 -0700 (PDT) From: zimoun To: Xinglu Chen Subject: Re: bug#50614: [PATCH core-updates] build: utils: Add =?utf-8?B?4oCYb3B0aW9uYWzigJk=?= macro. References: <08db559a4e24a409d332b3552d6a176de6353166.1631867018.git.public@yoctocell.xyz> Date: Mon, 20 Sep 2021 13:03:34 +0200 In-Reply-To: (Xinglu Chen's message of "Sun, 19 Sep 2021 15:50:41 +0200") Message-ID: <871r5jh5kp.fsf_-_@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 2.0 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Hi, On Sun, 19 Sep 2021 at 15:50, Xinglu Chen wrote: > +@lisp > +(if @var{test} > + (list @var{consequent} @dots{}) > + '()) > +@end lisp Content analysis details: (2.0 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_PASS SPF: sender matches SPF record -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.221.53 listed in list.dnswl.org] 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (zimon.toutoune[at]gmail.com) 2.0 PDS_OTHER_BAD_TLD Untrustworthy TLDs [URI: yoctocell.xyz (xyz)] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.85.221.53 listed in wl.mailspike.net] X-Debbugs-Envelope-To: 50614 Cc: 50614@debbugs.gnu.org, Liliana Marie Prikler , Sarah Morgensen X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) Hi, On Sun, 19 Sep 2021 at 15:50, Xinglu Chen wrote: > +@lisp > +(if @var{test} > + (list @var{consequent} @dots{}) > + '()) > +@end lisp [...] > +@lisp > +(arguments > + `(#:configure-flags (list "--localstatedir=3D/var" > + "--sysconfdir=3D/etc" > + ,@@(list-when (hurd-target?) "--with-courage"= )))) > +@end lisp Personally, I am not convinced it helps the readibility. But that=E2=80=99= s a matter of taste. :-) My concern is about the coherence. First, =E2=80=99list-unless=E2=80=99 is= also required by a similar pattern, see for instance: --8<---------------cut here---------------start------------->8--- gnu/packages/guile.scm:162: ,@(if (target-mingw?) '() `(("bash"= ,bash-minimal))))) --8<---------------cut here---------------end--------------->8--- And second, these 2 patterns =E2=80=99list-when=E2=80=99 and =E2=80=99list-= unless=E2=80=99 are used in by many files, see guix/build-system, guix/import, guix/describe, gnu/packages, gnu/system, gnu/services files. For the oneline pattern: =E2=80=9Cag --scheme '@\(if' | grep '()'=E2=80=9D. All should be replaced;= which implies a world-rebuild I guess. Well, all in all, I am not convinced that all this work is worth for a small debatable readibility improvement. :-) All the best, simon