From debbugs-submit-bounces@debbugs.gnu.org Mon Sep 13 14:15:31 2021 Received: (at 50563) by debbugs.gnu.org; 13 Sep 2021 18:15:31 +0000 Received: from localhost ([127.0.0.1]:46785 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mPqUM-0005q7-NA for submit@debbugs.gnu.org; Mon, 13 Sep 2021 14:15:30 -0400 Received: from andre.telenet-ops.be ([195.130.132.53]:32966) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mPqUJ-0005px-Ht for 50563@debbugs.gnu.org; Mon, 13 Sep 2021 14:15:29 -0400 Received: from butterfly.local ([213.119.220.40]) by andre.telenet-ops.be with bizsmtp id tWFN2500T0stn0d01WFRHQ; Mon, 13 Sep 2021 20:15:25 +0200 Message-ID: Subject: Re: [bug#50563] [PATCH 2/2] gnu: gdm: Add Wayland session wrapper script. From: Maxime Devos To: Josselin Poiret , "50563@debbugs.gnu.org" <50563@debbugs.gnu.org> Date: Mon, 13 Sep 2021 20:14:45 +0200 In-Reply-To: <_O63PhtCI8ZiwBgDZppLf6SqqIgEm3Y0iFYKUIsuLOeAM4yMfbqumjltWSuHKl8tfgUdL0yAC2TVR4nqKvLNJ18Rgs7iImwzPAztAEvIcmM=@jpoiret.xyz> References: <_O63PhtCI8ZiwBgDZppLf6SqqIgEm3Y0iFYKUIsuLOeAM4yMfbqumjltWSuHKl8tfgUdL0yAC2TVR4nqKvLNJ18Rgs7iImwzPAztAEvIcmM=@jpoiret.xyz> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-3zOric5hMf+o8isJ31sC" User-Agent: Evolution 3.34.2 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r21; t=1631556926; bh=IqeXCvWHv3TLOo2Ohfk3B18b/7laH8SYmSZV/ryxAA4=; h=Subject:From:To:Date:In-Reply-To:References; b=NWF9VbLmDNevt3UsyeEwlD/PBmPUPukFeH7nOhxGg0ZmjF/O9I3XFuGVZork2nkxe eko5UoDUIKH3auFFhCJxroq/7hSt4u1mvSR5v7dN5/AmA0d85fFaWKqp4zqtJbe894 yNMqJ5uIs/up7QCbPrQXd1STyWg5p+o+lVP/YHWZ52jzpjd1jY49Ggb3RGwAWQuJ3Z g68xEbsgLj+4Z2ThcHMje5pwjtXURl+sxIBCnDcfNx4hSp+8TlXuDRBe/C6r6tfBn9 BFeKIRtqZe7yZGe054F0TdzYAzsoJCAQjqwcMEBNT+2kxFcZnZovaPExBQ+u81GK/T kSCSz/lJnwHng== X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 50563 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-3zOric5hMf+o8isJ31sC Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Josselin Poiret schreef op ma 13-09-2021 om 08:15 [+0000]: > * Patch GDM to support launching a wrapper script for Wayland sessions. > * Add `wayland-session` in `gdm-configuration` to specify the wrapper to = use. > * Add default wrapper that runs non-GDM sessions through a login shell (b= ased > on the `xinitrc`). > * Update the documentation with those changes. > --- > doc/guix.texi | 4 +++ > gnu/packages/gnome.scm | 3 +- > ...gdm-wayland-session-wrapper-from-env.patch | 35 +++++++++++++++++++ > gnu/services/xorg.scm | 21 +++++++++-- > 4 files changed, 60 insertions(+), 3 deletions(-) > create mode 100644 gnu/packages/patches/gdm-wayland-session-wrapper-from= -env.patch >=20 > diff --git a/doc/guix.texi b/doc/guix.texi > index 93ea4a321f..3e6157c8ab 100644 > --- a/doc/guix.texi > +++ b/doc/guix.texi > @@ -18098,6 +18098,10 @@ The GDM package to use. >=20 > @item @code{wayland?} (default: @code{#f}) > When true, enables Wayland in GDM, necessary to use Wayland sessions. > + > +@item @code{wayland-session} (default: @code{gdm-wayland-session-wrapper= }) > +The Wayland session wrapper to use, needed to setup the > +environment. =E2=80=98needed to setup the environment=E2=80=99 --> this sounds like some= times, the session wrapper needs to be changed such that the environment variables are correct= . However, gdm-wayland-session-wrapper doesn't actually set any environment v= ariables, and the X equivalent 'xsession' doesn't need to be modified (at least on my= system, when I last used gdm), so I presume the default is quite reasonable for mos= t users. So to reduce confusion, I would drop the =E2=80=98needed to set up the envi= ronment=E2=80=99. A =E2=80=98real-world=E2=80=99 example of a custom 'wayland-session' would = be helpful to illustrate matters. Greetings, Maxime --=-3zOric5hMf+o8isJ31sC Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYT+VGxccbWF4aW1lZGV2 b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7vUrAP41wO5adtiLf9BExaViGMzViFVQ faROde9MmScFYevGBwD/QCNNAqKkLA8PHvmJXmWkNP4xnLKVvpwZNDDza16D9Ao= =+4qJ -----END PGP SIGNATURE----- --=-3zOric5hMf+o8isJ31sC--