From debbugs-submit-bounces@debbugs.gnu.org Wed Sep 22 08:55:38 2021 Received: (at 50363) by debbugs.gnu.org; 22 Sep 2021 12:55:38 +0000 Received: from localhost ([127.0.0.1]:49040 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mT1mk-0006AE-Br for submit@debbugs.gnu.org; Wed, 22 Sep 2021 08:55:38 -0400 Received: from eggs.gnu.org ([209.51.188.92]:56834) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mT1mh-00069q-8s for 50363@debbugs.gnu.org; Wed, 22 Sep 2021 08:55:37 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:33630) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mT1ma-0000el-UI; Wed, 22 Sep 2021 08:55:28 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=35978 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mT1ma-0001Bz-BK; Wed, 22 Sep 2021 08:55:28 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Sarah Morgensen Subject: Re: [PATCH v4] Improve default diff hunk header detection. References: X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 1 =?utf-8?Q?Vend=C3=A9miaire?= an 230 de la =?utf-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Wed, 22 Sep 2021 14:55:26 +0200 In-Reply-To: (Sarah Morgensen's message of "Mon, 20 Sep 2021 16:37:44 -0700") Message-ID: <87o88khirl.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 50363 Cc: 50363@debbugs.gnu.org, kyle@kyleam.com, maximedevos@telenet.be X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi, Sarah Morgensen skribis: > Tell git where to look for diff hunk headers: top-level definitions for > Scheme files, and (sub)section headers for texi files. > > * .gitattributes, etc/git/gitconfig: New files. > * doc/contributing.texi ("Submitting Patches"): Add subsection > "Configuring Git". Document etc/git/gitconfig. I have one last question: > +format-patch} sent to the @email{guix-patches@@gnu.org} mailing list > +(@pxref{submitting patches,, Submitting patches to a project, git, Git > +User Manual}). Contributors are encouraged to take a moment to set some AFAICS, there=E2=80=99s no Info-format Git manual, is there? In that case,= the pxref above is incorrect, but we can use @uref instead and/or suggest =E2=80=98man git=E2=80=99 or similar. The rest LGTM, thank you, and thanks Kyle! Ludo=E2=80=99.