From debbugs-submit-bounces@debbugs.gnu.org Mon Sep 13 04:03:31 2021 Received: (at 50359) by debbugs.gnu.org; 13 Sep 2021 08:03:32 +0000 Received: from localhost ([127.0.0.1]:44163 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mPgw7-00036e-MO for submit@debbugs.gnu.org; Mon, 13 Sep 2021 04:03:31 -0400 Received: from eggs.gnu.org ([209.51.188.92]:60514) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mPgw5-00036L-NA for 50359@debbugs.gnu.org; Mon, 13 Sep 2021 04:03:30 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:57106) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mPgvy-0008Dp-SV; Mon, 13 Sep 2021 04:03:22 -0400 Received: from [2001:660:6102:320:e120:2c8f:8909:cdfe] (port=47238 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mPgvy-00017K-Gc; Mon, 13 Sep 2021 04:03:22 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Xinglu Chen Subject: Re: [PATCH 2/3] tests: git: Make 'tag' directive non-interactive. References: <29b4b579f8fe8fc3406a48224c5af28d9e70b865.1631290349.git.public@yoctocell.xyz> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 27 Fructidor an 229 de la =?utf-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Mon, 13 Sep 2021 10:03:20 +0200 In-Reply-To: <29b4b579f8fe8fc3406a48224c5af28d9e70b865.1631290349.git.public@yoctocell.xyz> (Xinglu Chen's message of "Fri, 10 Sep 2021 18:21:25 +0200") Message-ID: <87bl4wc37b.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.3 (/) X-Debbugs-Envelope-To: 50359 Cc: 50359@debbugs.gnu.org, Sarah Morgensen X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.3 (-) Hello, Xinglu Chen skribis: > When running 'git tag TAGNAME', Git will open up the user's default text > editor to make them write a message. This is not desirable when running > tests. > > * guix/tests/git.scm (populate-git-repository): Make the 'tag' directive = take > an additional argument, and pass it to the '-m' flag. [...] > - ((('tag name) rest ...) > - (git "tag" name) > + ((('tag name text) rest ...) > + (git "tag" "-m" text name) LGTM, but you need to update at least tests/channels.scm accordingly. Thanks, Ludo=E2=80=99.