Thank you for your comments and advices. zimoun writes: > Hi, > > You are asking in about > this > one. Well, I am not an expert and I am not an Emacs Roam user. > > On Thu, 02 Sep 2021 at 22:57, Adolfo De Unánue > wrote: > >>>From a99fa75c0f5d3025827d99c3ef6a2c71c85e0be5 Mon Sep 17 >>>00:00:00 2001 >> From: =?UTF-8?q?Adolfo=20De=20Un=C3=A1nue?= >> >> Date: Thu, 2 Sep 2021 22:23:58 -0500 >> Subject: [PATCH] Fixed missing files in org-roam v2.1.0 > > The commit message should be: > > --8<---------------cut > here---------------start------------->8--- > gnu: emacs-org-roam: Adding extensions. > > * guix/emacs-xyz.scm (emacs-org-roam)[arguments]: Add phases to > install > extensions. > --8<---------------cut > here---------------end--------------->8--- > > Or something along these lines. > Should I apply your suggested changes, commit them, use this commit message, create the patch and send them again? >> --- >> gnu/packages/emacs-xyz.scm | 94 >> +++++++++++++++++++++----------------- >> 1 file changed, 53 insertions(+), 41 deletions(-) >> >> diff --git a/gnu/packages/emacs-xyz.scm >> b/gnu/packages/emacs-xyz.scm >> index 030809f5ac..431444c255 100644 >> --- a/gnu/packages/emacs-xyz.scm >> +++ b/gnu/packages/emacs-xyz.scm >> @@ -103,6 +103,7 @@ >> ;;; Copyright © 2021 Matthew James Kraai >> ;;; Copyright © 2021 Noisytoot >> ;;; Copyright © 2021 Simon South >> +;;; Copyright © 2021 Nanounanue > > Since you submit with this name “Adolfo De Unánue“, the > Copyright should > be the same instead of a nick name. From my point of view, > nickname as > copyright holder should be avoided; if possible, obviously. :-) I will do, makes complete sense > >> + (let ((commit "f819720c510185af713522c592833ec9f2934251") > > Usually, the package uses tagged version instead of random > commit. When > it is not possible because upstream do not tag, it seems good to > provide > an explanation why the lasted tagged version cannot be used; > explanations as a comment or in the cover letter. > As you guessed, org-roam has not tagged this new (breaking) change, that's why I am using the commit > Another reason is because for instance it changes all the > indentation > and makes ‘git log/blame’ harder to investigate. > >> + (add-after 'install 'install-extensions >> + (lambda* (#:key outputs #:allow-other-keys) >> + (copy-recursively >> + "extensions" >> + (string-append (assoc-ref outputs "out") >> + (string-append >> + "/share/emacs/site-lisp/org-roam-" >> + ,version))) >> + #t)) > > Patch#50333 will install the extensions with “guix install > emacs-org-roam”. Instead the attempt of patch#50374 is to > install with > “guix install emacs-org-roam-extensions”. Well, I do not know > if > patch#50374 is correct, though. > > Because I am not an Org-Roam user, I do not have an opinion > about this > extensions. Maybe it is better to distribute them along the > package > emacs-org-roam or in a separate package, I do not know. WDYT? > I mean, structurally the upstream owner just moved some files to a new folder, my guess is that it shouldn't be a different packages since it is still part of org-roam. > All the best, > simon Again thank you, it was super helpful! -- - A