From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 07 10:06:40 2021 Received: (at 50217) by debbugs.gnu.org; 7 Sep 2021 14:06:40 +0000 Received: from localhost ([127.0.0.1]:57238 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mNbkF-0004gB-Gg for submit@debbugs.gnu.org; Tue, 07 Sep 2021 10:06:40 -0400 Received: from eggs.gnu.org ([209.51.188.92]:39708) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mNbk2-0004ff-DI for 50217@debbugs.gnu.org; Tue, 07 Sep 2021 10:06:38 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:50494) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mNbjx-0002BA-7Q; Tue, 07 Sep 2021 10:06:21 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=35366 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mNbjw-0004gG-Uz; Tue, 07 Sep 2021 10:06:21 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: muradm Subject: Re: bug#50217: [PATCH] gnu: Add c2ffi-11.0.0. References: <20210826210712.31273-1-mail@muradm.net> <20210827001207.4105-1-mail@muradm.net> Date: Tue, 07 Sep 2021 16:06:18 +0200 In-Reply-To: <20210827001207.4105-1-mail@muradm.net> (muradm's message of "Fri, 27 Aug 2021 03:12:07 +0300") Message-ID: <87r1e04h0l.fsf_-_@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 50217 Cc: 50217@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hello, muradm skribis: > * gnu/packages/cpp.scm (c2ffi): New variable. Overall LGTM, modulo the following minor issues: [...] > +(define-public c2ffi > + (let ((commit "f50243926a0afb589de1078a073ac08910599582") > + (revision "1") > + (c2ffi-sha256 "17j73yb6v3lfvwwicl2f3yg141iz2dk1rf874qzqs5bkq64ld= jsj")) Normally, we only provide upstream releases. If you think we need this specific commit, could you add a comment explaining why? Please leave the base32 sha256 string where it=E2=80=99s used, within the (base32 =E2=80=A6) expression (it=E2=80=99s a macro that decodes base32 at compile-time.) > + #:tests? #f)) It would be best to run tests. Alternatively, if this is not feasible, please add a comment explaining why we=E2=80=99re skipping them. > + (synopsis "Clang-based FFI wrapper generator") > + (description "tool for extracting definitions from C, C++, and > +Objective C headers for use with foreign function call interfaces.") Please write full sentences, as per . > + (license license:gpl2)))) Is it GPLv2-only? Unless it=E2=80=99s explicitly stated, it=E2=80=99s prob= ably GPLv2-or-later (=E2=80=98license:gpl2+=E2=80=99). Could you send an updated patch? Thanks! Ludo=E2=80=99.