From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 07 13:51:14 2021 Received: (at 50072) by debbugs.gnu.org; 7 Sep 2021 17:51:14 +0000 Received: from localhost ([127.0.0.1]:57619 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mNfFa-00052F-4g for submit@debbugs.gnu.org; Tue, 07 Sep 2021 13:51:14 -0400 Received: from out2.migadu.com ([188.165.223.204]:49079) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mNfFX-000523-HF for 50072@debbugs.gnu.org; Tue, 07 Sep 2021 13:51:13 -0400 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mgsn.dev; s=key1; t=1631037069; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=QIdr60V2P+5C2KDeHFspc05pxRDAl/xo9dSTP4pIkJA=; b=Dk0ztGNlblTrUvutaRpoZazPQI9Zb2tT31YpPSuinuX/A63PpaDHfnHdQnMUJWlUxm3/KE 3+69/4TS2DUCRVj3d5GgtWagUO3sHYTNGiMm4/MCJjulRFGCsZ1d3CQiTmbOnuxD+zRtRg s1kiqVBjuK/dkypJ1W6lI7EA882jt/g= From: Sarah Morgensen To: Maxime Devos Subject: Re: [bug#50072] [PATCH WIP 4/4] upstream: Support updating git-fetch origins. References: <8d1ae518b23fac5b15812a30b11df1c360ab3fbf.1629068119.git.iskarian@mgsn.dev> <86mtopi3s7.fsf@mgsn.dev> <470a95f159120d14384c3096cff91e3ce8d3c6c8.camel@telenet.be> Date: Tue, 07 Sep 2021 10:51:07 -0700 In-Reply-To: <470a95f159120d14384c3096cff91e3ce8d3c6c8.camel@telenet.be> (Maxime Devos's message of "Tue, 07 Sep 2021 12:00:42 +0200 (7 hours, 45 minutes, 41 seconds ago)") Message-ID: <86a6koi8ac.fsf@mgsn.dev> MIME-Version: 1.0 Content-Type: text/plain X-Migadu-Flow: FLOW_OUT X-Migadu-Auth-User: iskarian@mgsn.dev X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 50072 Cc: 50072@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi, Maxime Devos writes: > Sarah Morgensen schreef op ma 06-09-2021 om 18:16 [-0700]: >> Hi Maxime, >> >> Maxime Devos writes: >> >> > Sarah Morgensen schreef op zo 15-08-2021 om 16:25 [-0700]: >> > > * guix/git-download.scm (checkout-to-store): New procedure. >> > > * guix/upstream.scm (guess-version-transform) >> > > (package-update/git-fetch): New procedures. >> > > (%method-updates): Add GIT-FETCH mapping. >> > >> > Does it support packages defined like (a) >> > >> > (define-public gnash >> > (let ((commit "583ccbc1275c7701dc4843ec12142ff86bb305b4") >> > (revision "0")) >> > (package >> > (name "gnash") >> > (version (git-version "0.8.11" revision commit)) >> > (source (git-reference >> > (url "https://example.org") >> > (commit commit))) >> > [...]))) >> >> Thinking about this again, since updaters typically returns actual >> versions (tags) instead of commits, how much would such a >> feature be used? > > The minetest updater returns version numbers. > It also returns a git-reference object, which includes the commit. > Just returning a version number often isn't sufficient, > because many repositories of minetest mods do not keep version tags. Thanks for the explanation. So there is a version number indicated elsewhere than in the tags for some minetest packages? (Is this data in the package's git repo or in e.g. minetest repo metadata?) That is, the minetest updater always uses "blessed versions" (not just random commits), such that "revision" will always be "0"? Are current minetest packages like this formatted like 'gnash' above? > See . That's the message I quoted ;) -- Sarah