From debbugs-submit-bounces@debbugs.gnu.org Mon Sep 06 21:16:15 2021 Received: (at 50072) by debbugs.gnu.org; 7 Sep 2021 01:16:15 +0000 Received: from localhost ([127.0.0.1]:54861 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mNPih-00050t-FZ for submit@debbugs.gnu.org; Mon, 06 Sep 2021 21:16:15 -0400 Received: from out0.migadu.com ([94.23.1.103]:58996) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mNPid-00050i-SB for 50072@debbugs.gnu.org; Mon, 06 Sep 2021 21:16:13 -0400 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mgsn.dev; s=key1; t=1630977370; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=8iyvOhaY+3kNs84M8MiKXnW9p8M5JIIje9zC1QfALbc=; b=RDOlMmEUscGwwLv1AmShUgkF9OabDNc05xRhDf0FOHrSlvSQgvBOsuG8K5wt1s5IK8IXrD jOvdo7GbQaUdW0wC77xQ+Q3dgrEW8WrUOxEmr/0ssb0E1lTOdoUFOp3qUhc3ls1g243gsj JbBwAX/59hkSPRxIFiuyTsqrkrI6lSc= From: Sarah Morgensen To: Maxime Devos Subject: Re: [bug#50072] [PATCH WIP 4/4] upstream: Support updating git-fetch origins. References: <8d1ae518b23fac5b15812a30b11df1c360ab3fbf.1629068119.git.iskarian@mgsn.dev> Date: Mon, 06 Sep 2021 18:16:08 -0700 In-Reply-To: (Maxime Devos's message of "Mon, 16 Aug 2021 12:46:25 +0200 (3 weeks, 14 hours, 27 minutes ago)") Message-ID: <86mtopi3s7.fsf@mgsn.dev> MIME-Version: 1.0 Content-Type: text/plain X-Migadu-Flow: FLOW_OUT X-Migadu-Auth-User: iskarian@mgsn.dev X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 50072 Cc: 50072@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hi Maxime, Maxime Devos writes: > Sarah Morgensen schreef op zo 15-08-2021 om 16:25 [-0700]: >> * guix/git-download.scm (checkout-to-store): New procedure. >> * guix/upstream.scm (guess-version-transform) >> (package-update/git-fetch): New procedures. >> (%method-updates): Add GIT-FETCH mapping. > > Does it support packages defined like (a) > > (define-public gnash > (let ((commit "583ccbc1275c7701dc4843ec12142ff86bb305b4") > (revision "0")) > (package > (name "gnash") > (version (git-version "0.8.11" revision commit)) > (source (git-reference > (url "https://example.org") > (commit commit))) > [...]))) Thinking about this again, since updaters typically returns actual versions (tags) instead of commits, how much would such a feature be used? OTOH, I could definitely see use for an ability to update packages like these to proper versions (removing the surrounding 'let') but that's probably more rare and may not be worth the implementation effort. -- SEarah