From debbugs-submit-bounces@debbugs.gnu.org Fri Aug 27 00:19:48 2021 Received: (at submit) by debbugs.gnu.org; 27 Aug 2021 04:19:48 +0000 Received: from localhost ([127.0.0.1]:50990 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mJTLA-00070j-Ri for submit@debbugs.gnu.org; Fri, 27 Aug 2021 00:19:48 -0400 Received: from lists.gnu.org ([209.51.188.17]:37772) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mJTL9-00070b-Dw for submit@debbugs.gnu.org; Fri, 27 Aug 2021 00:19:40 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:57710) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mJTL9-000295-4Y for bug-guix@gnu.org; Fri, 27 Aug 2021 00:19:39 -0400 Received: from mail-qv1-xf2c.google.com ([2607:f8b0:4864:20::f2c]:41890) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mJTL7-0007Pf-EI; Fri, 27 Aug 2021 00:19:38 -0400 Received: by mail-qv1-xf2c.google.com with SMTP id f7so3319041qvt.8; Thu, 26 Aug 2021 21:19:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=7HXpKI4uvqDmNrivb2iDZ19xRZzWv4kF4x59jkgSKAE=; b=uC+2ukXK/UGgAgxSE9vaRrRXTtZFV8Gf0+LipnGO0YZw5enT8tU40B6K+AoU7z2j7l XYSj7y9T0DCWT8znVAx/YMBQ+r0GG7BX7zjTC5VDl08vd5pKSnThs56sfvDtChz5S80Z +bfBxcyEGTnCXqtEjm0PuhccM1DdNr2V5GaU4h757P1d++KERKK9yiMaj/2n4SC0WzRJ NdQAq86QGr8bN7G894zgH2xDQvZgzJPerB5ZPB1oI/xJa6/eMfxGmqb8ptZ4e5nCgIg0 cXFevJ5KJifLrEd46qc+RItWpZVy0ziAojM8aJ4C/dne4/cjg4LvVLoP9g+hoS7/rIA5 mU3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=7HXpKI4uvqDmNrivb2iDZ19xRZzWv4kF4x59jkgSKAE=; b=uHWNKAtG8h0VZYGl/Iz3GeJ8yDNqClQPHfzhbK5mUjISU5ZF90fOHzoXYyOU9t511b Fy1YONEiLewGjd4NF9in/XNVFwviWi0s7QPK/vNx8HP43LS1BscSrbiPrwr8NXw+k7g6 AQQV+guF4OCAQaDkSfuUrp3rkQrw4Ap2Zl9cTk+AlzNGeY67XWCk+/vadM44Y13YuCNF v5s6mcFu0G53kXTRCJ7eDi6nJlGqBKLSl2CusNwsx9LvAB6rA9eNTaQDlIIwBzsvRXGS dwoRmUsJjiWZrg/2uUWTQP4L4XYP4VmenQsB4R01Zo9BNP7DCDEP6x6m+dC4d1w7FHbw ih4w== X-Gm-Message-State: AOAM530Ym/Nfy7AaZWritbro7/X4MjrqIiSNnbdpUOtx1k/ONFfieKCd JDwFEM1bNTwFd8YtZMJXzKx638ZwJpw= X-Google-Smtp-Source: ABdhPJzaRNNH58d9VDdQ5lAceHSg93H2VgOEw5japLnl2WuwFVOw+KFdsrJCARtGzkyC4i7ANZ9Asg== X-Received: by 2002:a05:6214:250f:: with SMTP id gf15mr7926109qvb.2.1630037975135; Thu, 26 Aug 2021 21:19:35 -0700 (PDT) Received: from hurd (dsl-157-184.b2b2c.ca. [66.158.157.184]) by smtp.gmail.com with ESMTPSA id s20sm2905242qtw.14.2021.08.26.21.19.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Aug 2021 21:19:34 -0700 (PDT) From: Maxim Cournoyer To: Mathieu Othacehe Subject: Re: core-update: Raw origin tarballs are not handled correctly. References: <87bl5z85ga.fsf@gnu.org> Date: Fri, 27 Aug 2021 00:19:33 -0400 In-Reply-To: <87bl5z85ga.fsf@gnu.org> (Mathieu Othacehe's message of "Sun, 15 Aug 2021 10:42:13 +0200") Message-ID: <87lf4nsene.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2607:f8b0:4864:20::f2c; envelope-from=maxim.cournoyer@gmail.com; helo=mail-qv1-xf2c.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit Cc: bug-guix@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) Hello Mathieu, Mathieu Othacehe writes: > Hello, > > When building "emacs-org-contrib" on core-updates-frozen, the following > message is printed: > > tar: Exiting with failure status due to previous errors > error: in phase 'unpack': uncaught exception: > %exception #<&invoke-error program: "tar" arguments: ("xvf" "/gnu/store/r3v4gkqqbxp2w739a0llvk9nrda9xn89-org-plus-contrib-20210809.tar") exit-status: 2 term-signal: #f stop-signal: #f> > phase `unpack' failed after 0.0 seconds > command "tar" "xvf" "/gnu/store/r3v4gkqqbxp2w739a0llvk9nrda9xn89-org-plus-contrib-20210809.tar" failed with status 2 > note: keeping build directory `/tmp/guix-build-emacs-org-contrib-20210809.drv-6' > builder for `/gnu/store/52jcx6rwnf0wrkrpcwkyz766fzg6asjy-emacs-org-contrib-20210809.drv' failed with exit code 1 > build of /gnu/store/52jcx6rwnf0wrkrpcwkyz766fzg6asjy-emacs-org-contrib-20210809.drv failed > View build log at '/var/log/guix/drvs/52/jcx6rwnf0wrkrpcwkyz766fzg6asjy-emacs-org-contrib-20210809.drv.bz2'. > guix build: error: build of `/gnu/store/52jcx6rwnf0wrkrpcwkyz766fzg6asjy-emacs-org-contrib-20210809.drv' failed > > > That's because > "/gnu/store/r3v4gkqqbxp2w739a0llvk9nrda9xn89-org-plus-contrib-20210809.tar" > is empty. I believe this is a consequence of: > cfcead2e515c0dae02127e5a76496463898be6b6, and in particular this > section: > > ;; If SOURCE is a directory (such as a checkout), return a > ;; directory. Otherwise create a tarball. > (cond > ((file-is-directory? #+source) > (copy-recursively directory #$output > #:log (%make-void-port "w"))) > ((not #+comp) > (copy-file file #$output)) <---------- We should call repack instead here for raw tarballs? > (else > (repack directory #$output))))))) > > Maxim, could you please have a look? Thanks for the report; it looks like a bug indeed. I had probably overlooked that case (where there is no compression but we are still dealing with an archive format). The annoying thing is that touching this code will trigger a world rebuild; so unless we find other big problems and batch the fixes, it may not be worth it. The site.py problem you reported may be one, if I find a solution. Other things on my mind: 1. rustc bootstrap from 1.39 (the itch to make it faster comes back everytime I have to build it ;-)). 2. fontconfig update that should allow per-profile fonts management via XDG_DATA_DIRS (I have the commit ready, but failed to test it due to having to build rust and getting distracted by 1. :-)) Not a very useful reply in itself, but I felt that communicating what I've been busy with was better than a longer silence :-). Thank you, Maxim