From debbugs-submit-bounces@debbugs.gnu.org Sat Sep 18 13:03:27 2021 Received: (at 49898) by debbugs.gnu.org; 18 Sep 2021 17:03:27 +0000 Received: from localhost ([127.0.0.1]:36691 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mRdkM-0007sE-Rh for submit@debbugs.gnu.org; Sat, 18 Sep 2021 13:03:27 -0400 Received: from mail-wr1-f68.google.com ([209.85.221.68]:36574) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mRdkL-0007rz-JQ for 49898@debbugs.gnu.org; Sat, 18 Sep 2021 13:03:26 -0400 Received: by mail-wr1-f68.google.com with SMTP id g16so20538482wrb.3 for <49898@debbugs.gnu.org>; Sat, 18 Sep 2021 10:03:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:subject:from:to:cc:date:in-reply-to:references :user-agent:mime-version:content-transfer-encoding; bh=xJzSnhzFKZnj+u25UYCChLQ9OAIezUMpxsPJE76WcUU=; b=O+A3KO6hFQKehzipZ0dBcikYoRDtAH5cgFKSieihYyez5hr1mvmGIWLhrD5kZzK+Nh LkkWs3ojVgjh1Hoow1Wu0EFZnp/LaOPu8NVSov5Dt3SY7B2+j2N3qr7QxDR5zRxWi+Wj MgH0OlEz+Ly4O3LTMHCtBdvZb8xv0KoBh7ap8NZ0v8yQ2InAbXoBxzNAo1DytQn/Ele6 W3evF8W0HyfmS9cvN3B1zUxwyjGEPk0tw6WmsYiYt0YOS9QVOPTweCeKKEwmf9pUuus3 cVXn6YrXcptoDkgZ1ZXVPIjJBbW6jGSLa/IyTCURwoi/4VCSyTwXymNnNASDEYhfqgDY /YOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=xJzSnhzFKZnj+u25UYCChLQ9OAIezUMpxsPJE76WcUU=; b=PK5X8Ue7jK7ZR61tgBwRXkEAhjkGs8s00JGZ1/iWrXOIbMglX/AF8EXVdDtG6Phn/p bNUM9exXmmNi3oiavlJSZYaU/I5hnZpIqIQPeqkH5LoLmXeroACglRSnsn5bbKKwivJH W8XRK8ChkliwN8bVM4NQIYbAW2kYBMBFeplxy0x32wKq2YLuUV9XC5odcLbGOmzCItPB WvYaRVm5jtIrwJ+NLyEJHyMpkKhpl2641uT0ShDRen0s6O+UJ/CoQizsF2ED+4QipLij Sbrnc1Z5pRsEXq+7S3zocvWiMn/a0cz+x/InYzNGylgx1OXR6paNOdSf0/j9ThOjbXhl nw6g== X-Gm-Message-State: AOAM533pZPukaiQvDTpqWEkwLeTRWBvd0QviPwhvrBG0tUsBX0DorLFV eaeKzC5n3/NKXnYSUCh79d4= X-Google-Smtp-Source: ABdhPJxQPbZspkrvHrGS9acXeuMuAs4td5we1cKNZzRc8S8p4YhSMb15eGz+7tNmpLh5Tpte4QCQKA== X-Received: by 2002:a05:6000:1446:: with SMTP id v6mr7725979wrx.427.1631984599550; Sat, 18 Sep 2021 10:03:19 -0700 (PDT) Received: from nijino.fritz.box (85-127-52-93.dsl.dynamic.surfer.at. [85.127.52.93]) by smtp.gmail.com with ESMTPSA id 10sm13740627wmi.1.2021.09.18.10.03.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 18 Sep 2021 10:03:18 -0700 (PDT) Message-ID: <0611f164235f06ffdfaa3eb4fa5a7915210df134.camel@gmail.com> Subject: Re: [PATCH v4] gnu: Add spectre-meltdown-checker. From: Liliana Marie Prikler To: phodina Date: Sat, 18 Sep 2021 19:03:17 +0200 In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.34.2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 49898 Cc: 49898@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Petr, Am Samstag, den 18.09.2021, 15:25 +0000 schrieb phodina: > [...] > > > + (add-after 'unpack 'fix-relative-locations > + (lambda* (#:key outputs #:allow-other-keys) > + (let ((icoreutils (assoc-ref %build-inputs > "coreutils")) > + (igrep (assoc-ref %build-inputs "grep")) > + (iutil-linux (assoc-ref %build-inputs "util- > linux")) > + (iutil-linux-with-udev > + (assoc-ref %build-inputs "util-linux-with- > udev")) > + (igawk (assoc-ref %build-inputs "gawk")) > + (igzip (assoc-ref %build-inputs "gzip")) > + (iunzip (assoc-ref %build-inputs "unzip")) > + (ilzop (assoc-ref %build-inputs "lzop")) > + (iperl (assoc-ref %build-inputs "perl")) > + (iprocps (assoc-ref %build-inputs "procps")) > + (isqlite (assoc-ref %build-inputs "sqlite")) > + (iwget (assoc-ref %build-inputs "wget")) > + (iwhich (assoc-ref %build-inputs "which")) > + (ixz (assoc-ref %build-inputs "xz")) > + (izstd (assoc-ref %build-inputs "zstd"))) I don't think Hungarian notation is very helpful here. > + (substitute* "spectre-meltdown-checker.sh" > + ; TODO: Find regexp what will work > + ;(("echo") (string-append icoreutils "/bin/echo")) > + ;(("printf") (string-append icoreutils > "/bin/printf")) There are multiple ways of handling this, but I thing the best one would be to substitute both `command -v printf' and `which echo' with the path to false, then match the line [ -z "$echo_cmd" ] && echo_cmd='echo' and instead put there echo_cmd_type='printf' echo_cmd=(path-to "/bin/printf") > + (("dirname") (string-append icoreutils > "/bin/dirname")) > + (("cat") (string-append icoreutils "/bin/cat")) > + (("grep[ ]+") (string-append igrep "/bin/grep ")) > + (("cut") (string-append icoreutils "/bin/cut")) > + (("mktemp") (string-append icoreutils > "/bin/mktemp")) > + (("stat[ ]+") (string-append icoreutils "/bin/stat > " )) > + (("tail[ ]+") (string-append icoreutils "/bin/tail > " )) > + (("head[ ]+") (string-append icoreutils "/bin/head > " )) > + (("mount[ ]+") "/run/setuid-programs/mount ") > + (("modprobe") (string-append iutil-linux > "/bin/modprobe")) > + (("dd") (string-append icoreutils "/bin/dd")) > + (("dmesg[ ]+") (string-append iutil-linux-with-udev > "/bin/dmesg ")) > + (("awk") (string-append igawk "/bin/awk")) > + (("gzip") (string-append igzip "/bin/gzip")) > + (("unzip") (string-append iunzip "/bin/unzip")) > + (("lzop") (string-append ilzop "/bin/lzop")) > + (("perl") (string-append iperl "/bin/perl")) > + (("ps[ ]+") (string-append iprocps "/bin/ps ")) > + (("sqlite3") (string-append isqlite > "/bin/sqlite3")) > + (("wget") (string-append iwget "/bin/wget")) > + (("which") (string-append iwhich "/bin/which")) > + (("xz") (string-append ixz "/bin/xz")) > + (("zstd") (string-append izstd "/bin/zstd"))))))))) Group those that need spaces and those that don't together, with an explanation as to why those two groups exist. > + (inputs `(("binutils" ,binutils) > + ("coreutils",coreutils) > + ("gawk" ,gawk) > + ("grep" ,grep) > + ("gzip" ,gzip) > + ("unzip" ,unzip) > + ("lzop" ,lzop) > + ("perl" ,perl) > + ("procps" ,procps) > + ("sqlite" ,sqlite) > + ("util-linux" ,util-linux) > + ("util-linux-with-udev" ,util-linux+udev) Why both? > + ("wget" ,wget) > + ("which" ,which) > + ("xz" ,xz) > + ("zstd" ,zstd))) > + (synopsis "Spectre, Meltdown ... vulnerability/mitigation > checker") > + (description "A shell script to assess your system's resilience > against > +the several transient execution CVEs that were published since early > 2018, > +and give you guidance as to how to mitigate them.") > + (home-page "https://github.com/speed47/spectre-meltdown-checker" > ) > + (license license:gpl3))) > + > (define-public snapscreenshot > (package > (name "snapscreenshot") > -- > 2.32.0