From debbugs-submit-bounces@debbugs.gnu.org Mon Aug 30 08:50:05 2021 Received: (at 49886) by debbugs.gnu.org; 30 Aug 2021 12:50:05 +0000 Received: from localhost ([127.0.0.1]:58418 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mKgjl-0002dl-Hp for submit@debbugs.gnu.org; Mon, 30 Aug 2021 08:50:05 -0400 Received: from eggs.gnu.org ([209.51.188.92]:40066) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mKgjk-0002ck-Ew for 49886@debbugs.gnu.org; Mon, 30 Aug 2021 08:50:04 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:44644) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mKgje-0006xL-EY; Mon, 30 Aug 2021 08:49:58 -0400 Received: from [2001:660:6102:320:e120:2c8f:8909:cdfe] (port=45100 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mKgje-0008SM-5W; Mon, 30 Aug 2021 08:49:58 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Julien Lepiller Subject: Re: bug#49886: [PATCH v2] Add gitile and gitile service References: <20210805035159.3959e01e@tachikoma.lepiller.eu> <87lf59shyi.fsf@gnu.org> <20210825233136.450d778b@tachikoma.lepiller.eu> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 13 Fructidor an 229 de la =?utf-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Mon, 30 Aug 2021 14:49:56 +0200 In-Reply-To: <20210825233136.450d778b@tachikoma.lepiller.eu> (Julien Lepiller's message of "Wed, 25 Aug 2021 23:31:36 +0200") Message-ID: <87tuj7ayh7.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 49886 Cc: 49886@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi Julien! Julien Lepiller skribis: > attached is a v2 of the series. I added a small change to gitolite that > allows changing UNSAFE_PATT (a regex that matches configuration values > that contain unsafe characters). I wanted to link to it and to the > nginx configuration sections in the manual, but I don't know how to > create that link? I see the @subsubheading NGINX for instance, but I > can't @ref{NGINX}. Right, you cannot cross-reference a heading; you=E2=80=99d need either a no= de or an anchor so you can cross-reference it. > I had to update gitile for the tests to pass and had a few false > starts, but now the tests pass and gitile is working even better than > before :) Yay! :-) > From d43a77241defdea7848ab4596b427c33675f050e Mon Sep 17 00:00:00 2001 > From: Julien Lepiller > Date: Thu, 5 Aug 2021 02:57:32 +0200 > Subject: [PATCH 1/3] gnu: Add gitile. > > * gnu/packages/version-control.scm (gitile): New variable. LGTM! > From 2652e5515c84505c63072309f3b3e7837649cdb9 Mon Sep 17 00:00:00 2001 > From: Julien Lepiller > Date: Wed, 25 Aug 2021 03:00:44 +0200 > Subject: [PATCH 2/3] gnu: gitolite: Add unsafe-patt configuration option. > > * gnu/services/version-control.scm (gitolite-rc-file): Add unsafe-patt > field. > (gitolite-rc-file-compiler): Write it. > * doc/guix.texi (Version Control Services): Document it. [...] > --- a/doc/guix.texi > +++ b/doc/guix.texi > @@ -31426,6 +31426,15 @@ A value like @code{#o0027} will give read access= to the group used by Gitolite > (by default: @code{git}). This is necessary when using Gitolite with so= ftware > like cgit or gitweb. >=20=20 > +@item @code{unsafe-patt} (default: @code{#f}) I=E2=80=99d call this field =E2=80=98unsafe-pattern=E2=80=99 for clarity. > +An optional pattern for catching unsafe configurations in the configurat= ion s/pattern/Perl regular expression/ ? > +file. See > +@uref{https://gitolite.com/gitolite/git-config.html#compensating-for-uns= afe_patt, > +Gitolite's documentation} for more information. > + > +When the value is not @code{#f}, it should be a string containing a Perl > +regular expression, such as @samp{"[`~#\$\&()|;<>]"}. =E2=80=9Csuch as @samp{=E2=80=A6}, which catches XYZ.=E2=80=9D OK with changes along these lines! > From a80c856fce646eee7257239e4c05e67ac292b5fc Mon Sep 17 00:00:00 2001 > From: Julien Lepiller > Date: Thu, 5 Aug 2021 03:46:40 +0200 > Subject: [PATCH 3/3] gnu: version-control: Add gitile service. > > * gnu/services/version-control.scm (gitile-service-type): New variable. > * doc/guix.texi (Version Control Services): Document it. > * gnu/tests/version-control.scm (%test-gitile): New variable. LGTM, thank you! Ludo=E2=80=99.