From debbugs-submit-bounces@debbugs.gnu.org Sat Aug 28 18:59:47 2021 Received: (at 49813) by debbugs.gnu.org; 28 Aug 2021 22:59:48 +0000 Received: from localhost ([127.0.0.1]:55156 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mK7Id-0003DK-Hy for submit@debbugs.gnu.org; Sat, 28 Aug 2021 18:59:47 -0400 Received: from out0.migadu.com ([94.23.1.103]:21152) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mK7IX-0003D6-Rn for 49813@debbugs.gnu.org; Sat, 28 Aug 2021 18:59:42 -0400 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mgsn.dev; s=key1; t=1630191576; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to; bh=lmsM9CmDklmekgM0itaedBcur4kZzSDCFY/30w9kisM=; b=YjmyoyKU/9Koss1zBizgwB4ZY3UL+kKeCuK/vZCfrK0LvQFFuNzFeTgobRhudHRGZC8JZN db1j2ErcVlSPjYDv+qjhaYBdwikNGMQJdMIuj9vCeboaNgOY56KL5zFZHsusR8/UGzZmbL fmDFiZ5zgYbmwiBr3UvtsdoDiftLQWI= From: Sarah Morgensen To: Maxime Devos Subject: Re: [bug#49813] [PATCH 04/34] gnu: tao: Fix regex in FIND-FILES invocation. Date: Sat, 28 Aug 2021 15:59:32 -0700 In-Reply-To: Maxime Devos's message of "Sun, 22 Aug 2021 11:53:24 +0200 (6 days, 13 hours, 3 minutes ago)" Message-ID: <867dg52n1n.fsf@mgsn.dev> MIME-Version: 1.0 Content-Type: text/plain X-Migadu-Flow: FLOW_OUT X-Migadu-Auth-User: iskarian@mgsn.dev X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 49813 Cc: 49813@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hi Maxime, Thanks for taking a look at this. Maxime Devos writes: > Sarah Morgensen schreef op zo 01-08-2021 om 14:18 [-0700]: >> - (find-files "include" "\\.h")) >> + (find-files "include" "\\.h$")) > > C++ header files are sometimes named "something.hpp" instead > of "something.h", so you might want to verify these don't exist. > (And if they do exist, keep the regex "\\.h", or make it "\\.(h|hpp)$"?) > > Likewise for 'kaldi', 'shogun' and 'rtags'. Otherwise, these > new regexes look good to me (but I didn't test them). Good catch. I just checked the sources for all of those, and I can verify that they don't exist. (Shogun and rtags do have .hpp files in their source, but only in other directories.) -- Sarah