From debbugs-submit-bounces@debbugs.gnu.org Sun Jul 25 10:23:59 2021 Received: (at 49705) by debbugs.gnu.org; 25 Jul 2021 14:24:00 +0000 Received: from localhost ([127.0.0.1]:49094 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m7f2t-0005p6-L9 for submit@debbugs.gnu.org; Sun, 25 Jul 2021 10:23:59 -0400 Received: from mugam.systemreboot.net ([139.59.75.54]:37694) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m7f2p-0005ou-6u for 49705@debbugs.gnu.org; Sun, 25 Jul 2021 10:23:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=systemreboot.net; s=default; h=Content-Type:MIME-Version:Message-ID:Date: References:In-Reply-To:Subject:To:From:Sender:Reply-To:Cc: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=43O4jC2wXTjvE3auVF+ycSph/MmsBFthfbwNkINStKY=; b=adETVFvMgjCl30G13X+fiWZ6yn J1AA3+2ntEW38HiFVHRH7aeMRcltJW89p6GrcotehaKFAThfD3+dxXjgit5es8G+QBmHl8lwr+UBZ EXhYXkFWBEUrDNVKEgKGhsxTlzNdM6alpXJbFpBfzPskRZXzAiYf0W3ezL+GXPQ+Vyucw1O4Ju7eT CxgL+ASPbe4HIe2UGT45tYGmmGHoGS41bDIDRnhP5QeTZekTGAeA4fTI2kIktr20EyfuXB+OcGiNv mGZ4FETUDsz/qXJ+laQhiCFTP56ZkqTAQZuPT7f4nv6lZ5Y/3GQPIH40UBTUSDJOyV/QVpoBz/3Uc SkFV4ZJw==; Received: from [192.168.2.1] (helo=steel) by systemreboot.net with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1m7f2l-000ePI-SR; Sun, 25 Jul 2021 19:53:51 +0530 From: Arun Isaac To: Sarah Morgensen , 49705@debbugs.gnu.org Subject: Re: [bug#49705] [PATCH] gnu: gmnisrv: Fix configure flags. In-Reply-To: <7109666ab6ca0797c583fe62942342a9b0a1be89.1627027028.git.iskarian@mgsn.dev> References: <7109666ab6ca0797c583fe62942342a9b0a1be89.1627027028.git.iskarian@mgsn.dev> Date: Sun, 25 Jul 2021 19:53:45 +0530 Message-ID: <87fsw2fp5a.fsf@systemreboot.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 49705 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain Hi Sarah, Thank you for improving our gmnisrv package! > + #:make-flags '("CC=gcc"))) This should be (list (string-append "CC=" ,(cc-for-target))) so that the package cross-compiles correctly. Hard-coding CC=gcc is now deprecated practice. I also feel that this patch should be split into at least two patches or maybe even three. This way, the first line summary in the commit message is much more descriptive of the change. 1. gnu: gmnisrv: Remove dependency on /etc/mime.types. 2. gnu: gmnisrv: Cross-compile. 3. gnu: gmnisrv: Disable tests using tests?. WDYT? Feel free to combine patches 2 and 3 if that splitting is a bit excessive. Thanks, Arun --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQFPBAEBCAA5FiEEf3MDQ/Lwnzx3v3nTLiXui2GAK7MFAmD9c/EbHGFydW5pc2Fh Y0BzeXN0ZW1yZWJvb3QubmV0AAoJEC4l7othgCuzr88H/1kGJwknOwWBPc2LTOOr Uv9w2JknRK19qWqFbSnOax4HndMVbHdqWyu7ZARDX5wflCay8eY53HUNrJ5Q+xWh msxwfifYmInyvhSN3+7X7LsotjKOQx4M61CpksBHS7ojgfBqpGmiitRJUDt78NGw 8rTdJJU/VIY7JuzwN+H2tF0SMIIluSQK3algEIuXku/HT163PKSjv1Fk1vAAD0aC JTddtBYc/t3lD5+R5uD+y6MpffONikbPVkYwaJnTgd64nTssStsITi5cuPdeYGyD GCb0HKWRmfGQRXUP7zXkzgNLl4HI1/335lVcm3T3ChrXi490Sp4fivkVxXwJydhz 5v8= =135u -----END PGP SIGNATURE----- --=-=-=--