From debbugs-submit-bounces@debbugs.gnu.org Fri Jul 23 06:52:16 2021 Received: (at 49670-done) by debbugs.gnu.org; 23 Jul 2021 10:52:16 +0000 Received: from localhost ([127.0.0.1]:42382 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m6smu-0002vV-6r for submit@debbugs.gnu.org; Fri, 23 Jul 2021 06:52:16 -0400 Received: from mailrelay.tugraz.at ([129.27.2.202]:39411) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m6smq-0002vI-Mg for 49670-done@debbugs.gnu.org; Fri, 23 Jul 2021 06:52:14 -0400 Received: from [10.0.0.4] (80-121-26-175.adsl.highway.telekom.at [80.121.26.175]) by mailrelay.tugraz.at (Postfix) with ESMTPSA id 4GWR3F5JwQz3wXd; Fri, 23 Jul 2021 12:52:09 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tugraz.at; s=mailrelay; t=1627037529; bh=vBfBx09CmDhgVo0GcGH3ETdQTsXMk0pSdaeHqA0CK8M=; h=Subject:From:To:Cc:Date:In-Reply-To:References; b=vRlfu/9ldCRIPCgWSXEY9Rs6DsH1wWgD/A0wBgh7BPpJUy0VzmUJAmQ8Hh8tXbgBG 9WF7qQFbBvW5BBsJaJa8WnjgVe7HYoQR309TQQG0OF/Ih801i6cysnO1ft8rboDTDe 2EfwWXH0a5uGH+oY0OAmY2D+Z2YpE+BEezkQrVE0= Message-ID: <63a2a1a14cfcb6d9dfed2749ff5d93b2e9de72f8.camel@student.tugraz.at> Subject: Re: bug#49670: [PATCH] gnu: gnome-maps: Unregister from DBus when asked to. From: Leo Prikler To: Ludovic =?ISO-8859-1?Q?Court=E8s?= Date: Fri, 23 Jul 2021 12:51:43 +0200 In-Reply-To: <87tuklbcpj.fsf@gnu.org> References: <20210720223452.9471-1-leo.prikler@student.tugraz.at> <87fsw7hhce.fsf@gnu.org> <5af9faa539c916abf3fce795e1e127614456fa43.camel@student.tugraz.at> <87tuklbcpj.fsf@gnu.org> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.34.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-TUG-Backscatter-control: bt4lQm5Tva3SBgCuw0EnZw X-Spam-Scanner: SpamAssassin 3.003001 X-Spam-Score-relay: -1.9 X-Scanned-By: MIMEDefang 2.74 on 129.27.10.116 X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 49670-done Cc: 49670-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Am Freitag, den 23.07.2021, 11:29 +0200 schrieb Ludovic Courtès: > Hi Leo, > > Leo Prikler skribis: > > > Am Mittwoch, den 21.07.2021, 16:28 +0200 schrieb Ludovic Courtès: > > [...] > > > > > +++ b/gnu/packages/patches/gnome-maps-really-do- > > > > unregister.patch > > > > @@ -0,0 +1,13 @@ > > > > +Index: gnome-maps-3.36.7/src/application.js > > > > > > Could you add a line at the top of this patch saying what it does > > > along with a link to the merge request above? > > It turns out a similar fix already exists upstream [1], so if we > > decide > > to backport that to 3.36 instead of bumping the package to 3.38, I > > think we should pick the "official" one. > > Even better. > > > > Apart from that the two patches LGTM, especially if it allows me > > > to > > > use gnome-maps again. :-) > > Do "the two patches" refer to this one alone or also to the one > > bumping > > the package to 3.38? > > Both, but I hadn’t realized there’s was an exclusive choice. Well, the exclusive choice comes from the fact that the patch we would have to add to 3.36 is already present in 3.38.1+. So bumping to a sufficiently recent gnome-maps "voids" the patch in that it is already applied. > > Again, I'm a little unsure what would be the preferred solution > > here, > > as either patch adds additional code that would probably need to be > > reverted by Raghav in their GNOME 40 work. > > I don’t know, I think it’s good to have short-term fixes anyway and > it’s > OK if they have to be undone when we eventually upgrade. Your call! I went with bumping to 3.38. While I hope the test suite doesn't break in 40 the same way it does here, there is a slim chance the phase I've added needs to be kept. Thanks