From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 24 18:08:02 2021 Received: (at 49539) by debbugs.gnu.org; 24 Jul 2021 22:08:02 +0000 Received: from localhost ([127.0.0.1]:47164 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m7PoQ-0008E0-4R for submit@debbugs.gnu.org; Sat, 24 Jul 2021 18:08:02 -0400 Received: from out2.migadu.com ([188.165.223.204]:29506) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m7PoM-0008Di-Kl for 49539@debbugs.gnu.org; Sat, 24 Jul 2021 18:08:00 -0400 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mgsn.dev; s=key1; t=1627164476; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=O9np+muwR0JHHS6CvDE9I1rpwtlse6enGZfSve+G+Y4=; b=AE0PMPPuVVenzzmhfY8rYeUr1l9tgwljzJ/sFwoJrwwT3NCPy4Sf6JbBYxZKl4lxGlOF6R ptSbiXDGMMlc+NzDq/uYlEqimT81do4H91SdE0VUmP8liidE7QkFwoglFACsN288U5YclT mrbQJpx6Up6BCJzZJHgvK9zeAlND+J0= From: Sarah Morgensen To: Jack Hill Subject: Re: bug#49539: [PATCH] gnu: Add nginx-rtmp-module. References: <20210712211322.14238-1-jackhill@jackhill.us> <86im13ro1i.fsf_-_@mgsn.dev> Date: Sat, 24 Jul 2021 15:07:54 -0700 In-Reply-To: (Jack Hill's message of "Thu, 22 Jul 2021 16:53:32 -0400 (EDT)") Message-ID: <86sg03pdqd.fsf_-_@mgsn.dev> MIME-Version: 1.0 Content-Type: text/plain X-Migadu-Flow: FLOW_OUT X-Migadu-Auth-User: iskarian@mgsn.dev X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 49539 Cc: 49539@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi, Glad I could help. I forgot to mention also, the `begin` probably isn't necessary (it's probably leftover from when it was a snippet somewhere), but as you say that can be taken care of over time. Jack Hill writes: [...] > P.S. The same opportunities for improvement exists in some of our other nginx > modules, from which I copied this phase. The next time we update those might be > a good time to clean them up. How common is this? Would it warrant an nginx-build-system, or perhaps even a common idiom/general system for packages using multiple sources? Or are the ways in which these packages uses secondary sources different enough that unifying them would be difficult? -- Sarah