From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 22 00:05:42 2021 Received: (at 49539) by debbugs.gnu.org; 22 Jul 2021 04:05:42 +0000 Received: from localhost ([127.0.0.1]:39141 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m6Pxp-0002LF-86 for submit@debbugs.gnu.org; Thu, 22 Jul 2021 00:05:42 -0400 Received: from out0.migadu.com ([94.23.1.103]:16061) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m6Pxm-0002L6-Gl for 49539@debbugs.gnu.org; Thu, 22 Jul 2021 00:05:36 -0400 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mgsn.dev; s=key1; t=1626926733; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LaAUxB6YNBVUt3PXyivSvJ79AfHvjhr2KT+2hBdvZzg=; b=e8Kni7orv9X+ipJV86z92C75/fBjHTDKXOQLw05Q9y1inBNT0QR7kFdYduQ3bWdLOCp8Ex F5Vka5wUnHcOyY+bGzhd9hu3XLb8ISC+mz1u3V7vsTrW8UJGEX8d4wG9KgSomplNAJ1dT+ H5+3xjty2YEbI6Y64/FfhHLSWIBMxAY= From: Sarah Morgensen To: Jack Hill Subject: Re: bug#49539: [PATCH] gnu: Add nginx-rtmp-module. References: <20210712211322.14238-1-jackhill@jackhill.us> Date: Wed, 21 Jul 2021 21:05:29 -0700 In-Reply-To: <20210712211322.14238-1-jackhill@jackhill.us> (Jack Hill's message of "Mon, 12 Jul 2021 17:13:22 -0400") Message-ID: <86im13ro1i.fsf_-_@mgsn.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Migadu-Flow: FLOW_OUT X-Migadu-Auth-User: iskarian@mgsn.dev X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 49539 Cc: 49539@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi! Jack Hill writes: > * gnu/packages/web.scm (nginx-rtmp-module): New variable. > --- > gnu/packages/web.scm | 61 ++++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 61 insertions(+) > > diff --git a/gnu/packages/web.scm b/gnu/packages/web.scm > index 2cc8619b19..a659ad456a 100644 > --- a/gnu/packages/web.scm > +++ b/gnu/packages/web.scm > @@ -50,6 +50,7 @@ > ;;; Copyright =C2=A9 2021 Stefan Reich=C3=B6r > ;;; Copyright =C2=A9 2021 la snesne > ;;; Copyright =C2=A9 2021 Matthew James Kraai > +;;; Copyright =C2=A9 2021 Jack Hill > ;;; > ;;; This file is part of GNU Guix. > ;;; > @@ -771,6 +772,66 @@ documentation.") > (description "This NGINX module provides a scripting support with Lua > programming language."))) >=20=20 > +(define-public nginx-rtmp-module > + (package > + (inherit nginx) > + (name "nginx-rtmp-module") > + (version "1.2.2") > + (source > + (origin > + (method git-fetch) > + (uri (git-reference > + (url "https://github.com/arut/nginx-rtmp-module") > + (commit (string-append "v" version)))) > + (file-name (git-file-name name version)) > + (sha256 > + (base32 "0y45bswk213yhkc2v1xca2rnsxrhx8v6azxz9pvi71vvxcggqv6h"))= )) > + (build-system gnu-build-system) > + (inputs > + `(("nginx-sources" ,(package-source nginx)) > + ,@(package-inputs nginx))) > + (arguments > + (substitute-keyword-arguments > + `(#:configure-flags '("--add-dynamic-module=3D.") > + #:make-flags '("modules") > + #:modules ((guix build utils) > + (guix build gnu-build-system)) > + ,@(package-arguments nginx)) > + ((#:phases phases) > + `(modify-phases ,phases > + ;; The LICENSE file will be overwritten with the one from ngi= nx > + ;; when unpacking the nginx source, so copy this one to its o= wn > + ;; file. > + (add-after 'unpack 'preserve-license-file > + (lambda _ (copy-file "LICENSE" "LICENSE.rtmp"))) > + (add-after 'preserve-license-file 'unpack-nginx-sources > + (lambda* (#:key inputs native-inputs #:allow-other-keys) > + (begin > + ;; The nginx source code is part of the module=E2=80=99= s source. > + (format #t "decompressing nginx source code~%") > + (let ((tar (assoc-ref inputs "tar")) > + (nginx-srcs (assoc-ref inputs "nginx-sources"))) > + (invoke (string-append tar "/bin/tar") > + "xvf" nginx-srcs "--strip-components=3D1")) You can probably drop the direct reference to tar and just use `(invoke "tar" ...)` Also, if you want to avoid the extra step of renaming the original LICENSE, you can use `--transform=3Ds,/LICENSE$,/LICENSE.nginx,` as an argument to tar. > + #t))) > + (replace 'install > + (lambda* (#:key outputs #:allow-other-keys) > + (let ((modules-dir (string-append (assoc-ref outputs "out= ") > + "/etc/nginx/modules"))) > + (install-file "objs/ngx_rtmp_module.so" modules-dir) > + #t))) > + (delete 'fix-root-dirs) > + (delete 'install-man-page))))) > + (home-page "https://github.com/arut/nginx-rtmp-module") > + (synopsis "NGINX module for audio and video streaming with RTMP") > + (description "This NGINX module provides streaming with the @acronym= {RTMP, > +Real-Time Messaging Protocol}, @acronym{DASH, Dynamic Adaptive Streaming= over HTTP}, > +and @acronym{HLS, HTTP Live Streaming} protocols. It allows NGINX to ac= cept > +incoming RTMP streams for recording or redistribution. It also supports > +on-demand streaming from a file on disk and pulling from an upstream RTMP > +stream. Remote control of the module is possible over HTTP.") > + (license license:bsd-2))) > + > (define-public lighttpd > (package > (name "lighttpd") -- Sarah