From debbugs-submit-bounces@debbugs.gnu.org Tue Jul 20 17:29:22 2021 Received: (at 49531) by debbugs.gnu.org; 20 Jul 2021 21:29:22 +0000 Received: from localhost ([127.0.0.1]:35555 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m5xIo-0003T4-J3 for submit@debbugs.gnu.org; Tue, 20 Jul 2021 17:29:22 -0400 Received: from eggs.gnu.org ([209.51.188.92]:50674) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m5xIn-0003Sr-JT for 49531@debbugs.gnu.org; Tue, 20 Jul 2021 17:29:22 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:59220) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m5xIh-0002zq-7R; Tue, 20 Jul 2021 17:29:15 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=45244 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m5xIh-0007KS-06; Tue, 20 Jul 2021 17:29:15 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Sarah Morgensen Subject: Removing input labels for Rust #:cargo-inputs & co.? References: <598b53d80d66a229502d235507047a7717a15e8d.1626067919.git.iskarian@mgsn.dev> Date: Tue, 20 Jul 2021 23:29:13 +0200 In-Reply-To: <598b53d80d66a229502d235507047a7717a15e8d.1626067919.git.iskarian@mgsn.dev> (Sarah Morgensen's message of "Sun, 11 Jul 2021 22:48:09 -0700") Message-ID: <87lf60isie.fsf_-_@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 49531 Cc: 49531@debbugs.gnu.org, Efraim Flashner X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Sarah Morgensen skribis: > Sanitize cargo's inputs here since the package field sanitizers don't > know about them. > > * guix/packages.scm (sanitize-inputs): Export procedure. > * guix/build-system/cargo.scm (package-cargo-inputs) > (package-cargo-development-inputs) > (lower): Sanitize inputs before using them. So, do we want to do that? :-) I=E2=80=99d say yes, but what do Rust folks think? (Efraim?) Are labels of #:cargo-inputs & co. used at all? If not, we can probably go one step further and have sanitation remove input labels instead of adding them. And then, how do we handle the transition? I=E2=80=99m not enthusiastic ab= out customizing =E2=80=98guix style=E2=80=99 for Rust packages; should we embar= k on manual changes of the 2.4K Rust packages? > +++ b/guix/packages.scm > @@ -7,6 +7,7 @@ > ;;; Copyright =C2=A9 2019 Marius Bakke > ;;; Copyright =C2=A9 2020, 2021 Maxim Cournoyer > ;;; Copyright =C2=A9 2021 Chris Marusich > +;;; Copyright =C2=A9 2021 Sarah Morgensen > ;;; > ;;; This file is part of GNU Guix. > ;;; > @@ -117,6 +118,7 @@ > prepend ;syntactic keyword > replace ;syntactic keyword > modify-inputs > + sanitize-inputs I=E2=80=99d rather not export it to make sure users don=E2=80=99t mistakenl= y view it as part of the public interface; it=E2=80=99s really just an internal helper. Thanks, Ludo=E2=80=99.