From debbugs-submit-bounces@debbugs.gnu.org Tue Aug 03 16:13:28 2021 Received: (at 49494) by debbugs.gnu.org; 3 Aug 2021 20:13:28 +0000 Received: from localhost ([127.0.0.1]:41627 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mB0n2-0004ql-2t for submit@debbugs.gnu.org; Tue, 03 Aug 2021 16:13:28 -0400 Received: from mugam.systemreboot.net ([139.59.75.54]:46272) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mB0mz-0004qc-1c for 49494@debbugs.gnu.org; Tue, 03 Aug 2021 16:13:26 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=systemreboot.net; s=default; h=Content-Type:MIME-Version:Message-ID:Date: References:In-Reply-To:Subject:Cc:To:From:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=E12lJ5qCbOddsOUizjCOmKfq/rJj/hqxwUMbDSJ0iVE=; b=dUMMOWUmsktwDaYFXbON9SbKEH IY6NEhkcZQPnjDmMkeGdgpNNdbc97RI/Oach8WaEeKA0W5CxrHvg3Jz78ayGWKnfxjgpvTQcQEZSi 0aspR3gdvyqAe+ENsH0hOE4U7u4OEHZm8h8LQ4PCSCGi4xb3bgq1csZdjNNWgMV6ZPV+RSn5BbfhK wfiE2S9m4vID3SFTbCFrUfzglw/Yweb2dB4ONNHUKHQYvO3gM9qlpASiYgjWGtkl18EilB6ygImT/ YqpNoi+vWlHl4gWodE+Jxheg88PNopdns2lKm+L751OI2HmlkMcaXXETzUgJnb+9A4nHd4HQKejMt c6JT3D7Q==; Received: from [192.168.2.1] (helo=steel) by systemreboot.net with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1mB0mv-000BC0-Qj; Wed, 04 Aug 2021 01:43:21 +0530 From: Arun Isaac To: Sarah Morgensen Subject: Re: bug#49494: [PATCH 0/7] Add nncp In-Reply-To: <86y29j4rlz.fsf_-_@mgsn.dev> References: <20210709161940.12759-1-arunisaac@systemreboot.net> <20210709161940.12759-7-arunisaac@systemreboot.net> <86wnphrfhr.fsf_-_@mgsn.dev> <87o8agapkl.fsf@systemreboot.net> <861r7c5r3v.fsf_-_@mgsn.dev> <87im0nai37.fsf@systemreboot.net> <87v94nzogj.fsf@systemreboot.net> <86y29j4rlz.fsf_-_@mgsn.dev> Date: Wed, 04 Aug 2021 01:42:58 +0530 Message-ID: <87a6ly70dx.fsf@systemreboot.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 49494 Cc: 49494@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain Hi Sarah, >> I set up a tmpfs file system at /tmp. And, curiously, now the package >> builds successfully. No idea why this is happening, though. > > I actually just figured this out as well. You're on a rotational disk, > aren't you? Yep. > Since nncp makes heavy use of the spool file (which I think > it mocks in /tmp for testing), I think that's why your tests are taking > so long and timing out. Tests complete for me on a SSD in ~40s. (All the > error messages are red herrings; they're expected errors.) If this is > the case, it might be worth it to increase the test timeout for those > who use --no-substitutes. Indeed, that makes sense! I have now disabled the timeout. Without a tmpfs, the tests take ~47 minutes on my rotational disk, but they do complete successfully. >>>>>> Does CFGPATH need to be set? >>>>> >>>>> I have now set CFGPATH TO /etc/nncp.hjson. >>>> >>>> When I run any of the executables, I get: >>>> >>>> main.go:73: Error during initialization: stat /usr/local/etc/nncp.hjson: >>>> no such file or directory I fixed this as well. `go list` wasn't finding the correct module path, and thus the correct cfgpath variable was not being set. I'm sending a v3 of the patch. Let me know if everything looks good, and I'll push. Thanks for the comprehensive review! :-) The package looks much better now. Regards, Arun --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQFPBAEBCAA5FiEEf3MDQ/Lwnzx3v3nTLiXui2GAK7MFAmEJo0obHGFydW5pc2Fh Y0BzeXN0ZW1yZWJvb3QubmV0AAoJEC4l7othgCuz+/wIAIKvi4eal6b6jzjlFSJf WhLYXGQWWr9ZfqCwbJNvRJGlPh3oATstwWvJIH8RFyoQrKsk8ZS1MbRLkUzxLKYI WbinOzrK3KF37k0YJrsv6Jb7Gz12GD+loSVli/B9AoIwZw9HvGignJsQcrH9IOZ5 k6LuaV43gOhfg8LZEf3Vc2bdtdKMx1hPNb1EcoMQRQ5I/Q7jzM6joKbpHAMfsvxO USvWVz6ix43GRF3dHHFHt5AK9PlvOaBVz5AwgtFJZEMDYm1rZY/k7xBvnylyipQ9 lwO+Jcf/96CP1mIaF48gELMXuXz/Nqu4+Pv4NO4tv4Di2MCIdLYE2Wocwse9RMjI Wi8= =YjY9 -----END PGP SIGNATURE----- --=-=-=--