From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 08 07:38:25 2021 Received: (at 49457) by debbugs.gnu.org; 8 Jul 2021 11:38:25 +0000 Received: from localhost ([127.0.0.1]:54458 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m1SML-00047R-20 for submit@debbugs.gnu.org; Thu, 08 Jul 2021 07:38:25 -0400 Received: from relay5-d.mail.gandi.net ([217.70.183.197]:54083) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m1SMI-00047D-RD for 49457@debbugs.gnu.org; Thu, 08 Jul 2021 07:38:23 -0400 Received: (Authenticated sender: admin@nicolasgoaziou.fr) by relay5-d.mail.gandi.net (Postfix) with ESMTPSA id 996811C0002; Thu, 8 Jul 2021 11:38:15 +0000 (UTC) From: Nicolas Goaziou To: Kyle Meyer Subject: Re: [bug#49457] [PATCH v2] gnu: Add emacs-consult-notmuch. References: <87tul6w7g2.fsf@trop.in> <87r1gaw6u8.fsf@trop.in> <87czrutdf9.fsf@nicolasgoaziou.fr> <87eecaqjlu.fsf@trop.in> <878s2hqmlp.fsf@nicolasgoaziou.fr> <86bl7d2mny.fsf@gmail.com> <87h7h5p2gt.fsf@nicolasgoaziou.fr> <87mtqx82or.fsf@kyleam.com> Date: Thu, 08 Jul 2021 13:38:14 +0200 In-Reply-To: <87mtqx82or.fsf@kyleam.com> (Kyle Meyer's message of "Thu, 08 Jul 2021 07:28:36 -0400") Message-ID: <87k0m1nihl.fsf@nicolasgoaziou.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 49457 Cc: zimoun , 49457@debbugs.gnu.org, Andrew Tropin X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hello, Kyle Meyer writes: > Nicolas Goaziou writes: > >> However, I think it is a bug if Emacs Magit does not work with git in >> profile. We should modify the source so both magit-git-executable and >> magit-gitk-executable point to those from inputs. >> >> I suggest to open a new bug report about it, WDYT? > > Rewriting magit-git-executable to an absolute file name will break Magit > for those that use it over TRAMP. Point taken. However, such users can fix it by modifying the `magit-git-executable' defcustom again, can't they? So, the situation would arguably not be worse that what it is currently, since it simply doesn't work for users relying on a local installation of git, and those are probably more common. Also, a third option: since we're not making use of git input at runtime, why should it be an input at all? If it is needed at build time, a native-input should suffice. Regards, -- Nicolas Goaziou