From debbugs-submit-bounces@debbugs.gnu.org Sun Aug 01 06:08:52 2021 Received: (at 49451) by debbugs.gnu.org; 1 Aug 2021 10:08:53 +0000 Received: from localhost ([127.0.0.1]:35546 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mA8Oq-0007b6-LK for submit@debbugs.gnu.org; Sun, 01 Aug 2021 06:08:52 -0400 Received: from h87-96-130-155.cust.a3fiber.se ([87.96.130.155]:35946 helo=mail.yoctocell.xyz) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mA8Op-0007aq-1R for 49451@debbugs.gnu.org; Sun, 01 Aug 2021 06:08:51 -0400 From: Xinglu Chen DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=yoctocell.xyz; s=mail; t=1627812521; bh=t0Oxss9Gh7rMaFZZpk/z9MMNpJiKG6mUPfODcLk/GT4=; h=From:To:Subject:In-Reply-To:References:Date; b=cxYfQVIhknyMxbNEdSkoHcCptHPFyqbO5g+QNbgqypJCmjxGnpWUGRik07h9f0gfQ +3Wg3+xF1nVu5ouVscrRWTnqnmUZfj6D0CH+0R/WHzcJUEsB10xSfXhwSKEdHZx0yT 6wJeKGYjXGxIVnDryXKR3DpmSdiX3zwvTlXzii1o= To: southerntofu , 49451@debbugs.gnu.org Subject: Re: [bug#49451] [PATCH 01/20] gnu: rust-blake2: Update to 0.9 In-Reply-To: References: Date: Sun, 01 Aug 2021 12:08:32 +0200 Message-ID: <87czqxbhpb.fsf@yoctocell.xyz> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-Spam-Score: 2.9 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: On Sun, Jul 11 2021, southerntofu via Guix-patches via wrote: > --- Please write commit messages in the GNU ChangeLog format; you can look at the commit log for examples, or see the manual. Content analysis details: (2.9 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_PASS SPF: sender matches SPF record 2.0 PDS_OTHER_BAD_TLD Untrustworthy TLDs [URI: yoctocell.xyz (xyz)] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.5 FROM_SUSPICIOUS_NTLD From abused NTLD 0.4 RDNS_DYNAMIC Delivered to internal network by host with dynamic-looking rDNS 0.0 PDS_RDNS_DYNAMIC_FP RDNS_DYNAMIC with FP steps X-Debbugs-Envelope-To: 49451 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 2.9 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: On Sun, Jul 11 2021, southerntofu via Guix-patches via wrote: > --- Please write commit messages in the GNU ChangeLog format; you can look at the commit log for examples, or see the manual. Content analysis details: (2.9 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_PASS SPF: sender matches SPF record 2.0 PDS_OTHER_BAD_TLD Untrustworthy TLDs [URI: yoctocell.xyz (xyz)] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.5 FROM_SUSPICIOUS_NTLD From abused NTLD 0.4 RDNS_DYNAMIC Delivered to internal network by host with dynamic-looking rDNS 1.0 BULK_RE_SUSP_NTLD Precedence bulk and RE: from a suspicious TLD -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager 0.0 PDS_RDNS_DYNAMIC_FP RDNS_DYNAMIC with FP steps --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On Sun, Jul 11 2021, southerntofu via Guix-patches via wrote: > --- Please write commit messages in the GNU ChangeLog format; you can look at the commit log for examples, or see the manual. If you use emacs, you can use the Yasnippet snippets found in the etc/snippets/text-mode directory when writing commit messages. > gnu/packages/crates-io.scm | 27 +++++++++++++++++++++++++++ > 1 file changed, 27 insertions(+) > > diff --git a/gnu/packages/crates-io.scm b/gnu/packages/crates-io.scm > index d53f8fb525..5ed2ff470e 100644 > --- a/gnu/packages/crates-io.scm > +++ b/gnu/packages/crates-io.scm > @@ -5207,6 +5207,33 @@ streams in big-endian and little-endian formats.") > "This package provides a crate for manipulating memory, bit by bit.= ") > (license license:expat))) >=20=20 > +(define-public rust-blake2-0.9 > + (package > + (name "rust-blake2") > + (version "0.9.1") > + (source > + (origin > + (method url-fetch) > + (uri (crate-uri "blake2" version)) > + (file-name > + (string-append name "-" version ".tar.gz")) > + (sha256 > + (base32 > + "1x3qz692hfrxgw6cd94iiid6iqal2dwj6zv5137swpgg4l17598h")))) > + (build-system cargo-build-system) > + (arguments > + `(#:skip-build? > + #t > + #:cargo-inputs > + (("rust-crypto-mac" ,rust-crypto-mac-0.8) > + ("rust-digest" ,rust-digest-0.9) > + ("rust-opaque-debug" ,rust-opaque-debug-0.3)))) > + (home-page > + "https://github.com/RustCrypto/hashes") > + (synopsis "BLAKE2 hash functions") > + (description "BLAKE2 hash functions") The description should consist of one ore more full sentences, see =E2=80=9C16.4.4 Synopses and Descriptions=E2=80=9D in the manual. Make sure to run =E2=80=98guix lint=E2=80=99 to avoid common mistakes like = these. Also, I noticed that a =E2=80=98rust-blake2-0.8=E2=80=99 package already ex= ists, maybe it would be possible to update that to 0.9, or make it inherit from =E2=80=98rust-blake2-0.9=E2=80=99 to avoid some code duplication. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQJJBAEBCAAzFiEEAVhh4yyK5+SEykIzrPUJmaL7XHkFAmEGcqAVHHB1YmxpY0B5 b2N0b2NlbGwueHl6AAoJEKz1CZmi+1x54aYP/RSluhiAMLilpqzKC/sPrjvKb4FH cA4vnFjqvgtDby/AP4cO5he9n75X/IKjC9oCx4zUN+scifon+cX3RpAAsdiSI7G1 2A44b+XvB4wpJm2JGcS03E3KTicRWLKR7mQl62QR+R7IBSEZkm2flvoWvMsax5Z4 VFRZSTVrtCqREct3Gj+tfyeFNjv5127TGMZpkiqgcZQof/yDTi44HOs8SbtxtmMZ HJ/LDk8SwMyqjsNVzN9dnrfswK+rbTIVU08x0qrguf6LWWEvwVa/4fW6OemIbLO8 esPKMG/0Ob+PE1g2ys2OqCtscCcV84Rx4enbPPsNsTulweeOqcN8JwB97D5d77QG Ul7DM2uv4m13tzuSzu5nfO7khHDx7l/UQfjIRiTFn29IlaO/uCjChGsAIEco5Uzd cYNlXEgpsrbCgfOE/rxsVN/iW01awPpY4mQkWoeQJhAV3aewT/ao+MuS4QtNZhIA 1MxA58s57ufWLzjKXPC4Bg3QqnNjQRpKqc44F5JeRTWQuc8JL94RtbZlR3P0vwJv Zll+vFwE4fyNiNwnBMEoUll9QFQfteECxH3J+yNs+RoW9v3Aqo/mj8vUP5CmYUoS QF9MhedtP7FoX8RNdsemCHQnm+D9o/NNyIHflX+7SL9Tfmff8rgwheo0xwjB6/Xp 4x0lH2ecwmLSdZH6 =Gbga -----END PGP SIGNATURE----- --=-=-=--