From debbugs-submit-bounces@debbugs.gnu.org Wed Jul 21 11:09:24 2021 Received: (at 49419) by debbugs.gnu.org; 21 Jul 2021 15:09:24 +0000 Received: from localhost ([127.0.0.1]:38289 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m6Dqe-00085c-6r for submit@debbugs.gnu.org; Wed, 21 Jul 2021 11:09:24 -0400 Received: from eggs.gnu.org ([209.51.188.92]:58474) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m6Dqc-00085N-Gk for 49419@debbugs.gnu.org; Wed, 21 Jul 2021 11:09:23 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:51006) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m6DqV-0000V9-Ln; Wed, 21 Jul 2021 11:09:17 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=45274 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m6DqG-0007O4-LQ; Wed, 21 Jul 2021 11:09:07 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Andrew Tropin Subject: Re: bug#49419: [PATCH 0/4] Essential home services References: <87y2akhiz1.fsf@trop.in> <87v956g1g5.fsf@trop.in> Date: Wed, 21 Jul 2021 17:08:55 +0200 In-Reply-To: <87v956g1g5.fsf@trop.in> (Andrew Tropin's message of "Mon, 19 Jul 2021 11:04:01 +0300") Message-ID: <87im13g0vs.fsf_-_@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 49419 Cc: 49419@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi Andrew, Andrew Tropin skribis: > Diff with v2: Prevents unecessary calls to system* > > Please, when review finished, apply against guix-home-wip branch. > > Andrew Tropin (4): > home-services: Add most essential home services > home-services: Add home-run-on-change-service-type > home-services: Add home-provenance-service-type > home-services: Add fold-home-service-types function Thanks for sending this first patch series! How would you like to proceed? Sending patches that add essential services, and then (guix scripts home =E2=80=A6) modules? I agree we should apply it all in =E2=80=98wip-guix-home=E2=80=99 for now. Some general comments: =E2=80=A2 Please remove tabs from Scheme files. =E2=80=A2 Please do not write documentation in commit logs. For example, patch #1 explains the different service types, but to me, that=E2=80=99d belong in a comment or (better yet) in a section of the manual. For commit logs, we use ChangeLog style: https://guix.gnu.org/manual/en/html_node/Submitting-Patches.html It=E2=80=99s OK if you don=E2=80=99t get the fine points right from the= start, committers can tweak it for you. :-) =E2=80=A2 When there are tests or documentation, add them in the commit t= hat adds the corresponding functionality. =E2=80=A2 Regarding module names: what about putting everything in the (g= nu home =E2=80=A6) name space. For services, I wonder if we could simply = use (gnu services home), for the essential services, and other (gnu services =E2=80=A6) module, but that assumes some code can be shared be= tween System and Home. Thoughts? I=E2=80=99ll look at the actual patches later, but I invite others to chime= in too. :-) Thanks! Ludo=E2=80=99.