From debbugs-submit-bounces@debbugs.gnu.org Thu Aug 05 13:17:36 2021 Received: (at 49221) by debbugs.gnu.org; 5 Aug 2021 17:17:36 +0000 Received: from localhost ([127.0.0.1]:48313 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mBgzv-0005j1-OL for submit@debbugs.gnu.org; Thu, 05 Aug 2021 13:17:36 -0400 Received: from mail-qk1-f176.google.com ([209.85.222.176]:34770) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mBgzt-0005in-TQ for 49221@debbugs.gnu.org; Thu, 05 Aug 2021 13:17:34 -0400 Received: by mail-qk1-f176.google.com with SMTP id w197so5699671qkb.1 for <49221@debbugs.gnu.org>; Thu, 05 Aug 2021 10:17:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=VkR1EpncbTcCdXAR03VFsuNG0+NhmERiMEglz5Ll6ro=; b=njc2NeDuqi8Vw0ecfS68Gbz0rmrqIObq03DP1UYM+T+oZbw6hfLg38NsgAuZutOfo3 9PmRndpn6qB3gHKn3qtg44MZCvlNRm/qY+i6iqTwJKo15LpU6N3+cjZblDdFoiO43Xzz KiRRaeiqj85SIhhKn9gezTlCuTEHIychuR5tIcEe7Va3pIiAScHLp60Nr0nPz5/jH25X /OOTprSYvrJhtLNe52xHORNvc0CtebDMS6pTQ/2wdKyo7RL7rZTT5IZPQYzTyVR0YZgX 8poFdrghXWT/Hjjr1km1Epie3fK8nK+k8/FfY4kh4c+d0fcWh+Kdcsud9V4AgxsjX/JI 5oMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=VkR1EpncbTcCdXAR03VFsuNG0+NhmERiMEglz5Ll6ro=; b=WE6V7cWrfNcMIJ5c50Ii0+AAEypRCfKdWoRO9q39G2I6iy4QlLg4FvaIVJOapr1aZS nK8edLWQjzDyUbEAbqpeauFr2GrvRPSB+tAUFvUDrnB66ojD74Lt4jF/wGcgbl7+/iRo QCStSX5d/O76veRK17VwXsUPnkt3h6TzfcmRO6jyTPCdKTstSMFZiisK9kS3C5FRF6F+ ESn1cgsqThBdZsDXBGxeSX5w39HiGzajUvc33Bg8uNaTUWboLZ4AMp2nMH8YTv0eE25o sitAO5OGNxlRslImg8Cib8cw+3JQ6Z7gyuKw7vTUH3mV2iuTDT1P7epCda5IHDZTpVoL wPMw== X-Gm-Message-State: AOAM533SDehBARMMJbcFdaJU4fQkxB/og91Wvzj6TNLzXLkSoSKDKnX1 WQyiDIC3AjDZ4dRse+MJiSKftdwnb1tnly7b X-Google-Smtp-Source: ABdhPJymETtvG6XmYnzRi0i4IsudFBs8S0H2MLtgepBlN7Y24iMxEVz2LxZ+0cPp68xw8weg4O+LUA== X-Received: by 2002:a37:e91:: with SMTP id 139mr6047612qko.239.1628183848326; Thu, 05 Aug 2021 10:17:28 -0700 (PDT) Received: from raisin ([2607:fad8:4:6:235e:8579:8464:aacc]) by smtp.gmail.com with ESMTPSA id s19sm2501644qtx.5.2021.08.05.10.17.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Aug 2021 10:17:27 -0700 (PDT) From: Maxim Cournoyer To: Sarah Morgensen Subject: Re: bug#49221: [PATCH 00/13] Add go-1.16 and build with gccgo References: <00966aa0d291e3eeed89103fc456981171b403cf.1624602942.git.iskarian@mgsn.dev> Date: Thu, 05 Aug 2021 13:17:27 -0400 In-Reply-To: <00966aa0d291e3eeed89103fc456981171b403cf.1624602942.git.iskarian@mgsn.dev> (Sarah Morgensen's message of "Fri, 25 Jun 2021 00:21:02 -0700") Message-ID: <87wnoz7qvs.fsf_-_@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 49221 Cc: 49221@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hello, Sarah Morgensen writes: > * gnu/packages/patches/go-github-com-bmatcuk-doublestar-1.3-remove-test.patch: > New file. > * gnu/local.mk (dist_patch_DATA): Register it. > * gnu/packages/golang.scm (go-github-com-bmatcuk-doublestar): Use it. > --- > gnu/local.mk | 1 + > gnu/packages/golang.scm | 5 ++++- > ...b-com-bmatcuk-doublestar-1.3-remove-test.patch | 15 +++++++++++++++ > 3 files changed, 20 insertions(+), 1 deletion(-) > create mode 100644 gnu/packages/patches/go-github-com-bmatcuk-doublestar-1.3-remove-test.patch > > diff --git a/gnu/local.mk b/gnu/local.mk > index 9caae52306..a176772ece 100644 > --- a/gnu/local.mk > +++ b/gnu/local.mk > @@ -1172,6 +1172,7 @@ dist_patch_DATA = \ > %D%/packages/patches/gobject-introspection-cc.patch \ > %D%/packages/patches/gobject-introspection-girepository.patch \ > %D%/packages/patches/go-skip-gc-test.patch \ > + %D%/packages/patches/go-github-com-bmatcuk-doublestar-1.3-remove-test.patch \ > %D%/packages/patches/gpm-glibc-2.26.patch \ > %D%/packages/patches/gpodder-disable-updater.patch \ > %D%/packages/patches/gpsbabel-fix-i686-test.patch \ > diff --git a/gnu/packages/golang.scm b/gnu/packages/golang.scm > index 9d5fc36710..3170e11925 100644 > --- a/gnu/packages/golang.scm > +++ b/gnu/packages/golang.scm > @@ -5314,7 +5314,10 @@ template functions.") > (file-name (git-file-name name version)) > (sha256 > (base32 > - "0bk5bixl6rqa8znxghyp6zndbccx9kdyrymjahgyp6qsrp7rk144")))) > + "0bk5bixl6rqa8znxghyp6zndbccx9kdyrymjahgyp6qsrp7rk144")) > + (patches > + (search-patches > + "go-github-com-bmatcuk-doublestar-1.3-remove-test.patch")))) > (build-system go-build-system) > (arguments > `(#:import-path "github.com/bmatcuk/doublestar")) > diff --git a/gnu/packages/patches/go-github-com-bmatcuk-doublestar-1.3-remove-test.patch b/gnu/packages/patches/go-github-com-bmatcuk-doublestar-1.3-remove-test.patch > new file mode 100644 > index 0000000000..2c64575914 > --- /dev/null > +++ b/gnu/packages/patches/go-github-com-bmatcuk-doublestar-1.3-remove-test.patch > @@ -0,0 +1,15 @@ > +Remove test which fails with Go >= 1.15 due to API changes. > +This patch should no longer be necessary with doublestar v4+ > + > +diff --git a/doublestar_test.go b/doublestar_test.go > +index b21d20ad4b..f510c3d06b 100644 > +--- a/doublestar_test.go > ++++ b/doublestar_test.go > +@@ -80,7 +80,6 @@ var matchTests = []MatchTest{ > + {"[", "a", false, ErrBadPattern, true}, > + {"[^", "a", false, ErrBadPattern, true}, > + {"[^bc", "a", false, ErrBadPattern, true}, > +- {"a[", "a", false, nil, false}, > + {"a[", "ab", false, ErrBadPattern, true}, > + {"*x", "xxx", true, nil, true}, > + {"[abc]", "b", true, nil, true}, This should be reported upstream, if the test is still not working with the latest release (v4.0.2). Thanks, Maxim