From debbugs-submit-bounces@debbugs.gnu.org Fri Jun 25 12:48:04 2021 Received: (at 49196) by debbugs.gnu.org; 25 Jun 2021 16:48:04 +0000 Received: from localhost ([127.0.0.1]:46712 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lwozs-0001aR-Fn for submit@debbugs.gnu.org; Fri, 25 Jun 2021 12:48:04 -0400 Received: from mail-wm1-f54.google.com ([209.85.128.54]:43939) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lwozj-0001Zf-QR for 49196@debbugs.gnu.org; Fri, 25 Jun 2021 12:47:56 -0400 Received: by mail-wm1-f54.google.com with SMTP id p8-20020a7bcc880000b02901dbb595a9f1so6253451wma.2 for <49196@debbugs.gnu.org>; Fri, 25 Jun 2021 09:47:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=UkPd/sRmmdnmzmWROqOQXNgu7WKtaClM5CwL7J1hPoA=; b=j70L/uMd8BLEzJd/Fa02EAyRyCf2yOgvd/VHXk1H0nlzLo7aJJrYDRYalbKuyfXAbq D/BTSnSjQoZPKUHE9bVS9NcBG6wszYEYj+wXsLD4cDGD7UFmR2kgjT3nv7r8XXnJ9gsX HmHJ0a3G2tKu1OtmUtpsnbeuUvzD9Wr2DmVW1HmaD5SVjuzkBgS7TJt97IdkYBF5NMyh +DqKt6CxvFKA9JmkXyc/KFLC6TaeSCYgWNlaAA8/rihfBgsEPkAzBGXR4IeDh5OJbRyw FQDTQ/vb08YK/JwvRYR2YPxuqFwPk4uKr1Vh/zs25vnjt02K4xqs+MIGLXroGRCB7cjK pLAg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=UkPd/sRmmdnmzmWROqOQXNgu7WKtaClM5CwL7J1hPoA=; b=L9vfdIK6BHU6ufDHe82++loTI8FTi6TMJWSBuKCZjOQfpD3y0DJH5T2PQGBH9RnjoD daRnfhC5Yzkyhdh/QuDmW4gu02R6ULorD1R4FNUgG2sTb04oMA3BVxGhz8ul+m+wmvo3 ER981Ps+MLOnuq8LrBoPJmux5hJlss8ig0+Ebv6Ri2aJbvY9EtJ2ly6pb6rq20ECNNAx zCrasXcADzoywHnaFQ1pWCN3WiYqgd9SunkG6KEJJkA6dYwJ7JUpe/pi8XB4w/xkCFdh OTyvh8iFlabfZMJV80+tsBn5xsuo9KAjI/1U72Nf+CFWXMgPx62ORQQuZ/P5U62T2swD vXqA== X-Gm-Message-State: AOAM533EIaj5o6G8a12xRMwA8AtiJpscatiIfe0iH48thjfnyKZONTDC FzF6TNchq3zSynObBlosL1FgO9jHj74= X-Google-Smtp-Source: ABdhPJzrigGcxg//A+xWcN7TrzOJnbyG9gYgDxxbz1vDjM8YDUkzqMHz170IWLBV5yop43r9pKbS0Q== X-Received: by 2002:a7b:c089:: with SMTP id r9mr11694421wmh.167.1624639669897; Fri, 25 Jun 2021 09:47:49 -0700 (PDT) Received: from bioinfomeary01-Precision-7820-Tower ([193.48.40.110]) by smtp.gmail.com with ESMTPSA id u10sm6086823wmm.21.2021.06.25.09.47.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 25 Jun 2021 09:47:49 -0700 (PDT) From: zimoun To: Sarah Morgensen Subject: Re: bug#49196: [PATCH] import: utils: 'recursive-import' skips unfound packages References: <07d7149fc0f89f7f2d11fba47e1b0b2db5ceb809.1624479231.git.iskarian@mgsn.dev> <854kdna1wu.fsf@gmail.com> <86lf6y7eur.fsf_-_@mgsn.dev> Date: Fri, 25 Jun 2021 18:47:23 +0200 In-Reply-To: <86lf6y7eur.fsf_-_@mgsn.dev> (Sarah Morgensen's message of "Thu, 24 Jun 2021 21:22:36 -0700") Message-ID: <85v96199ic.fsf_-_@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 49196 Cc: 49196@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Sarah, I sent a v3 where your v2 is split into 2 parts. Then I move the guard. Now, your initial example returns: --8<---------------cut here---------------start------------->8--- $ ./pre-inst-env guix import go git.sr.ht/~sircmpwn/aerc -r following redirection to `https://pkg.go.dev/github.com/zenhack/go.notmuch'... following redirection to `https://pkg.go.dev/github.com/zenhack/go.notmuch'... following redirection to `https://github.com/ProtonMail/go-crypto?go-get=1'... following redirection to `https://github.com/jtolio/gls?go-get=1'... guix import: warning: Something went wrong with ("github.com/neelance/sourcemap" #:goproxy "https://proxy.golang.org" #:version #f #:pin-versions? #f). guix import: warning: Something went wrong with ("github.com/neelance/astrewrite" #:goproxy "https://proxy.golang.org" #:version #f #:pin-versions? #f). (define-public go-git-sr-ht-~sircmpwn-getopt (package (name "go-git-sr-ht-~sircmpwn-getopt") (version "0.0.0-20201218204720-9961a9c6298f") (source [...] ("go-github-com-creack-pty" ,go-github-com-creack-pty) ("go-git-sr-ht-~sircmpwn-getopt" ,go-git-sr-ht-~sircmpwn-getopt))) (home-page "https://git.sr.ht/~sircmpwn/aerc") (synopsis "aerc") (description "aerc is an email client for your terminal.") (license license:expat))) --8<---------------cut here---------------end--------------->8--- WDYT? Well, I do not know if it is good idea to catch the 'else' case because it hiddes what is wrong by the importer. On the other hand, it seems a bit friendler for the end-user. :-) Cheers, simon