From debbugs-submit-bounces@debbugs.gnu.org Sat Jan 15 10:08:26 2022 Received: (at 48463) by debbugs.gnu.org; 15 Jan 2022 15:08:26 +0000 Received: from localhost ([127.0.0.1]:41486 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n8kfK-0004Rz-Ft for submit@debbugs.gnu.org; Sat, 15 Jan 2022 10:08:26 -0500 Received: from mail-wm1-f67.google.com ([209.85.128.67]:35599) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n8kfH-0004RU-3n for 48463@debbugs.gnu.org; Sat, 15 Jan 2022 10:08:25 -0500 Received: by mail-wm1-f67.google.com with SMTP id q9-20020a7bce89000000b00349e697f2fbso12854620wmj.0 for <48463@debbugs.gnu.org>; Sat, 15 Jan 2022 07:08:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:subject:from:to:cc:date:in-reply-to:references :user-agent:mime-version:content-transfer-encoding; bh=islX97OJwrM6m7on2gRO/1jrcbn22Amy5og/OjHQWsQ=; b=Tjm3M6/3FjM4gmslw/5O6IRRca+uObGft9ps1+LdObelg9fz5RdoMYBYoa/cC+Hnwd K0yGjexf19jV5ANhPn4JbQK3JPudlKQWbEBoErZbDpLW0B/mqJQ15qS29sIzmg1GSEGg +k4hxjUuiDF/gT1jJniVSG1KirqlcDXj9GwEVsJTTDpZqVIegy7Y1ZaE2SPoDqFh+xub Z1qOY03W0uGmZmUAzLBZwLnY3CeBusIQKtDil21s3Un5I0yUjmvuBPUhJpiqOkGp731J Hdx2m50HQI1pXTTt9rgqy1SQbGRVv/qyFCVB1zYud2EclOrflgYTFFw89R4olmAZwN+N dVfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=islX97OJwrM6m7on2gRO/1jrcbn22Amy5og/OjHQWsQ=; b=JAJ8q/ibGdlcdl0INhRE99Dvc45LhnRqWR7cgud40n2MK2plPPit1c+Q4IdVtSkVxO PSr0Cd/5L+SlQGpZy0ido09bM10JIQXOrNfMNt5IGfOoXhDyEpcXGrWVE+jNqS33s7P4 GDuhpPTpM4GRNRpot2J216bViKVeo+rbgwrCBcU8bZ7wYzsyPTTZt848k1HlPFJU369u uMJ1h5BOUVxgPkB7bzO2+bVsVy4SMRYQ1YB1u1866rCGfkKtXWmjVBHsJ0Q8MxKa1mhA Te6/DloacrQVZC4pBOW1Qo+QkZgdUAfHvTD3hRNdveEAE1hkOiD5DmHaZkP+kw7lYcBt Zx5w== X-Gm-Message-State: AOAM533hb0oNka/lT1YEBKOhgTbQPA3lgBMjzg7RHe47ph9fz+GdQIkD 4lCjcjVcAoev2xGSjWVSnTI= X-Google-Smtp-Source: ABdhPJzbbyNIW4mbQexSnyXR30EdSwEFIU9AYDGoiOFzEu0FeVL3ZReJBHnXK4Yrs7bxGeNUlKUgQw== X-Received: by 2002:a5d:64aa:: with SMTP id m10mr1591643wrp.295.1642259297083; Sat, 15 Jan 2022 07:08:17 -0800 (PST) Received: from nijino.fritz.box (85-127-52-93.dsl.dynamic.surfer.at. [85.127.52.93]) by smtp.gmail.com with ESMTPSA id l4sm10115356wry.85.2022.01.15.07.08.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 15 Jan 2022 07:08:16 -0800 (PST) Message-ID: <83aba994536bec60f79900d551d4801c967742bd.camel@gmail.com> Subject: Re: [bug#48463] gnu: Add j. From: Liliana Marie Prikler To: elaexuotee@wilsonb.com Date: Sat, 15 Jan 2022 16:08:13 +0100 In-Reply-To: <24ZUUMG4QYSHN.2OS7YAMCKREUA@wilsonb.com> References: <3LOAUDT0FLL4U.2SOD925YP915T@wilsonb.com> <8b853d0585505ce29c9afc638b644fa34805e6c0.camel@student.tugraz.at> <293L8YPQS4CLB.3VK1B1A36XNAY@wilsonb.com> <5d30160bd2a4592459cd407f99cbd3edadb1db1b.camel@student.tugraz.at> <27DCD25Y68ZWJ.2HRC4G65PWIA7@wilsonb.com> <94f4625dcb0479d873cf60449631527e841fd457.camel@gmail.com> <2JQJMV0O718S1.31FZE8GKCTLPF@wilsonb.com> <90704c2259f576a14fb1268219e8c0dc2b3bf289.camel@telenet.be> <2P322C327XW0Q.21O5A4IFGMNDI@wilsonb.com> <72aff035c93f9f91afa54ef5b51c7381b0b02ccb.camel@gmail.com> <3MMTDZQJQ8IR6.334ZWY8AD0487@wilsonb.com> <62d37956f16c08bc4ce26e44da16dce704ddd0f8.camel@gmail.com> <24ZUUMG4QYSHN.2OS7YAMCKREUA@wilsonb.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.42.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: 1.3 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Hi, Am Samstag, dem 15.01.2022 um 23:05 +0900 schrieb elaexuotee@wilsonb.com: > Thanks for staying on top of this patch review. > > Liliana Marie Prikler wrote: > > Hi, > > > > Note, that the current ve [...] Content analysis details: (1.3 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 1.3 RCVD_IN_VALIDITY_RPBL RBL: Relay in Validity RPBL, https://senderscore.org/blocklistlookup/ [209.85.128.67 listed in bl.score.senderscore.com] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (liliana.prikler[at]gmail.com) -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.128.67 listed in list.dnswl.org] -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.85.128.67 listed in wl.mailspike.net] X-Debbugs-Envelope-To: 48463 Cc: Maxime Devos , 48463@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) Hi, Am Samstag, dem 15.01.2022 um 23:05 +0900 schrieb elaexuotee@wilsonb.com: > Thanks for staying on top of this patch review. > > Liliana Marie Prikler wrote: > > Hi, > > > > Note, that the current version still ignores commit.  I've attached > > a proof of concept patch, which fixes that, plus some other minor > > things, but it now uses a pair for version.  Also it's untested, so > > treat with care. > > Oh! I see. You're wanting the version string to have optional > REVISION and COMMIT parts, like `git-version'. That makes a lot of > sense. > > There was a small issue with `jversion->string' in your patch, which > produces MAJOR-REVISION-COMMIT if no MINOR value is provided. I want > to make sure that users can always have specifications like > "jsoftware-j@MAJOR" in their profile manifest, but guix doesn't treat > hyphen as a version separator. > > I just changed the logic to always keep a dot after MAJOR, and then > use hyphens after that. I'm not quite sure if I agree with that decision, but you're right that @MAJOR ought to be supported. How about enforcing that MINOR exists if REVISION and COMMIT are used and setting it to "0" if there hasn't been an "a" beta or release yet? > > > > > Good idea. Upstream's build scripts condition a *lot* of > > > behaviour on he j64avx environment variable, so it might not be > > > straightforward, but I will put this on the to-do list of future > > > improvements. > > > > > > (Note, the code block quoted here got much simplified in the > > > current patch.) > > Reading /proc/cpuinfo is not nice.  Please use (guix cpu), which > > also provides you the flags that you need. > > Oh nice. A new, shiny module! This is exactly what I was looking for > when originally writing the script. Updated. LGTM. > + (native-inputs `(("clang-toolchain" ,clang-toolchain))) > + (inputs (cons* `("libedit" ,libedit) > + `("libomp" ,libomp) > + `("ijconsole" ,(ijconsole)) > + extra-inputs)) My variant already had these translated to the new style. If you're not using old style on purpose – and I don't think you do – you might want to make your life easier by dropping these labels and going with plain (list)s. > + (call-with-output-file "jlibrary/bin/profilex.ijs" > + (lambda (port) > + (display > + (string-join > + (list > + "share=. '/share/j',~ ({.~ _2 { I.@:=&'/') > BINPATH" > + "system=. share,'/system'" > + "tools=. share,'/tools'" > + ;; Upstream defaults to spamming $HOME with > unhidden > + ;; userdata directories. Set this to be > + ;; $HOME/.config/j/ instead > + "'jtype jversion'=. (3&{,{.) <;._2 ,&'/' > 9!:14''" > + "jversion=. ({.~ i.&'-') jversion" > + "user=. home,'/.config/j/',jversion" > + "addons=. user,'/addons'" > + "break=. user,'/break'" > + "config=. user,'/config'" > + "install=. user,'/install'" > + "snap=. user,'/snap'" > + "temp=. user,'/temp'" > + "\n") > + "\n") > + port))) You might want to use an aux-file for that. Name it jsoftware/profile.ijs if it's just a plain file (which I assume). I recently pushed a commit towards renpy which replaces a large format block by fetching an auxiliary file and substitute*, which you can take as reference if you're unsure. Note that renpy still uses old-style inputs, so the assoc-ref makes sense in that case; however, you should be able to also express this pattern in terms of search-input-file somehow (or otherwise express it as gexp). Cheers