From debbugs-submit-bounces@debbugs.gnu.org Thu May 13 23:40:24 2021 Received: (at 48394) by debbugs.gnu.org; 14 May 2021 03:40:25 +0000 Received: from localhost ([127.0.0.1]:44661 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lhOga-0001TL-I1 for submit@debbugs.gnu.org; Thu, 13 May 2021 23:40:24 -0400 Received: from mail-qt1-f175.google.com ([209.85.160.175]:46938) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lhOgZ-0001T8-9m for 48394@debbugs.gnu.org; Thu, 13 May 2021 23:40:24 -0400 Received: by mail-qt1-f175.google.com with SMTP id m13so6155199qtk.13 for <48394@debbugs.gnu.org>; Thu, 13 May 2021 20:40:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=CBKuBMga/zLk8zRiSg7ImjALuAe53rMFWxhMg8GOg44=; b=TTgDk+edr4ZXyEWog4kA/VR5+aWAilA2wxgpbOh7OgcX9t2rKYhbWbp8jMmWcI55j5 xIbHSH22wUtUpf3oIZ/VL2cygETqlZ6Mk1hySdJ2jGV2WBvDbEDg0ZYVCf6nvMyoYBI5 oGUdFn9l9pxHwVsMMFiQ1v91qSz+MSRS+V/lw5xzS3zgt4+G7si1YDuCQciS8hb/+6FM SgMeABy7FkXOgwAxP5JP6uoVZX69NxIM6ApzUgSQQge3N1lo7VJkOaoO+1zyiEojYye3 JDpSecYoQJUAIel5w03QMDbVZiRpAAA++S+UBmiZ00MhENMhxjwzDS0Wc3FLi5vFQ6pH HfnQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=CBKuBMga/zLk8zRiSg7ImjALuAe53rMFWxhMg8GOg44=; b=grRjuXMQm05D8+uV5mBKxEoOEPyeD/UYiaI0bEkz+QTK90k5qZbD19k1/DPd7TP/5v m7a5u7KF7cYhXBfiS6KCQtYBhjaByESPBoSmf50ceiareHGWn+SCXj6HSOCQVoD89UBx 7QudiiqtctAQoxajrfOlKsZiNKUrJjgZyydwyirC+5p61vSyPIjJo4WmsUnNG32okuOL iwkNemJcW1aHceJf4YLkZpRbu8CHqhXUcH3UlAFrapQohnhHkrNloAw7tIn4ytFUpcCk UG18087IA35wHreOe8R+wJNirc3uAyBhyTwmrplwMEp3omAlJfrcuLjO5MetG5pVMZ+E 2GAw== X-Gm-Message-State: AOAM533IBYArel2L3aTyXEWXur0x0UD5jDqzpA1ISgHIfVuTBXrNhNl7 OASmG5Y34edl1oAw8gDthsKTl8xo/9Y= X-Google-Smtp-Source: ABdhPJzyopxOftFupH4McnSPcTucWmrpEaKp3tyHC+WBzTCbu5x4EazgGqzfTFNO+rsDRfKg6ltgnQ== X-Received: by 2002:ac8:1e0f:: with SMTP id n15mr42217194qtl.9.1620963617281; Thu, 13 May 2021 20:40:17 -0700 (PDT) Received: from hurd (dsl-205-236-230-44.b2b2c.ca. [205.236.230.44]) by smtp.gmail.com with ESMTPSA id a185sm3971845qkg.53.2021.05.13.20.40.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 May 2021 20:40:16 -0700 (PDT) From: Maxim Cournoyer To: Raghav Gururajan Subject: Re: bug#48394: [PATCH] gnu: Add cawbird. References: <20210513043153.2545-1-rg@raghavgururajan.name> <20210513220854.15499-1-rg@raghavgururajan.name> Date: Thu, 13 May 2021 23:40:15 -0400 In-Reply-To: <20210513220854.15499-1-rg@raghavgururajan.name> (Raghav Gururajan's message of "Thu, 13 May 2021 18:08:54 -0400") Message-ID: <87sg2q6l0g.fsf_-_@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 48394 Cc: 48394@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hello Raghav, Raghav Gururajan writes: > * gnu/packages/syndication.scm (cawbird): New variable. > --- > gnu/packages/syndication.scm | 92 ++++++++++++++++++++++++++++++++++++ > 1 file changed, 92 insertions(+) > > diff --git a/gnu/packages/syndication.scm b/gnu/packages/syndication.scm > index 3d0b9c39c8..a6bd0c2ce5 100644 > --- a/gnu/packages/syndication.scm > +++ b/gnu/packages/syndication.scm > @@ -59,8 +59,100 @@ > #:use-module (gnu packages web) > #:use-module (gnu packages webkit) > #:use-module (gnu packages xml) > + #:use-module (gnu packages xorg) > #:use-module (srfi srfi-1)) > > +(define-public cawbird > + (package > + (name "cawbird") > + (version "1.4.1") > + (source > + (origin > + (method git-fetch) > + (uri (git-reference > + (url "https://github.com/IBBoard/cawbird") > + (commit (string-append "v"version)))) > + (file-name (git-file-name name version)) > + (sha256 > + (base32 "0lmrgcj1ky1vhzynl36k6ba3ws089x4qdrnkjk3lbr334kicx9na")))) > + (build-system meson-build-system) > + (arguments > + `(#:glib-or-gtk? #t > + #:configure-flags > + ;; Cawbirds's default key and secret for OAuth process with twitter. > + (list > + "-Dconsumer_key_base64=VmY5dG9yRFcyWk93MzJEZmhVdEk5Y3NMOA==" > + > "-Dconsumer_secret_base64=MThCRXIxbWRESDQ2Y0podzVtVU13SGUyVGlCRXhPb3BFRHhGYlB6ZkpybG5GdXZaSjI=") I found that weird to put the secret key only base64-encoded here, but that seems to be how it is intended for the "default key": https://github.com/IBBoard/cawbird/commit/9f0f3201ce866a8ad06f8ec4642790182642bb72. Weird also that it wants it at build time rather than at run time, but hey. > + #:phases > + (modify-phases %standard-phases > + (add-after 'unpack 'disable-failing-tests > + (lambda _ > + ;; These tests require networking. > + (substitute* "tests/meson.build" > + (("[ \t]*.*avatardownload.*$") "") > + (("[ \t]*.*filters.*$") "") > + (("[ \t]*.*friends.*$") "") > + (("[ \t]*.*inlinemediadownloader.*$") "") > + (("[ \t]*.*tweetparsing.*$") "") > + (("[ \t]*.*usercounter.*$") "")))) > + (delete 'check) > + (add-after 'install 'custom-check > + (lambda* (#:key outputs tests? #:allow-other-keys) > + (when tests? > + ;; Tests require a running X server. > + (system "Xvfb :1 +extension GLX &") > + (setenv "DISPLAY" ":1") > + ;; Tests write to $HOME. > + (setenv "HOME" (getcwd)) > + ;; Tests look for gsettings-schemas installed by the package. > + (setenv "XDG_DATA_DIRS" > + (string-append (getenv "XDG_DATA_DIRS") > + ":" (assoc-ref outputs "out") "/share")) > + (invoke "meson" "test")) > + #t)) > + (add-after 'glib-or-gtk-wrap 'wrap-paths > + (lambda* (#:key outputs #:allow-other-keys) > + (let* ((out (assoc-ref outputs "out")) > + (bin (string-append out "/bin/")) > + (gst-plugin-path (getenv "GST_PLUGIN_SYSTEM_PATH")) > + (gi-typelib-path (getenv "GI_TYPELIB_PATH"))) > + (wrap-program (string-append bin "cawbird") > + `("GST_PLUGIN_SYSTEM_PATH" ":" prefix (,gst-plugin-path)) > + `("GI_TYPELIB_PATH" ":" prefix (,gi-typelib-path)))) > + #t))))) > + (native-inputs > + `(("gettext" ,gettext-minimal) > + ("glib:bin" ,glib "bin") > + ("gobject-introspection" ,gobject-introspection) > + ("gtk+:bin" ,gtk+ "bin") > + ("pkg-config" ,pkg-config) > + ("vala" ,vala) > + ("xmllint" ,libxml2) > + ("xorg-server" ,xorg-server-for-tests))) > + (inputs > + `(("glib" ,glib) > + ("gsettings-desktop-schemas" ,gsettings-desktop-schemas) > + ("gspell" ,gspell) > + ("gstreamer" ,gstreamer) > + ("gst-libav" ,gst-libav) > + ("gst-plugins-bad" ,gst-plugins-bad) > + ("gst-plugins-base" ,gst-plugins-base) > + ("gst-plugins-good" ,gst-plugins-good) > + ("gtk+" ,gtk+) > + ("json-glib" ,json-glib) > + ("liboauth" ,liboauth) > + ("libsoup" ,libsoup) > + ("rest" ,rest) > + ("sqlite" ,sqlite) > + ("x11" ,libx11))) > + (propagated-inputs > + `(("dconf" ,dconf))) > + (synopsis "Client for Twitter") > + (description "Cawbird is a twitter app, built with GTK. Perhaps: "Cawbird is a Twitter client that uses the GTK+ toolkit." ? > +the main twitter features.") ^ Twitter I'd expand a bit on what some of these main features might be (text messages, sharing photos, ?). I haven't tested, but after my above comments, if it passes 'guix lint', builds and runs, LGTM. Thank you! Maxim