From debbugs-submit-bounces@debbugs.gnu.org Mon Apr 26 04:40:33 2021 Received: (at 48028) by debbugs.gnu.org; 26 Apr 2021 08:40:33 +0000 Received: from localhost ([127.0.0.1]:44439 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lawnB-0001Sv-Fy for submit@debbugs.gnu.org; Mon, 26 Apr 2021 04:40:33 -0400 Received: from mailrelay.tugraz.at ([129.27.2.202]:60755) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lawn9-0001Sn-AJ for 48028@debbugs.gnu.org; Mon, 26 Apr 2021 04:40:31 -0400 Received: from nijino.local (194-96-9-9.adsl.highway.telekom.at [194.96.9.9]) by mailrelay.tugraz.at (Postfix) with ESMTPSA id 4FTJHv3YRRz3xlN; Mon, 26 Apr 2021 10:40:27 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tugraz.at; s=mailrelay; t=1619426427; bh=VBDLZAtWsEKULvCnfyhKREXbvM6RReaz7ZwxYZirdCM=; h=Subject:From:To:Date:In-Reply-To:References; b=DbCljJ5utwOg2UabwrD3F3RkNW55/7Y5b060wlsNGjj4G2SU4EIkf8A5q/KsCzXnr owhe4v6kzKMBmwE6s9yM7i1zVfPd1G7M7efvbV+IAW1667zZa6HrEz/S+aCSIrLBMW wd1/DaQ1BrSYYnnfVH64V4nXfH9UixRS7+a0YSCM= Message-ID: <73660fda850714bb152afc392df78addecd29932.camel@student.tugraz.at> Subject: Re: [PATCH wip-gnome 5/8] gnu: libsoup: Add missing argument and input. From: Leo Prikler To: Raghav Gururajan , 48028@debbugs.gnu.org Date: Mon, 26 Apr 2021 10:40:26 +0200 In-Reply-To: <20210426081145.28926-5-rg@raghavgururajan.name> References: <20210426081145.28926-1-rg@raghavgururajan.name> <20210426081145.28926-5-rg@raghavgururajan.name> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.34.2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-TUG-Backscatter-control: bt4lQm5Tva3SBgCuw0EnZw X-Spam-Scanner: SpamAssassin 3.003001 X-Spam-Score-relay: -1.9 X-Scanned-By: MIMEDefang 2.74 on 129.27.10.117 X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 48028 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) This headline does not match the contents of the patch. Am Montag, den 26.04.2021, 04:11 -0400 schrieb Raghav Gururajan: > Propagate glib-networking as per .pc file. This looks like it could be its own patch were it not for the fact, that samba needs to be added as well (what for?) > * gnu/packages/gnome.scm (libsoup)[arguments](glib-or-gtk): New > argument. > [inputs]: Add samba. Move glib-networking to ... > [propagated-inputs]: ... here. > --- > gnu/packages/gnome.scm | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm > index 29779c39af..b69980091b 100644 > --- a/gnu/packages/gnome.scm > +++ b/gnu/packages/gnome.scm > @@ -4913,7 +4913,7 @@ libxml to ease remote use of the RESTful API.") > `(#:modules ((guix build utils) > (guix build meson-build-system) > (ice-9 popen)) > - > + #:glib-or-gtk? #t ; To wrap binaries and/or compile schemas That doesn't sound very sure to me. Why are you wrapping binaries and/or compiling schemas? > #:configure-flags '("-Dgtk_doc=true") > #:phases > (modify-phases %standard-phases > @@ -4964,13 +4964,14 @@ libxml to ease remote use of the RESTful > API.") > ;; libsoup-2.4.pc refers to all these. > `(("brotli" ,google-brotli) > ("glib" ,glib) > + ("glib-networking" ,glib-networking) I haven't checked, but if the .pc file says so, so be it. > ("libpsl" ,libpsl) > ("libxml2" ,libxml2) > ("sqlite" ,sqlite) > ("zlib" ,zlib))) > (inputs > - `(("glib-networking" ,glib-networking) > - ("mit-krb5" ,mit-krb5))) > + `(("mit-krb5" ,mit-krb5) > + ("ntlm_auth" ,samba))) Careful with the indentation. > (home-page "https://live.gnome.org/LibSoup/") > (synopsis "GLib-based HTTP Library") > (description Regards, Leo