This headline does not match the contents of the patch. Am Montag, den 26.04.2021, 04:11 -0400 schrieb Raghav Gururajan: > Propagate glib-networking as per .pc file. This looks like it could be its own patch were it not for the fact, that samba needs to be added as well (what for?) > * gnu/packages/gnome.scm (libsoup)[arguments](glib-or-gtk): New > argument. > [inputs]: Add samba. Move glib-networking to ... > [propagated-inputs]: ... here. > --- > gnu/packages/gnome.scm | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm > index 29779c39af..b69980091b 100644 > --- a/gnu/packages/gnome.scm > +++ b/gnu/packages/gnome.scm > @@ -4913,7 +4913,7 @@ libxml to ease remote use of the RESTful API.") > `(#:modules ((guix build utils) > (guix build meson-build-system) > (ice-9 popen)) > - > + #:glib-or-gtk? #t ; To wrap binaries and/or compile schemas That doesn't sound very sure to me. Why are you wrapping binaries and/or compiling schemas? > #:configure-flags '("-Dgtk_doc=true") > #:phases > (modify-phases %standard-phases > @@ -4964,13 +4964,14 @@ libxml to ease remote use of the RESTful > API.") > ;; libsoup-2.4.pc refers to all these. > `(("brotli" ,google-brotli) > ("glib" ,glib) > + ("glib-networking" ,glib-networking) I haven't checked, but if the .pc file says so, so be it. > ("libpsl" ,libpsl) > ("libxml2" ,libxml2) > ("sqlite" ,sqlite) > ("zlib" ,zlib))) > (inputs > - `(("glib-networking" ,glib-networking) > - ("mit-krb5" ,mit-krb5))) > + `(("mit-krb5" ,mit-krb5) > + ("ntlm_auth" ,samba))) Careful with the indentation. > (home-page "https://live.gnome.org/LibSoup/") > (synopsis "GLib-based HTTP Library") > (description Regards, Leo