From debbugs-submit-bounces@debbugs.gnu.org Mon Apr 26 11:54:08 2021 Received: (at 47889) by debbugs.gnu.org; 26 Apr 2021 15:54:08 +0000 Received: from localhost ([127.0.0.1]:46847 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lb3Ym-0006ge-7u for submit@debbugs.gnu.org; Mon, 26 Apr 2021 11:54:08 -0400 Received: from eggs.gnu.org ([209.51.188.92]:43124) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lb3Yj-0006gA-NQ for 47889@debbugs.gnu.org; Mon, 26 Apr 2021 11:54:06 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:58874) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lb3Yd-0002NR-Oh; Mon, 26 Apr 2021 11:53:59 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=58234 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1lb3YZ-0005zb-LT; Mon, 26 Apr 2021 11:53:57 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Mathieu Othacehe Subject: Re: bug#47889: [installer image] grub-install efi fails getting canonical path to /boot/efi on dos-formatted disk References: <20210419092928.p426llfdlvb5ay3z@pelzflorian.localdomain> <878s5a1m9k.fsf@gnu.org> <20210422143651.fwdrrqmcw225eh23@pelzflorian.localdomain> <87im4ds2su.fsf@gnu.org> <87eeeyv49v.fsf@gnu.org> <20210425163412.duj4t4ind5r5tv4x@pelzflorian.localdomain> <878s56uw3c.fsf@gnu.org> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 7 =?utf-8?Q?Flor=C3=A9al?= an 229 de la =?utf-8?Q?R?= =?utf-8?Q?=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Mon, 26 Apr 2021 17:53:54 +0200 In-Reply-To: <878s56uw3c.fsf@gnu.org> (Mathieu Othacehe's message of "Sun, 25 Apr 2021 19:12:39 +0200") Message-ID: <8735vdca99.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 47889 Cc: "pelzflorian \(Florian Pelz\)" , 47889@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi Mathieu, Mathieu Othacehe skribis: >> Can you force GPT also in 2.? All disk partitions get removed anyway. >> Arch wiki says MSDOS layout does not work on all EFI systems >> . > > Well I'm not sure, if someone has an MSDOS partition table with an ESP > partition it wouldn't be a good idea to wipe it. > > The attached patch forces GPT if there's no partition table, and will > preserve/create an ESP partition on an MSDOS/EFI setup. I'm testing it > on various machines, seems to work fine. The patch looks reasonable to me, thanks a lot! (It=E2=80=99s also reasonable to ignore ESP-on-MSDOS IMO.) Ludo=E2=80=99.