From debbugs-submit-bounces@debbugs.gnu.org Sun Apr 18 14:58:55 2021 Received: (at 47874-done) by debbugs.gnu.org; 18 Apr 2021 18:58:55 +0000 Received: from localhost ([127.0.0.1]:47802 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lYCdD-0006vP-Br for submit@debbugs.gnu.org; Sun, 18 Apr 2021 14:58:55 -0400 Received: from wout3-smtp.messagingengine.com ([64.147.123.19]:34721) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lYCdB-0006v9-Bv for 47874-done@debbugs.gnu.org; Sun, 18 Apr 2021 14:58:54 -0400 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.west.internal (Postfix) with ESMTP id DBBC31F81; Sun, 18 Apr 2021 14:58:46 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Sun, 18 Apr 2021 14:58:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=mesmtp; bh=Bxe6HGq8Amyj/jy+iDt4vYmH FDR+kMFCIGXRfuccF1A=; b=PQuNKskYwmj+3OLt6AnqSdAUpmWEm+0KOeVjkLU4 aU2lt5Nw7hBoESYvWQ+FrVG11uZijTPq5CdwJofAljF+99dYT/QHRFKuV5tzG31j /++s0q9XdfVVhYWhbGl/yBp+gw+SbTtRTrmXo9bHcJHl/QNj0LJ1cZamNOGaoSwe UAE= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=Bxe6HG q8Amyj/jy+iDt4vYmHFDR+kMFCIGXRfuccF1A=; b=hPvN5DIzoYtBY3mjE/mM5R vMEc4WY3/9HM6tnSValN0IFEVZNKPCscDmXaBBuBFxC6NfZX8d5U9x+j7bPxnSmc jCwhsS3bUjp42ZipQCctFpDU2vZpMU1p+BrNN9FtFkRXpBHJGAtL8R7gS4oaSJbT ZP41Z7bj6iTYSQF4qoI4hyN/4/GEXQFgNbx1nY5Rm2iAH5cZheEElm4sdi+DBRoz Myr5KkPGonsbxAzCzkPb5bN4Gf+L8X0Pd8+tUa0F5quon1FCLbDXc75vLOYpszcT oJNYIt4mmjN1xl9vqfrj5Wd34nMOcP1SHEbI/eZsbkR5/ZIWGQGumaG35rllWlQw == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrvddtvddgtdefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtuggjsehttdertddttddvnecuhfhrohhmpefnvghoucfh rghmuhhlrghrihcuoehlvghosehfrghmuhhlrghrihdrnhgrmhgvqeenucggtffrrghtth gvrhhnpeetieetieelheejvdffvddtlefhleelhefhffejhfdvveegveelhffgffethffh heenucffohhmrghinhepghhithhhuhgsrdgtohhmpdhgnhhurdhorhhgnecukfhppedutd dtrdduuddrudeiledruddukeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhep mhgrihhlfhhrohhmpehlvghosehfrghmuhhlrghrihdrnhgrmhgv X-ME-Proxy: Received: from localhost (pool-100-11-169-118.phlapa.fios.verizon.net [100.11.169.118]) by mail.messagingengine.com (Postfix) with ESMTPA id F3DFD24005A; Sun, 18 Apr 2021 14:58:45 -0400 (EDT) Date: Sun, 18 Apr 2021 14:58:44 -0400 From: Leo Famulari To: Winter Hound Subject: Re: [bug#47874] gnu: Add kirc. Message-ID: References: <2200031618741698@mail.yandex.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2200031618741698@mail.yandex.com> X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 47874-done Cc: 47874-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On Sun, Apr 18, 2021 at 04:05:11PM +0530, Winter Hound wrote: > From f77caa31810add7bddc321f3980170e494f648d4 Mon Sep 17 00:00:00 2001 > From: WinterHound > Date: Sun, 18 Apr 2021 15:55:23 +0530 > Subject: [PATCH] gnu: Add kirc. Thanks for the patch! I pushed it as 3ddece896fddc38a29ab7e69f7c74f35e5a381fb with the following changes: > + (method url-fetch) > + (uri (string-append "https://github.com/mcpcpc/kirc/archive/refs/tags/" version > + ".tar.gz")) I changed the source to fetch from Git. This type of tarball, which is named "Source code (tar.gz)" on the web site, is generated automatically by GitHub. These auto-generated tarballs actually change over time, as GitHub updates their software. So, we fetch from Git in this case, to ensure that package source will always be bit-identical. > + (synopsis "A tiny IRC client written in POSIX C99") `guix lint kirc` complained that the synopsis starts with an "article", that is, with "A [...]". So I removed it. > + (description > + "A tiny open-source Internet Relay Chat (IRC) client designed with usability and cross-platform compatibility in mind. > +Features > + No dependencies other than a C99 compiler. > + Simple Authentication and Security Layer (SASL) procotol support. > + Client-to-client (CTCP) protocol support. > + Transport Layer Security (TLS) protocol support (via external utilities). > + Simple chat history logging. > + Asynchronous message handling. > + Multi-channel joining at server connection. > + Full support for all RFC 2812 commands. > + Easy customized color scheme definition.") And I removed what I consider "marketing language" from the synopsis and description, and suggested in our manual's Synopses and Descriptions section: https://guix.gnu.org/manual/en/html_node/Synopses-and-Descriptions.html#Synopses-and-Descriptions For example, the word "tiny" is subjective, and I think all programs designed to be "usable" :) Finally, I made sure to import the module (guix utils) in (gnu packages irc). Otherwise, the package fails to build, like this: ------ ice-9/eval.scm:142:16: In procedure compile-top-call: error: cc-for-target: unbound variable hint: Did you forget `(use-modules (guix utils))'? ------ We request that you lint your packages and try building them before submitting your patches. If you don't know how to do that, that's okay! Just say so in the patch submission, and we will be happy to help.