From debbugs-submit-bounces@debbugs.gnu.org Sat Apr 17 19:54:35 2021 Received: (at 47852) by debbugs.gnu.org; 17 Apr 2021 23:54:35 +0000 Received: from localhost ([127.0.0.1]:44934 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lXulm-00030N-Qn for submit@debbugs.gnu.org; Sat, 17 Apr 2021 19:54:35 -0400 Received: from mx1.dismail.de ([78.46.223.134]:28120) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lXulj-000305-31 for 47852@debbugs.gnu.org; Sat, 17 Apr 2021 19:54:33 -0400 Received: from mx1.dismail.de (localhost [127.0.0.1]) by mx1.dismail.de (OpenSMTPD) with ESMTP id 57d27048; Sun, 18 Apr 2021 01:54:21 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=dismail.de; h= mime-version:date:content-type:from:message-id:subject:to:cc :in-reply-to:references; s=20190914; bh=oKsD/E4gzPXcLtXJBAilenxP LAZqd4DrJL7pQcuoiFg=; b=trWqxlJ7g6A+WDW0DrG0D2x614Vbef7fePQRKGfy 2iVSgftGVX+w6+MIsGGkFxs3JUH8IALqabWs+kgHwp6Ot1tTDH04U+ntTU4zA/wB /kIr9G3kJufz6yvu1RgqX2+cHSNbp0Ab1PbmdEF7QTBI4qAEgJXb4IrrAmIXbul0 KWzB5XDLpLtD0N29roPkl4qQrugcNViqhW57Aeh/oiC5NvFlV621ZoLCB2uw3wWy iI8veseoTlIJrxPXlA8SPLRbMpRoq+4qMz9vbPciM8QW1bc5mHLAR/SQ5Sjbh4Jb NzNv9E/5amZsDrTX9mwDMlsf+Dg84lL2A1pV0NYcgMoKww== Received: from smtp2.dismail.de ( [10.240.26.12]) by mx1.dismail.de (OpenSMTPD) with ESMTP id 9dd2a6fb; Sun, 18 Apr 2021 01:54:21 +0200 (CEST) Received: from smtp2.dismail.de (localhost [127.0.0.1]) by smtp2.dismail.de (OpenSMTPD) with ESMTP id d18be565; Sun, 18 Apr 2021 01:54:21 +0200 (CEST) Received: by dismail.de (OpenSMTPD) with ESMTPSA id 3368d096 (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256:NO); Sun, 18 Apr 2021 01:54:20 +0200 (CEST) MIME-Version: 1.0 Date: Sat, 17 Apr 2021 23:54:19 +0000 Content-Type: multipart/mixed; boundary="--=_RainLoop_727_749790000.1618703659" X-Mailer: RainLoop/1.14.0a From: "jgart" Message-ID: Subject: Re: [PATCH] gnu: Add sc-im To: 47852@debbugs.gnu.org In-Reply-To: References: <15c0925b25d9950553a55a4881922cc4@dismail.de> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 47852 Cc: Raghav Gururajan , hello@elenq.tech, Oliver Loaiza , raghavgururajan@disroot.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) ----=_RainLoop_727_749790000.1618703659 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Attached is the updated patch with Ekaitz's suggestions. The linter is no= w a happy gnu!=0A=0A> Also I wouldn't add the whole package in an indepen= dent file.=0A> It may fit better in other of the categories.=0A=0AI thoug= ht of that but I couldn't find a place I was happy with.=0A=0Acalcurse an= d visidata are two other packages that also have their own file. =0A=0AMa= ybe these two packages can be merged in the future with sc-im?=0A=0A> I'm= not sure about all the compile flags=0A> you set, you may be missing som= e interesting plugin support.=0A=0AI left lua support out since that is a= n optional feature.=0A=0AThe sc-im package in nixpkgs also leaves it out:= =0A=0Ahttps://github.com/NixOS/nixpkgs/blob/nixos-unstable/pkgs/applicati= ons/misc/sc-im/default.nix#L35=0A=0AI'm waiting until sc-im has guile sup= port. ;)=0A=0ALet me know if there are any other compiler features you th= ink should be included.=0A=0AI left tmux as the clipboard. It is already = set in the Makefile by default.=0A=0AI'll probably inherit from this pack= age and substitute* for xclip instead, locally.=0A=0ADoes upstream guix p= refer two versions of this package (A version compiled with tmux support = and a version compiled with xclip support)?=0A=0Aall the best,=0A=0Ajgart= =0A=0Aps=0A=0AEkaitz, Saludos desde Miami!=0A=0AVas a venir a el guix mee= tup el pr=C3=B3ximo s=C3=A1bado? Cambi=C3=A9 la hora a una hora normal ;)= =0A=0Ahttps://events.nixnet.services/events/27955ca1-0aee-4ec5-be20-48e6c= 45fd0f6=0A=0A=0A=0AApril 17, 2021 6:22 PM, "ElenQ Technology" wrote:=0A=0A> Hey!=0A> =0A> =E2=80=90=E2=80=90=E2=80=90=E2=80=90= =E2=80=90=E2=80=90=E2=80=90 Original Message =E2=80=90=E2=80=90=E2=80=90= =E2=80=90=E2=80=90=E2=80=90=E2=80=90=0A> On Saturday, April 17, 2021 11:5= 2 PM, jgart wrote:=0A> =0A>> Hi Guix!=0A>> =0A>> Attac= hed is a patch for sc-im, a terminal based spreadsheet program providing = a vim-like=0A>> experience.=0A>> =0A>> I constructed this package startin= g from a template provided by Ekaitz that I found below dating=0A>> from = over a year ago:=0A>> =0A>> https://gitlab.com/ekaitz-zarraga/guix-packag= es/-/blob/master/sc-im.scm=0A>> =0A>> I added Ekaitz as a co-author and a= dded both of our copyrights to the top of the file.=0A>> =0A>> This new v= ersion of sc-im is from 16 days ago.=0A>> =0A>> I'm currently getting the= following two linter warnings:=0A>> =0A>> the source file name should co= ntain the package name=0A>> permanent redirect from https://github.com/an= dmarti1424/sc-im.git to=0A>> https://github.com/andmarti1424/sc-im=0A>> = =0A>> Any suggestions for what I need to adjust to make those pass?=0A>> = =0A>> best regards,=0A>> =0A>> jgart=0A> =0A> I didn't expect this!=0A> = =0A> My original package was broken, but I left it in my repo so IDK=0A> = if taking that as a base was a good idea.=0A> I was trying to package a m= ore complete solution and I left=0A> the package broken... =0A> =0A> I'm = taking a look to it.=0A> =0A> The first issue related with the name of th= e package is this:=0A> =0A> ```=0A> guix/gnu/packages/sc-im.scm:41:14: sc= -im@0.8.1: the source file name should contain the package=0A> name=0A> `= ``=0A> =0A> In order to solve this you can use this in the origin desc:= =0A> =0A> ```=0A> (file-name (git-file-name name version))=0A> ```=0A> = =0A> This is going to clone the repo to an specific filename that=0A> mat= ches Guix's naming style and it's going to remove the=0A> warning.=0A> = =0A> The second:=0A> =0A> ```=0A> gnu/packages/sc-im.scm:41:14: sc-im@0.8= .1: permanent redirect from=0A> https://github.com/andmarti1424/sc-im.git= to https://github.com/andmarti1424/sc-im=0A> ```=0A> =0A> Just change th= e url by the other and you're done.=0A> =0A> =0A> HTH!=0A> =0A> Thanks fo= r keeping my name there, but you can clear it with=0A> no issue, this is = all your merit, my man.=0A> =0A> Best,=0A> Ekaitz ----=_RainLoop_727_749790000.1618703659 Content-Type: application/octet-stream; name="0001-gnu-Add-sc-im.patch" Content-Disposition: attachment; filename="0001-gnu-Add-sc-im.patch" Content-Transfer-Encoding: base64 RnJvbSAwODA5MTY3Y2UyMmU0ZDEwZmExMTNiYjkyNzZiMTkxY2ZjNDU4ZGEzIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBqZ2FydCA8amdhcnRAZGlzbWFpbC5kZT4KRGF0ZTog U2F0LCAxNyBBcHIgMjAyMSAxNzo0MzoxNiAtMDQwMApTdWJqZWN0OiBbUEFUQ0hdIGdudTog QWRkIHNjLWltLgoKICAgICogZ251L3BhY2thZ2VzL3Zpc2lkYXRhLnNjbTogTmV3IGZpbGUu CiAgICAqIGdudS9sb2NhbC5tayAoR05VX1NZU1RFTV9NT0RVTEVTKTogQWRkIGl0LgoKICAg IENvLWF1dGhvcmVkLWJ5OiBFa2FpdHogWmFycmFnYSA8ZWthaXR6QGVsZW5xLnRlY2g+Ci0t LQogZ251L2xvY2FsLm1rICAgICAgICAgICB8ICAxICsKIGdudS9wYWNrYWdlcy9zYy1pbS5z Y20gfCA4MCArKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysKIDIg ZmlsZXMgY2hhbmdlZCwgODEgaW5zZXJ0aW9ucygrKQogY3JlYXRlIG1vZGUgMTAwNjQ0IGdu dS9wYWNrYWdlcy9zYy1pbS5zY20KCmRpZmYgLS1naXQgYS9nbnUvbG9jYWwubWsgYi9nbnUv bG9jYWwubWsKaW5kZXggNTBiMTFhOGNhMi4uYWRlOGI0MDBkMCAxMDA2NDQKLS0tIGEvZ251 L2xvY2FsLm1rCisrKyBiL2dudS9sb2NhbC5tawpAQCAtNDk2LDYgKzQ5Niw3IEBAIEdOVV9T WVNURU1fTU9EVUxFUyA9CQkJCVwKICAgJUQlL3BhY2thZ2VzL3Nhd2Zpc2guc2NtCQkJXAog ICAlRCUvcGFja2FnZXMvc2Nhbm5lci5zY20JCQlcCiAgICVEJS9wYWNrYWdlcy9zY2hlbWUu c2NtCQkJXAorICAlRCUvcGFja2FnZXMvc2MtaW0uc2NtCQkJXAogICAlRCUvcGFja2FnZXMv c2NyZWVuLnNjbQkJCVwKICAgJUQlL3BhY2thZ2VzL3NjcmlidXMuc2NtCQkJXAogICAlRCUv cGFja2FnZXMvc2NzaS5zY20JCQkJXApkaWZmIC0tZ2l0IGEvZ251L3BhY2thZ2VzL3NjLWlt LnNjbSBiL2dudS9wYWNrYWdlcy9zYy1pbS5zY20KbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5k ZXggMDAwMDAwMDAwMC4uM2MxM2Q2MTE0OAotLS0gL2Rldi9udWxsCisrKyBiL2dudS9wYWNr YWdlcy9zYy1pbS5zY20KQEAgLTAsMCArMSw4MCBAQAorOzs7IEdOVSBHdWl4IC0tLSBGdW5j dGlvbmFsIHBhY2thZ2UgbWFuYWdlbWVudCBmb3IgR05VCis7OzsgQ29weXJpZ2h0IMKpIDIw MjAgRWthaXR6IFphcnJhZ2EgPGVrYWl0ekBlbGVucS50ZWNoPgorOzs7IENvcHlyaWdodCDC qSAyMDIxIGpnYXJ0IDxqZ2FydEBkaXNtYWlsLmRlPgorOzs7Cis7OzsgVGhpcyBmaWxlIGlz IHBhcnQgb2YgR05VIEd1aXguCis7OzsKKzs7OyBHTlUgR3VpeCBpcyBmcmVlIHNvZnR3YXJl OyB5b3UgY2FuIHJlZGlzdHJpYnV0ZSBpdCBhbmQvb3IgbW9kaWZ5IGl0Cis7OzsgdW5kZXIg dGhlIHRlcm1zIG9mIHRoZSBHTlUgR2VuZXJhbCBQdWJsaWMgTGljZW5zZSBhcyBwdWJsaXNo ZWQgYnkKKzs7OyB0aGUgRnJlZSBTb2Z0d2FyZSBGb3VuZGF0aW9uOyBlaXRoZXIgdmVyc2lv biAzIG9mIHRoZSBMaWNlbnNlLCBvciAoYXQKKzs7OyB5b3VyIG9wdGlvbikgYW55IGxhdGVy IHZlcnNpb24uCis7OzsKKzs7OyBHTlUgR3VpeCBpcyBkaXN0cmlidXRlZCBpbiB0aGUgaG9w ZSB0aGF0IGl0IHdpbGwgYmUgdXNlZnVsLCBidXQKKzs7OyBXSVRIT1VUIEFOWSBXQVJSQU5U WTsgd2l0aG91dCBldmVuIHRoZSBpbXBsaWVkIHdhcnJhbnR5IG9mCis7OzsgTUVSQ0hBTlRB QklMSVRZIG9yIEZJVE5FU1MgRk9SIEEgUEFSVElDVUxBUiBQVVJQT1NFLiAgU2VlIHRoZQor Ozs7IEdOVSBHZW5lcmFsIFB1YmxpYyBMaWNlbnNlIGZvciBtb3JlIGRldGFpbHMuCis7OzsK Kzs7OyBZb3Ugc2hvdWxkIGhhdmUgcmVjZWl2ZWQgYSBjb3B5IG9mIHRoZSBHTlUgR2VuZXJh bCBQdWJsaWMgTGljZW5zZQorOzs7IGFsb25nIHdpdGggR05VIEd1aXguICBJZiBub3QsIHNl ZSA8aHR0cDovL3d3dy5nbnUub3JnL2xpY2Vuc2VzLz4uCisKKyhkZWZpbmUtbW9kdWxlIChn bnUgcGFja2FnZXMgc2MtaW0pCisgICM6dXNlLW1vZHVsZSAoZ3VpeCBwYWNrYWdlcykKKyAg Izp1c2UtbW9kdWxlIChndWl4IGdpdC1kb3dubG9hZCkKKyAgIzp1c2UtbW9kdWxlIChndWl4 IGRvd25sb2FkKQorICAjOnVzZS1tb2R1bGUgKGd1aXggYnVpbGQtc3lzdGVtIGdudSkKKyAg Izp1c2UtbW9kdWxlICgoZ3VpeCBsaWNlbnNlcykgIzpwcmVmaXggbGljZW5zZTopCisgICM6 dXNlLW1vZHVsZSAoZ251IHBhY2thZ2VzKQorICAjOnVzZS1tb2R1bGUgKGdudSBwYWNrYWdl cyBiYXNlKQorICAjOnVzZS1tb2R1bGUgKGdudSBwYWNrYWdlcyBwa2ctY29uZmlnKQorICAj OnVzZS1tb2R1bGUgKGdudSBwYWNrYWdlcyBtYXRocykKKyAgIzp1c2UtbW9kdWxlIChnbnUg cGFja2FnZXMgc3RhdGlzdGljcykKKyAgIzp1c2UtbW9kdWxlIChnbnUgcGFja2FnZXMgeG1s KQorICAjOnVzZS1tb2R1bGUgKGdudSBwYWNrYWdlcyBjb21wcmVzc2lvbikKKyAgIzp1c2Ut bW9kdWxlIChnbnUgcGFja2FnZXMgYmlzb24pCisgICM6dXNlLW1vZHVsZSAoZ251IHBhY2th Z2VzIG5jdXJzZXMpKQorCisoZGVmaW5lLXB1YmxpYyBzYy1pbQorICAobGV0ICgoY29tbWl0 LXJlZiAiNzVhZTM4MDY4NDQ4MjFjYmExYjJlM2ZkYjkyMzdkNzM3OTQ0ZTg1MCIpKQorICAg IChwYWNrYWdlCisgICAgICAobmFtZSAic2MtaW0iKQorICAgICAgKHZlcnNpb24gIjAuOC4x IikKKyAgICAgIChzb3VyY2UgKG9yaWdpbgorICAgICAgICAgICAgICAgIChtZXRob2QgZ2l0 LWZldGNoKQorICAgICAgICAgICAgICAgICh1cmkKKyAgICAgICAgICAgICAgICAgIChnaXQt cmVmZXJlbmNlCisgICAgICAgICAgICAgICAgICAgICh1cmwgImh0dHBzOi8vZ2l0aHViLmNv bS9hbmRtYXJ0aTE0MjQvc2MtaW0iKQorICAgICAgICAgICAgICAgICAgICAoY29tbWl0IGNv bW1pdC1yZWYpKSkKKyAgICAgICAgICAgICAgICAgICAgKGZpbGUtbmFtZSAoZ2l0LWZpbGUt bmFtZSBuYW1lIHZlcnNpb24pKQorICAgICAgICAgICAgICAgIChzaGEyNTYKKyAgICAgICAg ICAgICAgICAgIChiYXNlMzIKKyAgICAgICAgICAgICAgICAgICAgIjFpMXlxNW1oOWQ3eWkx YmtnYXE0cDFscjh6cnhobHZxbWpuajMzd21nNXY2dnBmaW0xaDAiKSkpKQorICAgICAgKGJ1 aWxkLXN5c3RlbSBnbnUtYnVpbGQtc3lzdGVtKQorICAgICAgKGFyZ3VtZW50cworICAgICAg ICA7OyBUaGVyZSBhcmUgbm8gdGVzdHMgYXQgdGhlIG1vbWVudC4KKyAgICAgICAgOzsgaHR0 cHM6Ly9naXRodWIuY29tL2FuZG1hcnRpMTQyNC9zYy1pbS9pc3N1ZXMvNTM3CisgICAgICAg IDs7IGh0dHBzOi8vZ2l0aHViLmNvbS9hbmRtYXJ0aTE0MjQvc2MtaW0vcHVsbC8zODUKKyAg ICAgICAgYCgjOnRlc3RzPyAjZgorICAgICAgICAgICM6bWFrZS1mbGFncyAobGlzdCAiLUMi ICJzcmMiICJDQz1nY2MiCisgICAgICAgICAgICAgICAgICAgICAgICAgKHN0cmluZy1hcHBl bmQgInByZWZpeD0iIChhc3NvYy1yZWYgJW91dHB1dHMgIm91dCIpKSkKKyAgICAgICAgICAj OnBoYXNlcworICAgICAgICAgICAgKG1vZGlmeS1waGFzZXMKKyAgICAgICAgICAgICAgICVz dGFuZGFyZC1waGFzZXMKKyAgICAgICAgICAgICAgICAgKGRlbGV0ZSAnY29uZmlndXJlKSkp KQorICAgICAgKGlucHV0cworICAgICAgICBgKCgiZ251cGxvdCIgLGdudXBsb3QpCisgICAg ICAgICAgKCJsaWJ4bHMiICxsaWJ4bHMpCisgICAgICAgICAgKCJsaWJ4bHN4d3JpdGVyIiAs bGlieGxzeHdyaXRlcikKKyAgICAgICAgICAoImxpYnhtbDIiICxsaWJ4bWwyKQorICAgICAg ICAgICgibGliemlwIiAsbGliemlwKQorICAgICAgICAgICgibmN1cnNlcyIgLG5jdXJzZXMp KSkKKyAgICAgIChuYXRpdmUtaW5wdXRzCisgICAgICAgIGAoKCJwa2ctY29uZmlnIiAscGtn LWNvbmZpZykKKyAgICAgICAgICAoIndoaWNoIiAsd2hpY2gpCisgICAgICAgICAgKCJiaXNv biIgLGJpc29uKSkpCisgICAgICAoc3lub3BzaXMgIlNwcmVhZHNoZWV0IHByb2dyYW0gd2l0 aCB2aW0tbGlrZSBrZXliaW5kaW5ncyIpCisgICAgICAoZGVzY3JpcHRpb24KKyAiQGNvZGV7 c2MtaW19IGlzIGEgaGlnaGx5IGNvbmZpZ3VyYWJsZSBzcHJlYWRzaGVldCBwcm9ncmFtCisg cHJvdmlkaW5nIGEgdmltLWxpa2UgZXhwZXJpZW5jZS4gIEBjb2Rle3NjLWltfSBzdXBwb3J0 cyBAe2dudXBsb3R9IGludGVyYWN0aW9uLAorIGZ1bmN0aW9ucyBmb3Igc29ydGluZyBhbmQg ZmlsdGVyaW5nLCAyNTYgY29sb3Igc3VwcG9ydCwgYW5kIG11Y2ggbW9yZS4iKQorICAgICAg KGhvbWUtcGFnZSAiaHR0cHM6Ly9naXRodWIuY29tL2FuZG1hcnRpMTQyNC9zYy1pbSIpCisg ICAgICAobGljZW5zZSBsaWNlbnNlOmJzZC00KSkpKQotLSAKMi4yOS4zCgo= ----=_RainLoop_727_749790000.1618703659--