From debbugs-submit-bounces@debbugs.gnu.org Thu May 06 07:03:34 2021 Received: (at 47824) by debbugs.gnu.org; 6 May 2021 11:03:34 +0000 Received: from localhost ([127.0.0.1]:37387 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lebn4-00057R-20 for submit@debbugs.gnu.org; Thu, 06 May 2021 07:03:34 -0400 Received: from mailrelay.tugraz.at ([129.27.2.202]:12263) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lebn0-00057L-9E for 47824@debbugs.gnu.org; Thu, 06 May 2021 07:03:31 -0400 Received: from nijino.local (91-114-247-246.adsl.highway.telekom.at [91.114.247.246]) by mailrelay.tugraz.at (Postfix) with ESMTPSA id 4FbW0F5mzWz3xMn; Thu, 6 May 2021 13:03:25 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tugraz.at; s=mailrelay; t=1620299006; bh=Vcvk4ora6rVw/se4HofFwBx4KW4I26QpXrP7ETtsKyQ=; h=Subject:From:To:Cc:Date:In-Reply-To:References; b=r/mpms/Mswks4EwN6jecxnfCj5HZIHeag6MPywcNuQRgOnyVBXkSkNLHqWZVC9KUF sboKe3PEe8KCQw+WVjaXGshch3fZtabo2CIr0t2mD8B8AwT2qsCpE4TPAIelxKu/Nj vmteJdN5pnDHp6x4nt/gJ+G5xEEjAI1QclDTLnyU= Message-ID: <82ad8a0c2757ff74694e8c83eb528cf84c59855e.camel@student.tugraz.at> Subject: Re: bug#47824: [PATCH 0/3] Happy hacking in the Spring 2021 LGJ From: Leo Prikler To: Ludovic =?ISO-8859-1?Q?Court=E8s?= Date: Thu, 06 May 2021 13:03:24 +0200 In-Reply-To: <875yzwgmmg.fsf@gnu.org> References: <20210419081744.7247-1-leo.prikler@student.tugraz.at> <20210419081744.7247-3-leo.prikler@student.tugraz.at> <874kfhjmfd.fsf_-_@gnu.org> <867322166b5492fe1964df02db2b4d148ade29dd.camel@student.tugraz.at> <875yzwgmmg.fsf@gnu.org> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.34.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-TUG-Backscatter-control: bt4lQm5Tva3SBgCuw0EnZw X-Spam-Scanner: SpamAssassin 3.003001 X-Spam-Score-relay: -1.9 X-Scanned-By: MIMEDefang 2.74 on 129.27.10.117 X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 47824 Cc: 47824@debbugs.gnu.org, efraim@flashner.co.il X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Am Donnerstag, den 06.05.2021, 12:52 +0200 schrieb Ludovic Courtès: > Hi, > > Leo Prikler skribis: > > > Am Mittwoch, den 05.05.2021, 16:16 +0200 schrieb Ludovic Courtès: > > > Hi Leo, > > > > > > On a cursory look, all three patches LGTM. > > > > > > One nit: > > > > > > > + "exec " > > > > + (assoc-ref inputs "guile-runtime") > > > > + "/bin/guile " args))) > > > > > > [...] > > > > > > > ("guile" ,guile-3.0) > > > > ("pkg-config" ,pkg-config) > > > > ("texinfo" ,texinfo))) > > > > - (propagated-inputs > > > > - `(("guile-sdl2" ,guile3.0-sdl2))) > > > > + (inputs > > > > + `(("guile-sdl2" ,guile3.0-sdl2) > > > > + ("guile-runtime" ,guile-3.0))) > > > > > > I think it’s best to not play trick with labels, and to always > > > use > > > the > > > package name as the label (to facilitate migration on the day > > > where > > > we > > > get rid of labels, who knows…). > > > > > > A common pattern for the case above is to provide “guile” both as > > > native > > > input and input, and to write: > > > > > > (assoc-ref (or native-inputs inputs) "guile") > > What I'm doing here is the exact opposite. I don't want the > > omnipresent native-input guile to shadow the guile I use as input, > > In that case, you can unconditionally do: > > (assoc-ref inputs "guile") > > Unless I’m mistaken, it won’t be shadowed by the native input “guile” > when cross-compiling. > > Or am I missing something? Perhaps it's an implementation detail, that when performing native builds, inputs are merged as (append inputs native-inputs), but they could as well be (append native-inputs inputs). I'd have to check, and I'm not sure whether I want to rely on that detail. Regards, Leo