From debbugs-submit-bounces@debbugs.gnu.org Mon Apr 12 15:42:13 2021 Received: (at 47730) by debbugs.gnu.org; 12 Apr 2021 19:42:13 +0000 Received: from localhost ([127.0.0.1]:58141 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lW2Rp-0004N8-BQ for submit@debbugs.gnu.org; Mon, 12 Apr 2021 15:42:13 -0400 Received: from andre.telenet-ops.be ([195.130.132.53]:39308) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lW2Rn-0004Mz-9q for 47730@debbugs.gnu.org; Mon, 12 Apr 2021 15:42:12 -0400 Received: from ptr-bvsjgyjmffd7q9timvx.18120a2.ip6.access.telenet.be ([IPv6:2a02:1811:8c09:9d00:aaf1:9810:a0b8:a55d]) by andre.telenet-ops.be with bizsmtp id rvi9240080mfAB401vi9p5; Mon, 12 Apr 2021 21:42:09 +0200 Message-ID: <527b2cd7e2b325ea88fe34ebed0e158e4a9fc518.camel@telenet.be> Subject: Re: [bug#47730] [PATCH 4/4] gnu: Add watson. From: Maxime Devos To: Sebastian Gibb , 47730@debbugs.gnu.org Date: Mon, 12 Apr 2021 21:42:08 +0200 In-Reply-To: <20210412154852.10255-4-mail@sebastiangibb.de> References: <20210412154852.10255-1-mail@sebastiangibb.de> <20210412154852.10255-4-mail@sebastiangibb.de> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-Is9M/HFkwKwTGUJc5tkH" User-Agent: Evolution 3.34.2 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r21; t=1618256529; bh=8tgh3Goz/Bgv54xH3Ku1eFuEIb5IDJz4HC3OoCQrm0o=; h=Subject:From:To:Date:In-Reply-To:References; b=XTUoZjF3rl0mHkX5YSdKaMzJycj976o+b8XT3A3nyHbO1wVwUUpCovzZ395rSgQj4 HvuUY6r8rXbiNuddeRfTueUgVzgAJNuH++rJRvd+KL7s2XJW9ME9fL0eCXcVi7eiWz 1rLjLGwoppeaFr8ToKfH7o7hvesOc1apDoUAWpjPTCZ4PcnYMqnJiDzQ06Xv0BAsTQ EiiATYsJcWRsp+hR1Jp9WDRohuHxmVSu/jbpPEuxQZgVR3zReBesVNTpzcQ8DkULot hEnPZbPXwXMxDrk6fQw05hBP9gyGPht3hO44HlKtKAae8dhCIQNSTevDZ4lJqam+Bk 0mgNJyjYj5g3g== X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 47730 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-Is9M/HFkwKwTGUJc5tkH Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, 2021-04-12 at 17:48 +0200, Sebastian Gibb via Guix-patches via wrot= e: > [...] > + `(#:phases (modify-phases %standard-phases > + (replace 'check > + (lambda _ > + (invoke "pytest") > + #t))))) Phases do not need to return #t anymore. The warning that results if a phase doesn't return #t has been removed on the core-updates branch, which will at some point in time be merged in master. =46rom a cursory look, I don't see any other problems, except perhaps ... > + (synopsis > + "Command-line time tracker") I don't see a reason for a newline afer 'synopsis' here. Thanks, Maxime. --=-Is9M/HFkwKwTGUJc5tkH Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYHSikRccbWF4aW1lZGV2 b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7p7bAP9dy2BxTacefGfBldOMrPdPAvq2 r8+KQBhp2X2MiMWL+QEAnhj6R4nS4rjxES3K4hp8424e38R3UT/csyD8cgfoUgw= =fy6c -----END PGP SIGNATURE----- --=-Is9M/HFkwKwTGUJc5tkH--