From debbugs-submit-bounces@debbugs.gnu.org Wed Apr 14 00:00:53 2021 Received: (at 47615) by debbugs.gnu.org; 14 Apr 2021 04:00:53 +0000 Received: from localhost ([127.0.0.1]:33101 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lWWhx-0007PY-0D for submit@debbugs.gnu.org; Wed, 14 Apr 2021 00:00:53 -0400 Received: from mail-pf1-f182.google.com ([209.85.210.182]:34438) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lWWhv-0007PM-PZ for 47615@debbugs.gnu.org; Wed, 14 Apr 2021 00:00:52 -0400 Received: by mail-pf1-f182.google.com with SMTP id 10so3969873pfl.1 for <47615@debbugs.gnu.org>; Tue, 13 Apr 2021 21:00:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=i2hG38kWsYZn9zPiToBIMW/zs7zLRwK+ds3YUEH4fRY=; b=uzpKpcGbP8oqnR5VcZ7k5CnIUtcooH1VKy1kshJNg6fMPDmqZlNmxwZEfWsHR0VnYz oJU7t05xUsPJBy53k/NxLb+GZ+KUEs/iUtl9u6xfbhhsX6dOrAfwjriihjLP5jB3S8dM EKQycpayFTEJwpwJ6GdbEw2Z+g1cY5fK79emb7xv3F1Wzw6pr5ifKa9vqw+J6fcZbmjY c+nOdUvDLl1u5g3bmWNuAyVnUHqAkNSir/D7qRK+sUIhZkn9jA6AVnEfCkKf3eXEq7Yr sXXyqy9/Ij9POOLOVlicc3MkcvYiKS0gB9oOUlMLv02Jo8gRY9b7VEBzCYwCmpxZUTdd Y1XQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=i2hG38kWsYZn9zPiToBIMW/zs7zLRwK+ds3YUEH4fRY=; b=TNHMEsPNCILFlJpQGPvYyvQeNmRxu/WBzs3JA7kOi4gCFA+J6sW8KOwNYR0ahT6jiW FU9jBeHrXviK9BftgqB7NSWkxgH/Mn4CXGmROFp2AZVbrqi0een/TdK+9lzMOBg5m5ei GSumVLSdtGzRbBPmX1MYINpZwZzv+s0nfKfttrpLLjmQjQqd/Tcd4SkRikqx18xzLkHa Jf/PiOg+XcxaHwVmj+7KzX5Ngn+RsriMK8K4rs40+cndq+nSslx/yIM5LcdE8gTm9qv7 PFtKt+e6PCwMb3EHBI1x+wlXCTtEZFna5UU2skQ+Wl8ds4v/drXxS2IE3cZYE+dwCKYA IR3Q== X-Gm-Message-State: AOAM531gzB9OLSIzZqX9kwEXPS9E5A4mXrL2uftksubXlNRbDNlOvoAI qpPHGW5NZcZ+KrGn1YUrAE8= X-Google-Smtp-Source: ABdhPJyLeVxj/QJZ5x920DADCIntsp+DHay2BPVViJpACGtKLDTEm8bTGZoRbhCL/u1SNfVnqr8DKA== X-Received: by 2002:a65:5849:: with SMTP id s9mr36667802pgr.309.1618372845728; Tue, 13 Apr 2021 21:00:45 -0700 (PDT) Received: from garuda-lan (c-24-18-44-142.hsd1.wa.comcast.net. [24.18.44.142]) by smtp.gmail.com with ESMTPSA id q13sm13600599pfc.86.2021.04.13.21.00.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Apr 2021 21:00:44 -0700 (PDT) From: Chris Marusich To: Efraim Flashner Subject: Re: bug#47615: [PATCH 2/9] gnu: guile-3.0: Fix building on powerpc-linux. References: Date: Tue, 13 Apr 2021 21:00:43 -0700 In-Reply-To: (Efraim Flashner's message of "Tue, 6 Apr 2021 15:32:46 +0300") Message-ID: <87h7k91pn8.fsf_-_@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 47615 Cc: guix-devel@gnu.org, 47615@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Efraim Flashner writes: > * gnu/packages/guile.scm (guile-3.0)[arguments]: On powerpc add two > phases to adjust for 32-bit big-endian systems. > --- > gnu/packages/guile.scm | 21 ++++++++++++++++++++- > 1 file changed, 20 insertions(+), 1 deletion(-) > > diff --git a/gnu/packages/guile.scm b/gnu/packages/guile.scm > index f63322794d..dca1b1c16f 100644 > --- a/gnu/packages/guile.scm > +++ b/gnu/packages/guile.scm > @@ -305,7 +305,26 @@ without requiring the source code to be rewritten.") > (substitute-keyword-arguments (package-arguments guile-2.2) > ((#:configure-flags flags ''()) > `(cons "--disable-jit" ,flags))) > - (package-arguments guile-2.2))) > + (if (string-prefix? "powerpc-" (%current-system)) > + (substitute-keyword-arguments (package-arguments guile-2.2) > + ((#:phases phases) > + `(modify-phases ,phases > + (add-after 'unpack 'adjust-bootstrap-flags > + (lambda _ > + ;; Upstream not yet notified about suggested soluti= on. > + ;; See existing bug reports: > + ;; https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D= 45214 > + ;; https://bugs.debian.org/cgi-bin/bugreport.cgi?bu= g=3D977223 > + (substitute* "bootstrap/Makefile.in" > + (("^GUILE_OPTIMIZATIONS.*") > + "GUILE_OPTIMIZATIONS =3D -O1 -Oresolve-primitive= s -Ocps\n")) > + #t)) > + (add-after 'unpack 'remove-failing-tests > + (lambda _ > + ;; TODO: Discover why this test fails on powerpc-li= nux > + (delete-file "test-suite/standalone/test-out-of-mem= ory") > + #t))))) > + (package-arguments guile-2.2)))) > (native-search-paths > (list (search-path-specification > (variable "GUILE_LOAD_PATH") Generally this looks reasonable. I understand 3 weeks is a long iteration time! I think it's OK to proceed if it works for bootstrapping other software on this platform. Especially since the change is isolated to just powerpc-linux. Has the Guile test failure been reported upstream? =2D-=20 Chris --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQJJBAEBCAAzFiEEy/WXVcvn5+/vGD+x3UCaFdgiRp0FAmB2aOsVHGNtbWFydXNp Y2hAZ21haWwuY29tAAoJEN1AmhXYIkadyJoP/1V+MT08z3SWPt06mleDHsQWRq/N JilsNkm32YfIVtHwiJ0SCwai9RqeErNf4wINfd4CxydxxEn1OBa5Wq9i/sd9vcdL dOE/k414UhxB8edKJVXH8pMsEyaXf/4D+tdWhdL/8As9x1Brr+FX/KH94oSE0cNh K5mnnu/eU/WIxIajqtsvGbuxLHx/ZsOzfTagb/8c/BUaL8CC8a8kp5Oh++eIioz6 +cU7Bp76rW2NH2TGdAhWuFvapMd1GApN7RJsFvPtKkF2gVvF1QeCJDYOxCZq9awG 3RCVGoGQoyZpJsLh2NruspO5NqoNIfLYGoh7FQraS/+/aoFoNkqW9BPNe8VgQI1h 28N3OrFZ0vxJ7pQGGQ5A5+ZzSxCY0E49s5JXARBWV7h55WvY8RyX+ASbKdHmnMzr FVdktwIYEjZUw2yr8djXm6s3vJMkognT+fshhofJfJiTVsZ6Vj9C3EocDtMXM/aE Ndwe9B/+imID0Vpa4glLzfLBzEQJ60z8CFI+0LMpMALT1rgb5/n9FUUC6zBnMi8+ 71A5X9F7y3uuDW48RRVyF9IgC5z0CQAwWsrbMJiQkw+Wm8Vn55Ufd7j5LnW8hxxs HbBYNmoMdk+e8+ZmAZtKZG8RNh+YKs9OWHBbi4aB8aMYgLk83II00fVD2usCukLt an2gChCUOFj/yPpk =qvAg -----END PGP SIGNATURE----- --=-=-=--