From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 01 10:49:34 2021 Received: (at 47539) by debbugs.gnu.org; 1 Apr 2021 14:49:35 +0000 Received: from localhost ([127.0.0.1]:58235 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lRyda-0002G0-N8 for submit@debbugs.gnu.org; Thu, 01 Apr 2021 10:49:34 -0400 Received: from h87-96-130-155.cust.a3fiber.se ([87.96.130.155]:34490 helo=mail.yoctocell.xyz) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lRydY-0002Fl-VK for 47539@debbugs.gnu.org; Thu, 01 Apr 2021 10:49:33 -0400 From: Xinglu Chen DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=yoctocell.xyz; s=mail; t=1617288564; bh=XJikYa0FB5YYYQgbIgx63IYeDV/Ol33jZoRODUXhlXI=; h=From:To:Subject:In-Reply-To:References:Date; b=ha4WoTfd4StXbWooYNyKI4+bENhGiRWYn8z9QXInwGuuzUo/57f7CJI/7vW2BSF66 7J0eBx4uWSNGXaXzgWe7KiOKgP8zyaeW0fe+obklGImOwN0O63qBs/FxowEjLXiTiY sD4tdkyppAM9qcynWicDxFLdFU8yQrw/b+jOKPZE= To: Leo Prikler , 47539@debbugs.gnu.org Subject: Re: [PATCH 00/28] Add gh and dependencies In-Reply-To: <7f41ded1648030ed8f4db3165bfe4ccb2cb6b2a9.camel@student.tugraz.at> References: <7f41ded1648030ed8f4db3165bfe4ccb2cb6b2a9.camel@student.tugraz.at> Date: Thu, 01 Apr 2021 16:49:23 +0200 Message-ID: <87czve3vrg.fsf@yoctocell.xyz> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 2.9 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: On Thu, Apr 01 2021, Leo Prikler wrote: > Hi, > > Am Donnerstag, den 01.04.2021, 09:51 +0200 schrieb Xinglu Chen: >> This patchset adds the 'gh' package, a CLI interface to GitHub. The >> Go importer did most of the work. :) > I am not expe [...] Content analysis details: (2.9 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 2.0 PDS_OTHER_BAD_TLD Untrustworthy TLDs [URI: yoctocell.xyz (xyz)] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.4 RDNS_DYNAMIC Delivered to internal network by host with dynamic-looking rDNS 0.5 FROM_SUSPICIOUS_NTLD From abused NTLD X-Debbugs-Envelope-To: 47539 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 2.9 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: On Thu, Apr 01 2021, Leo Prikler wrote: > Hi, > > Am Donnerstag, den 01.04.2021, 09:51 +0200 schrieb Xinglu Chen: >> This patchset adds the 'gh' package, a CLI interface to GitHub. The >> Go importer did most of the work. :) > I am not expe [...] Content analysis details: (2.9 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 2.0 PDS_OTHER_BAD_TLD Untrustworthy TLDs [URI: yoctocell.xyz (xyz)] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.4 RDNS_DYNAMIC Delivered to internal network by host with dynamic-looking rDNS -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager 0.5 FROM_SUSPICIOUS_NTLD From abused NTLD 1.0 BULK_RE_SUSP_NTLD Precedence bulk and RE: from a suspicious TLD On Thu, Apr 01 2021, Leo Prikler wrote: > Hi, > > Am Donnerstag, den 01.04.2021, 09:51 +0200 schrieb Xinglu Chen: >> This patchset adds the 'gh' package, a CLI interface to GitHub. The >> Go importer did most of the work. :) > I am not experienced with Go, so I can't comment on the rest too much, > but I wanted to point out, that single, double and triple letter > packages are (imo rightly) frowned upon in the Guix project. > Considering, that this is the *official* Github CLI tool, a name like > "github-cli" would probably make more sense here. Oh yeah, I saw the thread on guix-devel, I should have thought of this. >> - When building'gh', I couldn't get >> 'go-github-com-charmbracelet-glamour' to build without moving some >> native-inputs to propagated-inputs, though, if I was only building >> 'go-github-com-charmbracelet-glamour' it would build without moving >> things to propagated-inputs. I am not sure why this happens. > Perhaps you need to add those native inputs as native inputs to gh as > well? Try adding its native inputs to gh and see whether that changes > something. I will try and report back. >> - The patch marked with 'D' adds a package which has been deprecated >> by upstream, but it is still needed by one of the packages that 'gh' >> depend on. I have marked it as a hidden package, let me know if this >> is the right decision. > Yes, we do so for other packages as well, that require outdated or > otherwise modified versions, that should not show up in user profiles > unless they really, really want to and use manifests to achieve their > goals. Good to know, I will have to mark 'go-github-com-cli-shurcool-graphql' as hidden as well since it's GitHubs' fork of 'go-github-com-shurcool-graphql' and most likely only used by 'gh'. >> - The patch marked with 'W' adds a package which is needed by 'gh', >> but only used on Windows. It is still Free Software (BSD-2), but I >> have also marked it as hidden. > This is at least in some sense an acceptable workaround, but how large > would the effort be to outright drop references to this package, given > that it's already not "actively" being used? I am not familiar with the Go ecosystem so I don't know if this will be possible, but I will look into it. Thank you for the rewiew!