From debbugs-submit-bounces@debbugs.gnu.org Fri Apr 02 09:20:28 2021 Received: (at 47282) by debbugs.gnu.org; 2 Apr 2021 13:20:28 +0000 Received: from localhost ([127.0.0.1]:59430 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lSJiu-0002aW-1g for submit@debbugs.gnu.org; Fri, 02 Apr 2021 09:20:28 -0400 Received: from mail1.fsfe.org ([217.69.89.151]:55390) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lSJir-0002aN-U0 for 47282@debbugs.gnu.org; Fri, 02 Apr 2021 09:20:26 -0400 From: Jelle Licht To: Efraim Flashner , Timothy Sample Subject: Re: [bug#47282] [PATCH v2 13/13] gnu: Add node-lts. In-Reply-To: References: <87k0pprz6n.fsf@ngyro.com> <20210330052743.575-13-samplet@ngyro.com> Date: Fri, 02 Apr 2021 15:20:24 +0200 Message-ID: <86h7ko3js7.fsf@fsfe.org> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 47282 Cc: 47282@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) Efraim Flashner writes: > On Tue, Mar 30, 2021 at 01:27:43AM -0400, Timothy Sample wrote: >> + (arguments >> + (substitute-keyword-arguments (package-arguments node) >> + ((#:configure-flags configure-flags) >> + ''("--shared-cares" >> + "--shared-libuv" >> + "--shared-nghttp2" >> + "--shared-openssl" >> + "--shared-zlib" >> + "--shared-brotli" >> + "--with-intl=system-icu")) >> + ((#:phases phases) >> + `(modify-phases ,phases >> + (replace 'configure >> + ;; Node's configure script is actually a python script, so we can't >> + ;; run it with bash. >> + (lambda* (#:key outputs (configure-flags '()) inputs >> + #:allow-other-keys) >> + (let* ((prefix (assoc-ref outputs "out")) >> + (flags (cons (string-append "--prefix=" prefix) >> + configure-flags))) >> + (format #t "build directory: ~s~%" (getcwd)) >> + (format #t "configure flags: ~s~%" flags) >> + ;; Node's configure script expects the CC environment variable to >> + ;; be set. >> + (setenv "CC" (string-append (assoc-ref inputs "gcc") "/bin/gcc")) > > again cc-for-target Ack. >> [snip] >> + ;; FIXME: These tests fail on armhf-linux: >> + ;; https://github.com/nodejs/node/issues/31970 >> + ,@(if (string-prefix? "arm" (%current-system)) > > This could probably be changed to ,@(when (target-arm32?) I changed it to ,@(if (target-arm32?), as otherwise the #f-branch spliced #unspecified into the list.