From debbugs-submit-bounces@debbugs.gnu.org Sat Mar 20 04:51:54 2021 Received: (at 47269) by debbugs.gnu.org; 20 Mar 2021 08:51:54 +0000 Received: from localhost ([127.0.0.1]:51479 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lNXKs-0001S7-54 for submit@debbugs.gnu.org; Sat, 20 Mar 2021 04:51:54 -0400 Received: from albert.telenet-ops.be ([195.130.137.90]:40652) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lNXKo-0001Rx-Vl for 47269@debbugs.gnu.org; Sat, 20 Mar 2021 04:51:53 -0400 Received: from ptr-bvsjgyjmffd7q9timvx.18120a2.ip6.access.telenet.be ([IPv6:2a02:1811:8c09:9d00:aaf1:9810:a0b8:a55d]) by albert.telenet-ops.be with bizsmtp id iYro2400U0mfAB406Yrovm; Sat, 20 Mar 2021 09:51:49 +0100 Message-ID: <6ac44e1dc193a3d78351aed9a80e1c651e809ab5.camel@telenet.be> Subject: Re: [bug#47269] [PATCH 0/1] Add node-global-gradle-clean From: Maxime Devos To: Dhruvin Gandhi , 47269@debbugs.gnu.org Date: Sat, 20 Mar 2021 09:51:41 +0100 In-Reply-To: <20210319192144.17799-1-contact@dhruvin.dev> References: <20210319192144.17799-1-contact@dhruvin.dev> Content-Type: multipart/signed; micalg="pgp-sha256"; protocol="application/pgp-signature"; boundary="=-QsSyTXOcMrFcABbfW34i" User-Agent: Evolution 3.34.2 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r21; t=1616230309; bh=Ea06ulRFUjgfk+suNezWEvX3GfNdDVJfz3anzo9sWm4=; h=Subject:From:To:Date:In-Reply-To:References; b=kV6slwmzQ2udyIyVc9sH9mhfOewIgcFI/X4c2Gd4kL7Z38Z0v7ERgcZs2WtQhURpL EyI6Db7CWxpI+RyoCongbSsgyu9t6tCFZqCn9mSFE3J3/HQtgThK9fPOvG5VEhF0k0 uU4bEjk5YXyLzF3eqwyN72cB2w+/NSjCNoVuZR5ow+ZHVX1obHqcTA1oxUhYAXceuw A5gWLLByNQhED0c9Ip0uUxH1pnSmxiSjIF8/wkKua8qbPO6p8rr5rmvaS0Ir4tdWyU APUYojqzYPZMr8O1XFqZLf33+iG2PIT+qmevWwrLAhZmlGoM9x5nl+xbltnhp9PLNo X09n66tdu7iPA== X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 47269 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-QsSyTXOcMrFcABbfW34i Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Sat, 2021-03-20 at 00:51 +0530, Dhruvin Gandhi via Guix-patches via wrot= e: > I've recently started using Guix System and it has been my daily driver f= or a > month now. Surprisingly, guix already has every package I need. I decided= to > ask my friends about packages they'll need before they can start using Gu= ix. >=20 > I will try to submit patches of those packages in coming months. I am new= to > guix, and am new to contributing code via patches. Let me know if you hav= e any > corrections/suggestions. See =E2=80=9816.4 Packaging Guidelines=E2=80=99 and =E2=80=9816.6 Submittin= g Patches=E2=80=99 in the manual. > Dhruvin Gandhi (1): > Add node-global-gradle-clean >=20 > gnu/packages/node-xyz.scm | 22 ++++++++++++++++++++++ > 1 file changed, 22 insertions(+) There's an uniform style for commit messages. Example for when adding new packages: (start snip) commit 7382b1027a319e505be6cfcadf1f5bd761dadccc Author: Ricardo Wurmus Date: Thu Feb 4 23:20:05 2021 +0100 gnu: Add r-shinyjqui. =20 * gnu/packages/cran.scm (r-shinyjqui): New variable. commit 5ae09d7979a0696d862b9555314eab199f7ce576 Author: Ricardo Wurmus Date: Thu Feb 4 22:41:35 2021 +0100 gnu: Add r-spelling. =20 * gnu/packages/cran.scm (r-spelling): New variable. (end snip) (More examples in the git history) When defining a new package, usually a copyright line should be added at the top of the file. I prefer referring to the commit directly instead of by tag, as the commit is required for SWH fallback if the repo disappears. Is there any particular reason tests are disabled? Maybe add a comment "; No test suite." if that's the case. I'm not a fan of starting package descriptions with "This package is ...", even though plenty of plenty of packages in gnu/package/node-xyz.scm have such a description. A description from gnu/packages/guile-xyz.scm I like: "Guile-DSV is a GNU Guile module for working with the delimiter-separated values (DSV) data format. Guile-DSV supports the Unix-style DSV format and RFC 4180 format." Greetings, Maxime. --=-QsSyTXOcMrFcABbfW34i Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iI0EABYIADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYFW3nRccbWF4aW1lZGV2 b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7siVAP4wF9MCySxbUVov1wjxps6avUqu wbz9BCDDLk6jfu4hrgEAlbYv30gh2RQ7augbM1RwXhXXu6dy5+NWa2iYj8EKjAI= =03uX -----END PGP SIGNATURE----- --=-QsSyTXOcMrFcABbfW34i--