From debbugs-submit-bounces@debbugs.gnu.org Tue Mar 16 08:46:37 2021 Received: (at 47187) by debbugs.gnu.org; 16 Mar 2021 12:46:37 +0000 Received: from localhost ([127.0.0.1]:38424 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lM95o-0005Xy-SR for submit@debbugs.gnu.org; Tue, 16 Mar 2021 08:46:37 -0400 Received: from mail.zaclys.net ([178.33.93.72]:35141) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lM95l-0005Xj-83 for 47187@debbugs.gnu.org; Tue, 16 Mar 2021 08:46:35 -0400 Received: from guix-xps.local (82-64-145-38.subs.proxad.net [82.64.145.38]) (authenticated bits=0) by mail.zaclys.net (8.14.7/8.14.7) with ESMTP id 12GCkQnf004376 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Tue, 16 Mar 2021 13:46:26 +0100 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.zaclys.net 12GCkQnf004376 Authentication-Results: mail.zaclys.net; dmarc=fail (p=reject dis=none) header.from=zaclys.net Authentication-Results: mail.zaclys.net; spf=fail smtp.mailfrom=lle-bout@zaclys.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=zaclys.net; s=default; t=1615898787; bh=8S/yRw71eSNVSlh9M0Xb3nE7hl60+nY7+islSaKrzdU=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=FTeLL6/9ZFb9iopS/69WNes/m7HMq+TD9/hxt5q11/9VcQP471yWJJqqwHScPUl9c ydLpTmnz+XiC3zuEDo/nErWNv/mu8txotcDMhVS1Ae/M723L7FowvLiyBB7rxTDDmt G2XU+2W/AaQ2alsuM0wkfg5Dn/KFBLOUYNkpkGUM= Message-ID: <8f7d4c04d96fdf8cf1239c476c4c869f92446ada.camel@zaclys.net> Subject: Re: [bug#47187] [PATCH] gnu: Add c-lightning. From: =?ISO-8859-1?Q?L=E9o?= Le Bouter To: ZmnSCPxj Date: Tue, 16 Mar 2021 13:46:22 +0100 In-Reply-To: References: <81c654076d3c07c0f7d1657b4e44dce29a01eca2.camel@zaclys.net> <9436292ea880757cf47a5ce59879e6e7098ff195.camel@zaclys.net> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-N61jddAvNG+oXihVVnBc" User-Agent: Evolution 3.34.2 MIME-Version: 1.0 X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 47187 Cc: "47187@debbugs.gnu.org" <47187@debbugs.gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-N61jddAvNG+oXihVVnBc Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, 2021-03-16 at 11:27 +0000, ZmnSCPxj wrote: > Already working on that, but 0.10.0 will release soon and I doubt my > changes will make it by then, so Guix might get c-lightning to 0.10.1 > or later if we wait for it. Awesome! > Yes, it is true that there is something of a requirement of a strict > behavior here, I suppose it is possible to use `git-fetch` instead of > `url-fetch` for our external libraries. Yes you can use git-fetch, to make sure we are on the same page, are you speaking of strict behavior requirements like for Bitcoin Core's consensus code? > How do I generate `guix hash` for `git-fetch`ed `source`s? Actually what I do is put a wrong hash in and then copy the "actual hash" from the error. I havent found another way but this definitely feels subpar and prevents much verification before putting in the hash, better suggestions welcome. > However it also means that every release of C-Lightning I have to go > double-check what git commit to use for each library (though `jsmn` > and `libbacktrace` at least seem very stable). >=20 > But it looks to me that unvendoring will require more extensive > patching of the `Makefile` and an even larger maintenance burden on > Guix side? Unvendoring is more or less a policy because we must be able to audit each piece of software separately for freedom issues (licenses, violations to the GNU FSDG), and it eases work for security-patching also. > `libwally-core` itself depends on another library `libsecp256k1`, so > I suppose it must transitively be unvendored as well. Probably, we already have a libsecp256k1 specially for Bitcoin Core. > The test suite is fairly large and can take a significant amount of > time to run in full. That's fine. > In addition, part of the test includes checks which take advantage of > `BINTOPKGLIBEXECDIR` relative path we normally use, which I want to > disable for Guix at least since the relative path only has an > advantage if the user wants to move the installation after-the-fact > to a different location (and on Guix the "installation" path cannot > be moved anyway). > Using an absolute `BINTOPKGLIBEXECDIR` gives an advantage as > mentioned in the comments that a profile being upgraded from one > version of C-Lightning to another does not cause problems for daemons > currently running off the profile. > The test can be disabled (but not easily), I suppose. Problematic or unrealistically expensive tests can be disabled yes. > Please do, I am not very familiar with any Python infrastructure and > am primarily a C programmer here, I just barely hack together some > kind of test in Python. If you can list the Python dependencies and their version I can look at packaging them. > Regards, > ZmnSCPxj L=C3=A9o --=-N61jddAvNG+oXihVVnBc Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEFIvLi9gL+xax3g6RRaix6GvNEKYFAmBQqJ4ACgkQRaix6GvN EKYMUA//ZJUL8DkBhtuS7WPYCcbnViobj2/R8xmSNa006kXkpG8pzlOrhwwTgeHi Be0oCbLoDefssky0YAZVYOZjBfFb4QyX7S7f9oEBRTmGlPWTxcyNqs+STt/TYJEw Uqj/tcdpDfEekADnaggyaOkTaiGpHrHfrgcILmIqTRJe9k9LiCX83O9IELr1nXzp XrKFdMD/9rShKVobqMKtPzdrO5+H7EquC0az3iI/WXvmc/I0qJsS/WdJC62dneHu kbrwAQvSd6MxJmO/d01MG+zP1k9nZ0eKrQZH4vJz2aznqe7gaDP5buoK0ZO1t15b XHpsaHqL+TEsOTuj52eBdO0a7g7c1XHkq8DRFLcUz6EapijkGKIIfqavo8m80Lzx 4VZ0WGX//cmAX4ApvzwIUp5j9MRGf6aCZ5Dur5mJY4+j10sWYL2UfX6DoYjX1LBx 3h5DBAIMh9jWrWFUbtOlTIx1oDCoXuma5nUhfA/yPH98nHxYN1sckWkNhu2Z74nW /wOk+pGfozU6JwgFhSpWDU3xvipP+j+F7l8Ap4RBQtjZtIVfPziv3ETq86raiK6+ w8UDXhDCN5OQhgXNZpZ4kioRxN2CNZUl5DopAVHoaDUiIN1KL4QfGAYjQ8g8Ytsx PUKxcY66j7Js57N1P3+HRq75s/vNbHFpLwdLxNDvUnRrCrNyDok= =Egcs -----END PGP SIGNATURE----- --=-N61jddAvNG+oXihVVnBc--