From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 18 02:10:34 2021 Received: (at 47182) by debbugs.gnu.org; 18 Mar 2021 06:10:34 +0000 Received: from localhost ([127.0.0.1]:44674 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lMlre-00054f-2c for submit@debbugs.gnu.org; Thu, 18 Mar 2021 02:10:34 -0400 Received: from mail-pj1-f50.google.com ([209.85.216.50]:33414) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lMlra-00054K-Sq for 47182@debbugs.gnu.org; Thu, 18 Mar 2021 02:10:32 -0400 Received: by mail-pj1-f50.google.com with SMTP id lr1-20020a17090b4b81b02900ea0a3f38c1so6384985pjb.0 for <47182@debbugs.gnu.org>; Wed, 17 Mar 2021 23:10:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:in-reply-to:references:user-agent:date :message-id:mime-version; bh=72vPn7iZzF5c9DVtaLIerSwzFRIH8ciVMa20AKaWGAQ=; b=UqsDF74BpMxSuAYlek1qMEWYt2V8Tb96INuqUBD8HkKr63/QZx5ae67CbFE4fSelXL AyjLcEkdkjOE6vnc00qhlJUUcrUstKgjyekRFLfF2ifvmIbJPw4ynsevIrSZ+9/KLLAP AcJ+P2lG/GUaMHpCcsM71t5LgRt2WeTKDa/mf9/Vy3ELWPsgu+lxgEJte9wInRY4l4lB Y6sPTcQ6hi3vPl7OLn6ZBu5NgcuAIwciI0Mq74MUuhWnd4bKsKFvPdRSi9J9upc4VVPT Ou8+xbMfhgzJ6j5N3q6lq0otifL2BINQAs8exRSynkvm0JjhvgvuE4n5LUC1srJYNN50 tzzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references :user-agent:date:message-id:mime-version; bh=72vPn7iZzF5c9DVtaLIerSwzFRIH8ciVMa20AKaWGAQ=; b=YmHSwn8+o0GAoSyNgmkfynLr6B2O28N16eqRMY4Ot6PEEwGFGe0f3KBve1w/KLGn/b 3kDFmaqoibBINZ/e+8JJMh8WN6wZweT6EgkQ8CAkGoPAedVr1PKDQJsE5rp2R+BvX7Eu QjId2nP/B4qSWAVsnVQY11FIp/MuVAKuCHvNL8ibEW6LSFDwRXvn3mXbQrKvwqXQhLr7 FM36FhwToPlp0bAG3BLmxnlVQNkAShh3zTqo97EGmOQVpUCzb0EEtiVfVW5MpA7TcFpq Ip/1m5Xuz3OreptLCRHpWuYfuZvz9JOnk5110iahIGGVWWoReSl+ol2NGtfJzxovHwi7 9sTw== X-Gm-Message-State: AOAM530rQUZLip/19UjuxG6UBl/l//7qeknNUEjf3yM3fyh6M4PkYgM2 R3B4sGxEPOAeON1SWMrJG3/NDZBf9zQbFA== X-Google-Smtp-Source: ABdhPJwq+WVF25ynxLSigeNV78QAf0nOb3ikslJT0p12imQUTGognf7WsLfDp5LKe+svRa9aYBLmHw== X-Received: by 2002:a17:90a:5413:: with SMTP id z19mr2529989pjh.137.1616047824582; Wed, 17 Mar 2021 23:10:24 -0700 (PDT) Received: from garuda-lan (c-24-18-44-142.hsd1.wa.comcast.net. [24.18.44.142]) by smtp.gmail.com with ESMTPSA id v1sm920872pjt.1.2021.03.17.23.10.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Mar 2021 23:10:24 -0700 (PDT) From: Chris Marusich To: Efraim Flashner Subject: Re: bug#47182: [PATCH 00/18] Add support for powerpc64le-linux (wip-ppc64le-for-master) In-Reply-To: (Efraim Flashner's message of "Tue, 16 Mar 2021 09:49:29 +0200") References: <20210316062805.2890883-1-cmmarusich@gmail.com> <20210316064511.2891553-1-cmmarusich@gmail.com> <20210316064511.2891553-7-cmmarusich@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) Date: Wed, 17 Mar 2021 23:10:23 -0700 Message-ID: <87k0q5m1ps.fsf_-_@gmail.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 47182 Cc: 47182@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Efraim Flashner writes: > On Mon, Mar 15, 2021 at 11:45:00PM -0700, Chris Marusich wrote: >> * gnu/packages/commencement.scm (binutils-final)[arguments]: When checking if >> the system is a Power architecture, instead of hard-coding "powerpc-linux", >> use the target-powerpc? procedure so it works on more Power architectures. >> [inputs]: Likewise. >> --- >> gnu/packages/commencement.scm | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/gnu/packages/commencement.scm b/gnu/packages/commencement.scm >> index c0732bbf62d..d4511ed9148 100644 >> --- a/gnu/packages/commencement.scm >> +++ b/gnu/packages/commencement.scm >> @@ -3516,14 +3516,14 @@ exec ~a/bin/~a-~a -B~a/lib -Wl,-dynamic-linker -Wl,~a/~a \"$@\"~%" >> #:implicit-inputs? #f >> #:allowed-references >> ,@(match (%current-system) >> - ("powerpc-linux" >> + ((? target-powerpc?) > > I wonder if this would be better as ,@(if target-powerpc? > I didn't test to see how it would work with cross compiling, I don't > know if binutils-final gets built in that case. Are the final inputs ever cross-compiled? I'm having trouble thinking of a case when binutils-final would ever be cross-compiled. The package (like all the final inputs) exist specifically to provide the native GCC used for building the rest of the things in the system. In a case where you want to cross-compile e.g. GNU Hello, Guix first uses these final inputs to (natively) build a cross compilation toolchain, and then it will use that one to cross-compile GNU Hello. I don't think we need to account for cross-compliation of the final inputs, but please correct me if I'm wrong. -- Chris