From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 18 02:08:36 2021 Received: (at 47182) by debbugs.gnu.org; 18 Mar 2021 06:08:37 +0000 Received: from localhost ([127.0.0.1]:44670 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lMlpk-00051H-KT for submit@debbugs.gnu.org; Thu, 18 Mar 2021 02:08:36 -0400 Received: from mail-pg1-f181.google.com ([209.85.215.181]:36494) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lMlpi-000515-9G for 47182@debbugs.gnu.org; Thu, 18 Mar 2021 02:08:35 -0400 Received: by mail-pg1-f181.google.com with SMTP id h25so754568pgm.3 for <47182@debbugs.gnu.org>; Wed, 17 Mar 2021 23:08:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:in-reply-to:references:user-agent:date :message-id:mime-version:content-transfer-encoding; bh=zx2EopZdxNHxBqjdH1LuQKcA1C/3wE5WFX3SK2SWWos=; b=KVXz5s0qAbwstelOatAp4ZJhydMo1qcKdVuQtxKgHRznuTdZuAC+IdmxHtK0RsJ8Lu t95ACBXL1FRW51qDklur+giwTz+TXPTre6u/0Z299sFEI3TWfmTPFttgL51zTVgZXi5X vzfPrmYcHKvDz8fm65TUv5oUd/7Q9fhDe8/0RhPI8dXplyAZXUgGbejjjUFr7Du4KCqT QHFWD+34Gp7J7EeAiPtOdYQcLPs56T9uTezFGgGycosDPXv/R1teR/1/2A370a6K5xpO VyPEAdq2M3sPliaj8aB3Yhqop/ND1vAMWZORAA2GBqrstJIWEvsY+PomWpByLNVOD/IV C3LA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references :user-agent:date:message-id:mime-version:content-transfer-encoding; bh=zx2EopZdxNHxBqjdH1LuQKcA1C/3wE5WFX3SK2SWWos=; b=ouLcI/XuPSJ3I2cMC6I6kqDU0IX5HAupIZlrZlDZ9xyMiY0qFf3vto2LT+WAtEwqXR N6vbI9DsoW1cvGGiL1LkRYrvKWSC38kRA0YZzuN6+yJTVkcd8s6MuxcJ6t+h+tLJu/7g N07chkdzpVC73L/SlafDP3V1v/J7xslNhOAGGBatrJ0NKNKH8Fp5fS+Kkc5yJbuPY5Vr iGwAkqJwCAEDab5BtzVxmMaHaznBmM27G/5v0l8u3CY808UMnLZ+Xt/PShMoURUrgT24 yeFVYeexEKZduGaStCHA1sfKpaQ0Q9hUP1R7HD3iUf2EdoJkGO9TojxjfQEFtPcXc7ho WW7A== X-Gm-Message-State: AOAM531H4HBW9kl0JJQZuMfHIONIRbE2a8e8hHZu+Z39RuOMd9dYCSL9 ecQBQ4Lb7LgDQAyN54K1uu4drX/ueDnYhQ== X-Google-Smtp-Source: ABdhPJxS0jRWfixUzJVaeX3R35iF3sYUQJegzwGI+moNQAowdcyn1B2A3uEIgc/pkCtXIX8VhvYUWg== X-Received: by 2002:aa7:908c:0:b029:209:aacd:d8b with SMTP id i12-20020aa7908c0000b0290209aacd0d8bmr2568313pfa.74.1616047707780; Wed, 17 Mar 2021 23:08:27 -0700 (PDT) Received: from garuda-lan (c-24-18-44-142.hsd1.wa.comcast.net. [24.18.44.142]) by smtp.gmail.com with ESMTPSA id t19sm316484pfg.38.2021.03.17.23.08.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Mar 2021 23:08:27 -0700 (PDT) From: Chris Marusich To: Christopher Baines Subject: Re: bug#47182: [PATCH 00/18] Add support for powerpc64le-linux (wip-ppc64le-for-master) In-Reply-To: <8735wted0s.fsf@cbaines.net> (Christopher Baines's message of "Wed, 17 Mar 2021 20:33:23 +0000") References: <20210316062805.2890883-1-cmmarusich@gmail.com> <1b9220a0444ae0666354625a0abbc532cae3ccde.camel@zaclys.net> <87v99qmfls.fsf_-_@gmail.com> <8735wted0s.fsf@cbaines.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) Date: Wed, 17 Mar 2021 23:08:26 -0700 Message-ID: <87o8fhm1t1.fsf_-_@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 47182 Cc: =?utf-8?Q?L=C3=A9o?= Le Bouter , 47182@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Christopher Baines writes: > Chris Marusich writes: > >> L=C3=A9o Le Bouter writes: >> >>> As discussed on IRC, it turns out no world rebuild happens: >> >> Yes, and Christopher Baines explained that the outputs matter, not the >> derivations themselves. The outputs of hello and gcc-toolchain are the >> same on master as they are on the tip of wip-ppc64le-for-master, so I >> think I was just confused: we are good to merge to master, after all. > > Thanks for sending these patches, that means they've appeared in > Patchwork [1] and that the Guix Data Service has processed it as a patch > series [2]. > > 1: https://patches.guix-patches.cbaines.net/project/guix-patches/list/?se= ries=3D7335 > 2: > https://data.guix-patches.cbaines.net/compare?base_commit=3D341dfe7eda497= 2af0a027357015ea595314438b0&target_commit=3D4757434caeac0077f67583701653a7b= 89a335e61 > > Looking at that comparison, it seems good to merge! The new > powerpc64le-linux derivations could be computed, and there's a > relatively small number of x86_64-linux derivations affected [3], which > is good, as this can be merged to master then. > > 3: > https://data.guix-patches.cbaines.net/compare/package-derivations?base_co= mmit=3D341dfe7eda4972af0a027357015ea595314438b0&target_commit=3D4757434caea= c0077f67583701653a7b89a335e61&system=3Dx86_64-linux&target=3Dnone&build_cha= nge=3D&after_name=3D&limit_results=3D&all_results=3Don > > Chris Awesome! Thank you for this additional information. It's very helpful. It looks like a few hundred packages, according to that page. I've looked at the patches and I'm not sure exactly why they are rebuilt. One guess is that perhaps changes to build-side code (e.g., guix/build/syscalls.scm) are getting included in the output of some derivations (maybe module-import-compiled derivations?) whose knock-on effects down the line are not obvious. In any case, it's "only" a few hundred packages, judging by the page Chris linked. I would argue that it is better to merge this for the release and just rebuild those few hundred packages, rather than to postpone a change that will make it significantly easier for curious people to hop in and try out / help out with the powerpc64le-linux port. I think we've done a pretty good job of limiting the "rebuild" blast radius, so I think we should go ahead and merge it. --=20 Chris