From debbugs-submit-bounces@debbugs.gnu.org Sun Jan 31 15:36:59 2021 Received: (at 46215) by debbugs.gnu.org; 31 Jan 2021 20:36:59 +0000 Received: from localhost ([127.0.0.1]:58185 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l6JSs-0005cC-MU for submit@debbugs.gnu.org; Sun, 31 Jan 2021 15:36:59 -0500 Received: from mailrelay.tugraz.at ([129.27.2.202]:5511) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l6JSq-0005c2-5k for 46215@debbugs.gnu.org; Sun, 31 Jan 2021 15:36:57 -0500 Received: from nijino.local (217-149-173-242.nat.highway.telekom.at [217.149.173.242]) by mailrelay.tugraz.at (Postfix) with ESMTPSA id 4DTNCn2ldWz1LBMx; Sun, 31 Jan 2021 21:36:53 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 mailrelay.tugraz.at 4DTNCn2ldWz1LBMx DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tugraz.at; s=mailrelay; t=1612125413; bh=lk+O+il58psFa2dbAwJTvGlHvfPB06i8kYyyzve8ltI=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=rxerunEbUSyErxqcmG7rbNpuEJKzfYvPZaX2Qgttbv0SPD2uqGvelDKFIks8EG3M0 3MqKShhkImEZX8sMNS/HVhTIkyekC3XZmfPhYdmkJE8pskK4Tyk4qHI6z6ExuPyWPw ZPJCIFlY7I8R6hwuosbgU5URLSK3lIRrpooH2VJI= Message-ID: <0ff6a0c2cc9a2f65cd51c1eeb9e6a33aa4789766.camel@student.tugraz.at> Subject: Re: [PATCH] Add yadm From: Leo Prikler To: Ellis =?UTF-8?Q?Keny=C5=91?= Date: Sun, 31 Jan 2021 21:36:52 +0100 In-Reply-To: <87czxkc0yv.fsf@elken.dev> References: <20210131164721.8792-1-me@elken.dev> <84ab5054792abeb5e9b85d21229cd7182204d817.camel@student.tugraz.at> <87czxkc0yv.fsf@elken.dev> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.34.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-TUG-Backscatter-control: bt4lQm5Tva3SBgCuw0EnZw X-Spam-Scanner: SpamAssassin 3.003001 X-Spam-Score-relay: -1.9 X-Scanned-By: MIMEDefang 2.74 on 129.27.10.116 X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 46215 Cc: 46215@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi Ellen, Am Sonntag, den 31.01.2021, 20:16 +0000 schrieb Ellis KenyƑ: > Hi Leo, > > Thanks for the feedback. > > > Your commit is missing a ChangeLog in its message. > This will be added with the next patch. > > > Document why (i.e. "no check target"). > I have also added similar comments for the other removed stages. That's not as important, gnu-build-system is often used as base for packages and build system, that don't actually have configure. For disabled tests, however, it is not clear without comment whether they fail or whether they simply don't exist. > > yadm has a few things you need to patch. For one, its shebang > > is > > /bin/sh despite requiring bash. Also it contains a large number > > of > > _PROGRAM variables, which would be need to be replaced by their > > actual > > store path (use the which procedure for that). > > Patch them to be the $(which ) expression or evaluate that? > If the latter, I'm not sure how that would handle installing deps > retroactively. You'd add the packages, that define those programs as inputs, then you do something along the lines of (substitute* "yadm" (("(.*)_PROGRAM=\"(.*)\"" all var prog) (format #f "~a_PROGRAM=~s" var (which prog)))) inside some phase after unpack. Please apologize if the snippet above doesn't actually work for your case, I haven't tried it. By the way, git format-patch seems to swallow the Umlaut (or however it's called in your language) in your surname. If you want it to be that way, then fair enough, just know that there's no policy prohibiting UTF-8 in committer names. Regards, Leo