From debbugs-submit-bounces@debbugs.gnu.org Sun Jan 31 15:21:12 2021 Received: (at 46215) by debbugs.gnu.org; 31 Jan 2021 20:21:12 +0000 Received: from localhost ([127.0.0.1]:58135 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l6JDc-0005Bz-DZ for submit@debbugs.gnu.org; Sun, 31 Jan 2021 15:21:12 -0500 Received: from mail.elken.dev ([165.22.120.78]:48207) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l6JDZ-0005Bl-QS for 46215@debbugs.gnu.org; Sun, 31 Jan 2021 15:21:11 -0500 Received: from authenticated-user (mail.elken.dev [165.22.120.78]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by mail.elken.dev (Postfix) with ESMTPSA id 592BD3FBF2; Sun, 31 Jan 2021 21:21:03 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=elken.dev; s=mail; t=1612124463; bh=TibonrHSXqCEPTGgFj0OQIX07bnX+MG1LGawF+gTiZ8=; h=References:From:To:Cc:Subject:Date:In-reply-to:From; b=oSbhuHmtbFwxeoKKYho0LQTnuqoB4Lzi5uUnVbldUbaFpN/3yFqFpmnj/vNUlhVDc oDDBotAZ3tD/ChsBgUBOOQtTITV1q83jFURkODrJuwI8Fdwuaqi1M60P50p4QKI69x oPlxuhFm92RAR6LhQN78urbwVwt9YkEnGB/zW+kJyewnA3IGH0MieDZj8eCR3wUlOU OqLJU4umVOPWfsvXclR5tRAQYd7NCyoonlv06oCyWH6lrsR6l8Qu9cKRh8hy9R8Vqa GzFEgFrydblUNhaq9HM4Q52icw1fWwqEuIRI3ZSgTA6ZalLDYSuvwpRCs/cLSGVkVH 7G3t2o2dr0kXg== References: <20210131164721.8792-1-me@elken.dev> <84ab5054792abeb5e9b85d21229cd7182204d817.camel@student.tugraz.at> From: Ellis =?utf-8?Q?Keny=C5=91?= To: Leo Prikler Subject: Re: [PATCH] Add yadm Date: Sun, 31 Jan 2021 20:16:32 +0000 In-reply-to: <84ab5054792abeb5e9b85d21229cd7182204d817.camel@student.tugraz.at> Message-ID: <87czxkc0yv.fsf@elken.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 46215 Cc: 46215@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Leo, Thanks for the feedback. > Your commit is missing a ChangeLog in its message. This will be added with the next patch. > Document why (i.e. "no check target"). I have also added similar comments for the other removed stages. > yadm has a few things you need to patch. For one, its shebang=20 > is > /bin/sh despite requiring bash. Also it contains a large number=20 > of > _PROGRAM variables, which would be need to be replaced by their=20 > actual > store path (use the which procedure for that). Patch them to be the $(which ) expression or evaluate that? If the latter, I'm not sure how that would handle installing deps retroactively. > Nice advertisement, but not really a description. yadm.1 has a=20 > better > one, but keep to the formatting in Guix (particularly double=20 > spaces > after sentence end). I was looking for an accurate description on the site, I have=20 replaced with that and the linter passes. > Should be gpl3+. This will also be added to the next patch. Leo Prikler writes: > Hello Ellis, > > Am Sonntag, den 31.01.2021, 16:47 +0000 schrieb Ellis Kenyo: >> --- >> gnu/packages/package-management.scm | 32 >> +++++++++++++++++++++++++++++ >> 1 file changed, 32 insertions(+) > Your commit is missing a ChangeLog in its message. > >> [...] >> + (build-system gnu-build-system) >> + (arguments >> + '(#:tests? #f > Document why (i.e. "no check target"). > >> + #:make-flags (list (string-append "PREFIX=3D" (assoc-ref >> %outputs "out"))) >> + #:phases >> + (modify-phases %standard-phases >> + (delete 'bootstrap) >> + (delete 'configure) >> + (delete 'build)))) > yadm has a few things you need to patch. For one, its shebang=20 > is > /bin/sh despite requiring bash. Also it contains a large number=20 > of > _PROGRAM variables, which would be need to be replaced by their=20 > actual > store path (use the which procedure for that). > >> + (description "When you live in a command line,=20 >> configurations >> are a deeply >> +personal thing. They are often crafted over years of=20 >> experience, >> battles lost, >> +lessons learned, advice followed, and ingenuity rewarded. When=20 >> you >> are away >> +from your own configurations, you are an orphaned refugee in >> unfamiliar and >> +hostile surroundings. You feel clumsy and out of sorts. You=20 >> are >> filled with a >> +sense of longing to be back in a place you know. A place you=20 >> built. >> A place >> +where all the short-cuts have been worn bare by your own=20 >> travels. A >> place you >> +proudly call=E2=80=A6 $HOME.") > Nice advertisement, but not really a description. yadm.1 has a=20 > better > one, but keep to the formatting in Guix (particularly double=20 > spaces > after sentence end). > >> + (license license:gpl3))) > Should be gpl3+. > > Regards, > Leo --=20 --- elken