From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 11 17:29:54 2021 Received: (at 46182) by debbugs.gnu.org; 11 Mar 2021 22:29:54 +0000 Received: from localhost ([127.0.0.1]:55313 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lKToY-0008V3-EL for submit@debbugs.gnu.org; Thu, 11 Mar 2021 17:29:54 -0500 Received: from eggs.gnu.org ([209.51.188.92]:48924) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lKToW-0008Un-91 for 46182@debbugs.gnu.org; Thu, 11 Mar 2021 17:29:52 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:33602) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lKToR-0001B6-1U; Thu, 11 Mar 2021 17:29:47 -0500 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=57040 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1lKToI-0004Yj-US; Thu, 11 Mar 2021 17:29:41 -0500 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Leo Famulari Subject: Re: bug#46182: [PATCH] lint: Add 'check-git-protocol' checker. References: Date: Thu, 11 Mar 2021 23:29:37 +0100 In-Reply-To: (Leo Famulari's message of "Fri, 29 Jan 2021 20:04:06 -0500") Message-ID: <87zgz9uxwu.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 46182 Cc: 46182@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hi! Leo Famulari skribis: > We could also make it warn about use of the HTTP protocol (as opposed to > HTTPS). Your thoughts? > > * guix/lint.scm (check-git-protocol): New procedure. > (%local-checkers): Add 'git-protocol' checker. > * doc/guix.texi (Invoking guix lint): Document it. Nice! I think it=E2=80=99s OK to use =E2=80=98eqv?=E2=80=99 here (=E2=80= =98eq?=E2=80=99, even). One nit: it would be nice to add a positive and a negative test in tests/lint.scm. You can run =E2=80=9Cmake check TESTS=3Dtests/lint.scm=E2= =80=9D then. Otherwise LGTM! Thanks, Ludo=E2=80=99.