From debbugs-submit-bounces@debbugs.gnu.org Tue Feb 09 05:22:36 2021 Received: (at 45889) by debbugs.gnu.org; 9 Feb 2021 10:22:36 +0000 Received: from localhost ([127.0.0.1]:52740 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l9QAG-0008WS-0b for submit@debbugs.gnu.org; Tue, 09 Feb 2021 05:22:36 -0500 Received: from mailrelay.tugraz.at ([129.27.2.202]:15643) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l9QAB-0008WE-DC for 45889@debbugs.gnu.org; Tue, 09 Feb 2021 05:22:34 -0500 Received: from nijino.local (217-149-165-242.nat.highway.telekom.at [217.149.165.242]) by mailrelay.tugraz.at (Postfix) with ESMTPSA id 4DZf8g48R1z1LB1w; Tue, 9 Feb 2021 11:22:27 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 mailrelay.tugraz.at 4DZf8g48R1z1LB1w DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tugraz.at; s=mailrelay; t=1612866147; bh=rY8a1z+WN4Pl4UfVukNy3r70vRMcOJvtKXcOKiatysk=; h=Subject:From:To:Date:In-Reply-To:References:From; b=nNmC3O7opNgIE5U0hBppj1bJETyIvJTuNbFSwWEO8s3iIpRSG4z3wFS4WsfvdupYm JCYbt2D1sFcqdnOYBtje1fmGrhPtct9bjshT+iKgUNXu9q8jt7dzLpmMVDB/ZslvGs EVHICmnInOUFbpn2V+O5fRYeJB6oHJ0YFwgFuW4M= Message-ID: <8b239920351c99a887835c98fd9a3892b9cfd0f5.camel@student.tugraz.at> Subject: Re: Nextcloud Client (v7) From: Leo Prikler To: Raghav Gururajan , 45889@debbugs.gnu.org Date: Tue, 09 Feb 2021 11:22:26 +0100 In-Reply-To: <609483b4-c583-cbf0-4b2a-4daf6c4feb98@raghavgururajan.name> References: <609483b4-c583-cbf0-4b2a-4daf6c4feb98@raghavgururajan.name> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.34.2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-TUG-Backscatter-control: bt4lQm5Tva3SBgCuw0EnZw X-Spam-Scanner: SpamAssassin 3.003001 X-Spam-Score-relay: -1.9 X-Scanned-By: MIMEDefang 2.74 on 129.27.10.117 X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 45889 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hello, Am Montag, den 01.02.2021, 10:13 -0500 schrieb Raghav Gururajan: > Subject: [PATCH 1/3] gnu: Add appstream. Mostly LGTM. > + (native-inputs > + `(("cmake" ,cmake) Is cmake really needed? I know that meson falls back to cmake if pkg- config fails and also supports output to cmake, but meson/ninja should be the default. > Subject: [PATCH 2/3] gnu: kwayland: Disable failing tests. LGTM, we might want to push that independently. > + (let ((keep '( ;; Not available in Guix. > + "QProgressIndicator" "kmessagewidget" > "qtlockedfile" > + "qtokenizer" "qtsingleapplication"))) Could you try packaging those for Guix as well? > + #:imported-modules > + (,@%qt-build-system-modules > + (guix build glib-or-gtk-build-system)) > + #:modules > + ((guix build qt-build-system) > + ((guix build glib-or-gtk-build-system) > + #:prefix glib-or-gtk:) > + (guix build utils)) As with your telegram patch, I personally think the ordering is wrong here. > + (("PKGCONFIG_GETVAR\\(dbus-1 session_bus_services_dir > _install_dir\\)") > + "set(_install_dir > \"${CMAKE_INSTALL_PREFIX}/share/dbus-1/services\")")) You might want to regexp the middle part in case it is changed. > + ;; Turn-off the use of absolute Qt paths for > installation. > + (substitute* "shell_integration/dolphin/CMakeLists.txt" > + (("ON CACHE") > + "OFF CACHE")) What does this achieve exactly? Btw. slightly off-topic, but if you're planning to reply to this patch- set and send v8 at roughly the same time, please collapse it to a single message as you're already using a "patches as attachments" style. Having everything in a single message makes it a little easier for me to respond and Evolution can save all attachments to a directory just fine. Regards, Leo