From debbugs-submit-bounces@debbugs.gnu.org Fri Jan 15 03:56:51 2021 Received: (at 45860) by debbugs.gnu.org; 15 Jan 2021 08:56:51 +0000 Received: from localhost ([127.0.0.1]:39870 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l0KuY-0007Jg-UG for submit@debbugs.gnu.org; Fri, 15 Jan 2021 03:56:51 -0500 Received: from eggs.gnu.org ([209.51.188.92]:45768) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l0KuY-0007JS-02 for 45860@debbugs.gnu.org; Fri, 15 Jan 2021 03:56:50 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:41162) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l0KuS-00010d-Fu; Fri, 15 Jan 2021 03:56:44 -0500 Received: from [2a01:e0a:19b:d9a0:1538:87ab:3a95:7600] (port=59874 helo=cervin) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1l0KuR-0005PV-T3; Fri, 15 Jan 2021 03:56:44 -0500 From: Mathieu Othacehe To: Christopher Baines Subject: Re: [bug#45860] Improve PostgreSQL service. References: <87h7nj4p3g.fsf@gnu.org> <87a6tb9o84.fsf@cbaines.net> Date: Fri, 15 Jan 2021 09:56:41 +0100 In-Reply-To: <87a6tb9o84.fsf@cbaines.net> (Christopher Baines's message of "Thu, 14 Jan 2021 21:56:43 +0000") Message-ID: <87v9byo9x2.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 45860 Cc: 45860@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hello Chris, > I haven't read through these changes in detail, but the mixing of the > record describing the config file, and the record for configuring the > service introduces the limitation that you can no longer specify any > lowerable object (like a file) or something like a string to use a > config file outside of the store. Did you have a reason for mixing the > records together? I must admit I overlooked that possibility. The reason for merging the records is that the "log-destination" is now needed both to enable "pg_ctl" logging in "postgresql-shepherd-service" and in "postgresql-config-file" to be written in PostgreSQL configuration. Plus having a record called that does not contain some of the configuration field feels weird. Is passing a lowerable config file a use case of yours? In that case I could still add a "raw-config" field to override the configuration file creation. Thanks, Mathieu