From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 28 07:05:58 2021 Received: (at 45860-done) by debbugs.gnu.org; 28 Jan 2021 12:05:58 +0000 Received: from localhost ([127.0.0.1]:47445 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l563h-0000d7-SC for submit@debbugs.gnu.org; Thu, 28 Jan 2021 07:05:58 -0500 Received: from eggs.gnu.org ([209.51.188.92]:48018) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l563e-0000ct-Kj for 45860-done@debbugs.gnu.org; Thu, 28 Jan 2021 07:05:56 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:40873) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l563Z-0005VY-HI; Thu, 28 Jan 2021 07:05:49 -0500 Received: from [2a01:e0a:19b:d9a0:98b7:b002:9499:5e2c] (port=42276 helo=cervin) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1l563Y-0007DF-RZ; Thu, 28 Jan 2021 07:05:49 -0500 From: Mathieu Othacehe To: Christopher Baines Subject: Re: [PATCH v2 5/5] services: postgresql: Add postgresql-role-service-type. References: <20210118101628.202607-1-othacehe@gnu.org> <20210118101628.202607-6-othacehe@gnu.org> <87eei6hiiy.fsf@cbaines.net> Date: Thu, 28 Jan 2021 13:05:47 +0100 In-Reply-To: <87eei6hiiy.fsf@cbaines.net> (Christopher Baines's message of "Wed, 27 Jan 2021 08:48:53 +0000") Message-ID: <87lfcd8dwk.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 45860-done Cc: 45860-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hey, > Why only support these two permissions/options? Accepting strings or > symbols, and then just converting to an upper case string would allow > all the permission options to be specified. Sure, fixed. > I'm guessing this service will fail if it's run twice, as the > role/database will already exist? Yes, I added a check for already existing roles before pushing. Thanks, Mathieu