From debbugs-submit-bounces@debbugs.gnu.org Wed Feb 10 09:17:47 2021 Received: (at 45692) by debbugs.gnu.org; 10 Feb 2021 14:17:48 +0000 Received: from localhost ([127.0.0.1]:55811 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l9qJP-0003FQ-Nw for submit@debbugs.gnu.org; Wed, 10 Feb 2021 09:17:47 -0500 Received: from eggs.gnu.org ([209.51.188.92]:48848) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l9qJO-0003F9-Jq for 45692@debbugs.gnu.org; Wed, 10 Feb 2021 09:17:46 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:44032) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l9qJH-0004iP-QN; Wed, 10 Feb 2021 09:17:40 -0500 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=42972 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1l9qJH-0005xM-EB; Wed, 10 Feb 2021 09:17:39 -0500 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: raid5atemyhomework Subject: Re: bug#45692: [PATCH 0/4] Even Better ZFS Support on Guix References: Date: Wed, 10 Feb 2021 15:17:37 +0100 In-Reply-To: (raid5atemyhomework@protonmail.com's message of "Mon, 25 Jan 2021 00:18:12 +0000") Message-ID: <87sg646m7y.fsf_-_@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 45692 Cc: =?utf-8?B?5a6L5paH5q2m?= , "45692@debbugs.gnu.org" <45692@debbugs.gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hi! I agree with =E5=AE=8B=E6=96=87=E6=AD=A6. Still=E2=80=A6 raid5atemyhomework skribis: > (service-type (name 'file-systems) > (extensions > (list (service-extension shepherd-root-service-type > - file-system-shepherd-services) > + (lambda (value) > + (file-system-shepherd-servic= es > + (filter file-system? value) > + (filter symbol? value)))) > (service-extension fstab-service-type > - file-system-fstab-entries) > + (lambda (value) > + (file-system-fstab-entries > + (filter file-system? value)= ))) >=20=20 > ;; Have 'user-processes' depend on 'file-systems'. > (service-extension user-processes-service-type > (const '(file-systems))))) > + > + ;; Extensions consist of lists of objects = or > + ;; shepherd services=E2=80=99 names (symbols). In the l= atter case, > + ;; the provided shepherd services supposed to mount and > + ;; unmount some file systems themself. Why do we need to extend with symbols? In general it=E2=80=99s much clearer if extensions receive only one type of object ( records in this case). It=E2=80=99s also best to avo= id passing around symbolic names (that=E2=80=99s why we extend with records rather than with Shepherd service names or whatever.) Ludo=E2=80=99.