From debbugs-submit-bounces@debbugs.gnu.org Tue May 04 05:10:35 2021 Received: (at submit) by debbugs.gnu.org; 4 May 2021 09:10:35 +0000 Received: from localhost ([127.0.0.1]:51956 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ldr4d-0004mu-Cd for submit@debbugs.gnu.org; Tue, 04 May 2021 05:10:35 -0400 Received: from lists.gnu.org ([209.51.188.17]:42214) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ldr4c-0004mf-7b for submit@debbugs.gnu.org; Tue, 04 May 2021 05:10:34 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:43674) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ldr4b-0001FL-Rf for guix-patches@gnu.org; Tue, 04 May 2021 05:10:34 -0400 Received: from relay7-d.mail.gandi.net ([217.70.183.200]:36289) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ldr4Z-0006uc-JJ for guix-patches@gnu.org; Tue, 04 May 2021 05:10:33 -0400 X-Originating-IP: 86.233.159.27 Received: from pruneau.home (lfbn-poi-1-196-27.w86-233.abo.wanadoo.fr [86.233.159.27]) (Authenticated sender: d@divoplade.fr) by relay7-d.mail.gandi.net (Postfix) with ESMTPSA id 7772F20006; Tue, 4 May 2021 09:10:23 +0000 (UTC) Message-ID: Subject: Re: [bug#45558] [PATCH] Add js_of_ocaml From: divoplade To: pukkamustard Date: Tue, 04 May 2021 11:10:17 +0200 In-Reply-To: <86im3z9gdd.fsf@posteo.net> References: <559a908f91e39af40a1580447a708209785c69b8.camel@divoplade.fr> <86im3z9gdd.fsf@posteo.net> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.34.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=217.70.183.200; envelope-from=d@divoplade.fr; helo=relay7-d.mail.gandi.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.6 (-) X-Debbugs-Envelope-To: submit Cc: 45558@debbugs.gnu.org, 47769@debbugs.gnu.org, guix-patches@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.6 (--) Hello, Thank you for the interest in this issue. I realize I opened it at a rather inconvenient time, so I guess it ended up on the bottom of the pile for quite some time. Le lundi 03 mai 2021 à 12:38 +0000, pukkamustard a écrit : > I submitted a series of patches that does this for many OCaml > packages including the ones included in your series > (https://issues.guix.gnu.org/47768). The situation is quite complex to me, please bear with me. If I understand correctly, you pushed a lot of ocaml updates last month, making some of the changes I made in december somewhat obsolete. Right? So, now, I should your modified 5 patches in this issue on top of the 37 patches in the other issue to get js-of-ocaml. Is it correct? At this rate, if it is possible, maybe you could just append these 5 to the other issue, it would be easier to track. What do you think? I didn’t detect indentation problems by running ./etc/indent-code.el; even if other packages in the module have some indentation problems.